diff --git a/core/modules/editor/engines/framed.js b/core/modules/editor/engines/framed.js index 1a4b11c458..01e7045374 100644 --- a/core/modules/editor/engines/framed.js +++ b/core/modules/editor/engines/framed.js @@ -156,8 +156,8 @@ Fix the height of textarea to fit content FramedEngine.prototype.fixHeight = function() { // Make sure styles are updated this.copyStyles(); - // Adjust height - if(this.widget.editTag === "textarea") { + // If .editRows is initialised, it takes precedence + if(this.widget.editTag === "textarea" && !this.widget.editRows) { if(this.widget.editAutoHeight) { if(this.domNode && !this.domNode.isTiddlyWikiFakeDom) { var newHeight = $tw.utils.resizeTextAreaToFit(this.domNode,this.widget.editMinHeight); diff --git a/core/modules/editor/engines/simple.js b/core/modules/editor/engines/simple.js index 93f0215222..6260021274 100644 --- a/core/modules/editor/engines/simple.js +++ b/core/modules/editor/engines/simple.js @@ -100,7 +100,8 @@ SimpleEngine.prototype.getText = function() { Fix the height of textarea to fit content */ SimpleEngine.prototype.fixHeight = function() { - if(this.widget.editTag === "textarea") { + // If .editRows is initialised, it takes precedence + if((this.widget.editTag === "textarea") && !this.widget.editRows) { if(this.widget.editAutoHeight) { if(this.domNode && !this.domNode.isTiddlyWikiFakeDom) { $tw.utils.resizeTextAreaToFit(this.domNode,this.widget.editMinHeight); diff --git a/editions/tw5.com/tiddlers/releasenotes/5.4.0/#9454 - edit-text-rows-precedence.tid b/editions/tw5.com/tiddlers/releasenotes/5.4.0/#9454 - edit-text-rows-precedence.tid new file mode 100644 index 0000000000..a2a263b643 --- /dev/null +++ b/editions/tw5.com/tiddlers/releasenotes/5.4.0/#9454 - edit-text-rows-precedence.tid @@ -0,0 +1,10 @@ +title: $:/changenotes/5.4.0/#9454 +description: Ensure rows parameter of edit-text widget takes precedence +tags: $:/tags/ChangeNote +release: 5.4.0 +change-type: feature +change-category: widget +github-links: https://github.com/TiddlyWiki/TiddlyWiki5/pull/9454 +github-contributors: pmario + +Edit-text widget rows parameter takes precedence diff --git a/editions/tw5.com/tiddlers/widgets/EditTextWidget.tid b/editions/tw5.com/tiddlers/widgets/EditTextWidget.tid index 609cf36ffe..103b95677c 100644 --- a/editions/tw5.com/tiddlers/widgets/EditTextWidget.tid +++ b/editions/tw5.com/tiddlers/widgets/EditTextWidget.tid @@ -1,7 +1,7 @@ caption: edit-text created: 20131024141900000 heading: -modified: 20240627184331133 +modified: 20251118230450156 tags: Widgets temp: title: EditTextWidget @@ -11,40 +11,40 @@ type: text/vnd.tiddlywiki The edit text widget provides a user interface in the browser for editing text tiddler fields. The editing element is dynamically bound to the underlying tiddler value: changes to the tiddler are instantly reflected, and any edits are instantly propagated. -By default, applying the EditTextWidget to the `text` field of a tiddler will generates an HTML `