clone/TiddlyWiki5
1
0
Fork 0
mirror of https://github.com/TiddlyWiki/TiddlyWiki5.git synced 2026-02-01 22:07:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Select widget handle default parameter refresh (#9617)

Browse Source 
* select widget handle default parameter refresh

* Add change note
This commit is contained in:
Mario Pietsch
2026-01-25 19:58:52 +01:00
committed by GitHub
parent d07fe25cdb
commit cde9c931c8
2 changed files with 19 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
core/modules/widgets/select.js
View File

@@ -82,8 +82,8 @@ SelectWidget.prototype.handleChangeEvent = function(event) {
if(this.selectMultiple == false) { if(this.selectMultiple == false) {
var value = this.getSelectDomNode().value; var value = this.getSelectDomNode().value;
} else { } else {
var value = this.getSelectValues() var value = this.getSelectValues();
value = $tw.utils.stringifyList(value); value = $tw.utils.stringifyList(value);
} }
this.wiki.setText(this.selectTitle,this.selectField,this.selectIndex,value); this.wiki.setText(this.selectTitle,this.selectField,this.selectIndex,value);
// Trigger actions // Trigger actions
@@ -118,7 +118,7 @@ SelectWidget.prototype.setSelectValue = function() {
} }
} }
// Assign it to the select element if it's different than the current value // Assign it to the select element if it's different than the current value
if (this.selectMultiple) { if(this.selectMultiple) {
value = value === undefined ? "" : value; value = value === undefined ? "" : value;
var select = this.getSelectDomNode(); var select = this.getSelectDomNode();
var child, var child,
@@ -156,14 +156,14 @@ SelectWidget.prototype.getSelectValues = function() {
select = this.getSelectDomNode(); select = this.getSelectDomNode();
result = []; result = [];
options = select && select.options; options = select && select.options;
for (var i=0; i<options.length; i++) { for(var i=0; i<options.length; i++) {
opt = options[i]; opt = options[i];
if (opt.selected) { if(opt.selected) {
result.push(opt.value || opt.text); result.push(opt.value || opt.text);
} }
} }
return result; return result;
} };
/* /*
Compute the internal state of the widget Compute the internal state of the widget
@@ -192,7 +192,7 @@ Selectively refreshes the widget if needed. Returns true if the widget or any of
SelectWidget.prototype.refresh = function(changedTiddlers) { SelectWidget.prototype.refresh = function(changedTiddlers) {
var changedAttributes = this.computeAttributes(); var changedAttributes = this.computeAttributes();
// If we're using a different tiddler/field/index then completely refresh ourselves // If we're using a different tiddler/field/index then completely refresh ourselves
if(changedAttributes.tiddler || changedAttributes.field || changedAttributes.index || changedAttributes.tooltip || changedAttributes.tabindex || changedAttributes.disabled) { if(changedAttributes.tiddler || changedAttributes.field || changedAttributes.index || changedAttributes.tooltip || changedAttributes.default || changedAttributes.tabindex || changedAttributes.disabled) {
this.refreshSelf(); this.refreshSelf();
return true; return true;
} else { } else {

12
editions/tw5.com/tiddlers/releasenotes/5.4.0/#9617 - select-widget-refresh-default.tid Normal file
View File

@@ -0,0 +1,12 @@
change-category: usability
change-type: bugfix
created: 20260125195754439
description: Refresh widget if "default" parameter input value is changed
github-contributors: pmario
github-links: https://github.com/TiddlyWiki/TiddlyWiki5/pull/9217
modified: 20260125195754439
release: 5.4.0
tags: $:/tags/ChangeNote
title: $:/changenotes/5.4.0/#9217
type: text/vnd.tiddlywiki