From 2d0fcacc05adf72cedabd7f5e3ca217ee8444889 Mon Sep 17 00:00:00 2001 From: Boris Cherny Date: Sun, 9 Nov 2025 13:04:12 -0800 Subject: [PATCH] Update code-review.md to avoid flagging test failures --- plugins/code-review/commands/code-review.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/code-review/commands/code-review.md b/plugins/code-review/commands/code-review.md index 064aaae5..4b458592 100644 --- a/plugins/code-review/commands/code-review.md +++ b/plugins/code-review/commands/code-review.md @@ -31,7 +31,7 @@ Examples of false positives, for steps 4 and 5: - Pre-existing issues - Something that looks like a bug but is not actually a bug - Pedantic nitpicks that a senior engineer wouldn't call out -- Issues that a linter will catch (no need to run the linter to verify) +- Issues that a linter, typechecker, or test runner will catch (eg. failing tests, lint errors, type errors). Do not run these to verify; assume that they will be run as part of CI. - General code quality issues (eg. lack of test coverage, general security issues), unless explicitly required in CLAUDE.md - Issues that are called out in CLAUDE.md, but explicitly silenced in the code (eg. due to a lint ignore comment)