clone/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-04-24 22:54:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix: Lower log level for closed-channel send (#9653)

Browse Source 
## What?
- Downgrade the closed-channel send error log to debug in
`codex-rs/core/src/codex.rs`.

## Why?
- `async_channel::Sender::send` only fails when the channel is closed,
so the current error-level log is noisy during normal shutdown. See
issue #9652.

## How?
- Replace the error log with a debug log on send failure.

## Tests
- `just fmt`
- `just fix -p codex-core`
- `cargo test -p codex-core`
This commit is contained in:
Kbediako
2026-01-22 17:09:58 +11:00
committed by GitHub
parent 038b78c915
commit 079fd2adb9
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
codex-rs/core/src/codex.rs
View File

@@ -1181,7 +1181,7 @@ impl Session {
let rollout_items = vec![RolloutItem::EventMsg(event.msg.clone())]; let rollout_items = vec![RolloutItem::EventMsg(event.msg.clone())];
self.persist_rollout_items(&rollout_items).await; self.persist_rollout_items(&rollout_items).await;
if let Err(e) = self.tx_event.send(event).await { if let Err(e) = self.tx_event.send(event).await {
error!("failed to send tool call event: {e}"); debug!("dropping event because channel is closed: {e}");
} }
} }
@@ -1199,7 +1199,7 @@ impl Session {
.await; .await;
self.flush_rollout().await; self.flush_rollout().await;
if let Err(e) = self.tx_event.send(event).await { if let Err(e) = self.tx_event.send(event).await {
error!("failed to send tool call event: {e}"); debug!("dropping event because channel is closed: {e}");
} }
} }