From 0fac2744f744abfeabd71a18695a54f4f1006a2b Mon Sep 17 00:00:00 2001 From: pakrym-oai Date: Fri, 30 Jan 2026 14:12:50 -0800 Subject: [PATCH] Hide /approvals from the slash-command list (#10265) `/permissions` is the replacement. `/approvals` still available when typing. --- codex-rs/tui/src/bottom_pane/command_popup.rs | 9 ++++++--- codex-rs/tui/src/history_cell.rs | 5 ----- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/codex-rs/tui/src/bottom_pane/command_popup.rs b/codex-rs/tui/src/bottom_pane/command_popup.rs index 48ee7d2d60..2ece7b4fde 100644 --- a/codex-rs/tui/src/bottom_pane/command_popup.rs +++ b/codex-rs/tui/src/bottom_pane/command_popup.rs @@ -14,6 +14,11 @@ use codex_protocol::custom_prompts::CustomPrompt; use codex_protocol::custom_prompts::PROMPTS_CMD_PREFIX; use std::collections::HashSet; +// Hide alias commands in the default popup list so each unique action appears once. +// `quit` is an alias of `exit`, so we skip `quit` here. +// `approvals` is an alias of `permissions`. +const ALIAS_COMMANDS: &[SlashCommand] = &[SlashCommand::Quit, SlashCommand::Approvals]; + /// A selectable item in the popup: either a built-in command or a user prompt. #[derive(Clone, Copy, Debug, PartialEq, Eq)] pub(crate) enum CommandItem { @@ -122,9 +127,7 @@ impl CommandPopup { if filter.is_empty() { // Built-ins first, in presentation order. for (_, cmd) in self.builtins.iter() { - // Hide alias commands in the default popup list so each unique action appears once. - // `quit` is an alias of `exit`, so we skip `quit` here. - if *cmd == SlashCommand::Quit { + if ALIAS_COMMANDS.contains(cmd) { continue; } out.push((CommandItem::Builtin(*cmd), None)); diff --git a/codex-rs/tui/src/history_cell.rs b/codex-rs/tui/src/history_cell.rs index c4bd766655..39482bc1f3 100644 --- a/codex-rs/tui/src/history_cell.rs +++ b/codex-rs/tui/src/history_cell.rs @@ -974,11 +974,6 @@ pub(crate) fn new_session_info( "/status".into(), " - show current session configuration".dim(), ]), - Line::from(vec![ - " ".into(), - "/approvals".into(), - " - choose what Codex can do without approval".dim(), - ]), Line::from(vec![ " ".into(), "/permissions".into(),