clone/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-04-29 08:56:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

codex: address PR review feedback (#14225)

Browse Source
This commit is contained in:
pakrym-oai
2026-03-11 10:01:28 -07:00
parent 9d3d72b821
commit 0fd60a9b6b
5 changed files with 109 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
codex-rs/core/tests/suite/code_mode.rs
View File

@@ -24,6 +24,14 @@ use std::fs;
use std::time::Duration;
use wiremock::MockServer;
macro_rules! skip_on_bazel {
($result:expr) => {
if option_env!("BAZEL_PACKAGE").is_some() {
return $result;
}
};
}
fn custom_tool_output_items(req: &ResponsesRequest, call_id: &str) -> Vec<Value> {
req.custom_tool_call_output(call_id)
.get("output")
@@ -157,6 +165,7 @@ async fn run_code_mode_turn_with_rmcp(
#[cfg_attr(windows, ignore = "no exec_command on Windows")]
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn code_mode_can_return_exec_command_output() -> Result<()> {
skip_on_bazel!(Ok(()));
skip_if_no_network!(Ok(()));
let server = responses::start_mock_server().await;
@@ -203,6 +212,7 @@ add_content(JSON.stringify(await exec_command({ cmd: "printf code_mode_exec_mark
#[cfg_attr(windows, ignore = "no exec_command on Windows")]
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn code_mode_can_truncate_final_result_with_configured_budget() -> Result<()> {
skip_on_bazel!(Ok(()));
skip_if_no_network!(Ok(()));
let server = responses::start_mock_server().await;
@@ -248,6 +258,7 @@ Total\ output\ lines:\ 1\n
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn code_mode_returns_accumulated_output_when_script_fails() -> Result<()> {
skip_on_bazel!(Ok(()));
skip_if_no_network!(Ok(()));
let server = responses::start_mock_server().await;
@@ -291,6 +302,7 @@ Error:\ boom\n
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn code_mode_can_output_serialized_text_via_openai_code_mode_module() -> Result<()> {
skip_on_bazel!(Ok(()));
skip_if_no_network!(Ok(()));
let server = responses::start_mock_server().await;
@@ -320,6 +332,7 @@ output_text({ json: true });
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn code_mode_surfaces_output_text_stringify_errors() -> Result<()> {
skip_on_bazel!(Ok(()));
skip_if_no_network!(Ok(()));
let server = responses::start_mock_server().await;
@@ -363,6 +376,7 @@ output_text(circular);
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn code_mode_can_output_images_via_openai_code_mode_module() -> Result<()> {
skip_on_bazel!(Ok(()));
skip_if_no_network!(Ok(()));
let server = responses::start_mock_server().await;
@@ -415,6 +429,7 @@ output_image("data:image/png;base64,AAA");
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn code_mode_can_apply_patch_via_nested_tool() -> Result<()> {
skip_on_bazel!(Ok(()));
skip_if_no_network!(Ok(()));
let server = responses::start_mock_server().await;
@@ -456,6 +471,7 @@ async fn code_mode_can_apply_patch_via_nested_tool() -> Result<()> {
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn code_mode_can_print_structured_mcp_tool_result_fields() -> Result<()> {
skip_on_bazel!(Ok(()));
skip_if_no_network!(Ok(()));
let server = responses::start_mock_server().await;
@@ -496,6 +512,7 @@ contentLength=0"
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn code_mode_can_access_namespaced_mcp_tool_from_flat_tools_namespace() -> Result<()> {
skip_on_bazel!(Ok(()));
skip_if_no_network!(Ok(()));
let server = responses::start_mock_server().await;
@@ -534,6 +551,7 @@ isError=false"
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn code_mode_can_print_content_only_mcp_tool_result_fields() -> Result<()> {
skip_on_bazel!(Ok(()));
skip_if_no_network!(Ok(()));
let server = responses::start_mock_server().await;
@@ -579,6 +597,7 @@ isError=false"
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn code_mode_can_print_error_mcp_tool_result_fields() -> Result<()> {
skip_on_bazel!(Ok(()));
skip_if_no_network!(Ok(()));
let server = responses::start_mock_server().await;
@@ -619,6 +638,7 @@ structuredContent=null"
}
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn code_mode_can_store_and_load_values_across_turns() -> Result<()> {
skip_on_bazel!(Ok(()));
skip_if_no_network!(Ok(()));
let server = responses::start_mock_server().await;