From 1165e651fe39e8e6ba298e9d413248ab05f6bc03 Mon Sep 17 00:00:00 2001 From: starr-openai Date: Tue, 12 May 2026 17:59:38 -0700 Subject: [PATCH] codex: address PR review feedback (#22200) Co-authored-by: Codex --- codex-rs/core/src/unified_exec/process_manager.rs | 4 ---- codex-rs/core/src/unified_exec/process_manager_tests.rs | 4 ++-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/codex-rs/core/src/unified_exec/process_manager.rs b/codex-rs/core/src/unified_exec/process_manager.rs index 26ec21215a..e77b1924d6 100644 --- a/codex-rs/core/src/unified_exec/process_manager.rs +++ b/codex-rs/core/src/unified_exec/process_manager.rs @@ -398,10 +398,6 @@ impl UnifiedExecProcessManager { } Err(err) => { let failure = match &err { - UnifiedExecError::MissingCommandLine => ToolEventFailure::Rejected { - message: err.to_string(), - applied_patch_delta: None, - }, UnifiedExecError::Rejected { message } => ToolEventFailure::Rejected { message: message.clone(), applied_patch_delta: None, diff --git a/codex-rs/core/src/unified_exec/process_manager_tests.rs b/codex-rs/core/src/unified_exec/process_manager_tests.rs index e3474464d1..63fb14f964 100644 --- a/codex-rs/core/src/unified_exec/process_manager_tests.rs +++ b/codex-rs/core/src/unified_exec/process_manager_tests.rs @@ -232,7 +232,7 @@ async fn failed_initial_end_for_unstored_process_uses_fallback_output() { } #[tokio::test] -async fn startup_rejection_emits_begin_then_declined_end() { +async fn startup_failure_emits_begin_then_failed_end() { let (session, turn, rx_event) = crate::session::tests::make_session_and_context_with_rx().await; let context = UnifiedExecContext::new( Arc::clone(&session), @@ -295,7 +295,7 @@ async fn startup_rejection_emits_begin_then_declined_end() { assert_eq!(end_event.call_id, "call-unified-empty"); assert_eq!( end_event.status, - codex_protocol::protocol::ExecCommandStatus::Declined + codex_protocol::protocol::ExecCommandStatus::Failed ); }