clone/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-05-02 18:37:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: stabilize app-server windows ci diagnostics

Browse Source
This commit is contained in:
mom-oai
2026-04-10 09:26:50 -07:00
parent 88165e179a
commit 12f7e21a9f
6 changed files with 191 additions and 81 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
codex-rs/app-server/tests/suite/v2/thread_start.rs
View File

@@ -221,10 +221,25 @@ async fn thread_start_does_not_track_thread_initialized_analytics_without_featur
.await??;
let _ = to_response::<ThreadStartResponse>(resp)?;
let payload = wait_for_analytics_payload(&server, Duration::from_millis(250)).await;
tokio::time::sleep(Duration::from_millis(250)).await;
let analytics_payloads = server
.received_requests()
.await
.unwrap_or_default()
.iter()
.filter(|request| request.url.path() == "/codex/analytics-events/events")
.filter_map(|request| serde_json::from_slice::<Value>(&request.body).ok())
.collect::<Vec<_>>();
let has_thread_initialized_event = analytics_payloads.iter().any(|request| {
request["events"].as_array().is_some_and(|events| {
events
.iter()
.any(|event| event["event_type"] == "codex_thread_initialized")
})
});
assert!(
payload.is_err(),
"thread analytics should be gated off when general_analytics is disabled"
!has_thread_initialized_event,
"thread analytics should be gated off when general_analytics is disabled, got {analytics_payloads:#?}"
);
Ok(())
}
@@ -826,11 +841,7 @@ fn create_config_toml_with_chatgpt_base_url(
chatgpt_base_url: &str,
general_analytics_enabled: bool,
) -> std::io::Result<()> {
let general_analytics_toml = if general_analytics_enabled {
"\ngeneral_analytics = true".to_string()
} else {
String::new()
};
let general_analytics_toml = format!("general_analytics = {general_analytics_enabled}");
let config_toml = codex_home.join("config.toml");
std::fs::write(
config_toml,