Add turn-scoped environment selections (#18416)

## Summary
- add experimental turn/start.environments params for per-turn
environment id + cwd selections
- pass selections through core protocol ops and resolve them with
EnvironmentManager before TurnContext creation
- treat omitted selections as default behavior, empty selections as no
environment, and non-empty selections as first environment/cwd as the
turn primary

## Testing
- ran `just fmt`
- ran `just write-app-server-schema`
- not run: unit tests for this stacked PR

---------

Co-authored-by: Codex <noreply@openai.com>
This commit is contained in:
starr-openai
2026-04-21 17:48:33 -07:00
committed by GitHub
parent 6368f506b7
commit 1d4cc494c9
85 changed files with 974 additions and 35 deletions

View File

@@ -246,6 +246,7 @@ async fn remote_compact_replaces_history_for_followups() -> Result<()> {
codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "hello remote compact".into(),
text_elements: Vec::new(),
@@ -261,6 +262,7 @@ async fn remote_compact_replaces_history_for_followups() -> Result<()> {
codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "after compact".into(),
text_elements: Vec::new(),
@@ -392,6 +394,7 @@ async fn remote_compact_runs_automatically() -> Result<()> {
codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "hello remote compact".into(),
text_elements: Vec::new(),
@@ -467,6 +470,7 @@ async fn remote_compact_trims_function_call_history_to_fit_context_window() -> R
codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: first_user_message.into(),
text_elements: Vec::new(),
@@ -479,6 +483,7 @@ async fn remote_compact_trims_function_call_history_to_fit_context_window() -> R
codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: second_user_message.into(),
text_elements: Vec::new(),
@@ -595,6 +600,7 @@ async fn auto_remote_compact_trims_function_call_history_to_fit_context_window()
codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: first_user_message.into(),
text_elements: Vec::new(),
@@ -607,6 +613,7 @@ async fn auto_remote_compact_trims_function_call_history_to_fit_context_window()
codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: second_user_message.into(),
text_elements: Vec::new(),
@@ -625,6 +632,7 @@ async fn auto_remote_compact_trims_function_call_history_to_fit_context_window()
codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "turn that triggers auto compact".into(),
text_elements: Vec::new(),
@@ -723,6 +731,7 @@ async fn auto_remote_compact_failure_stops_agent_loop() -> Result<()> {
codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "turn that exceeds token threshold".into(),
text_elements: Vec::new(),
@@ -735,6 +744,7 @@ async fn auto_remote_compact_failure_stops_agent_loop() -> Result<()> {
codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "turn that triggers auto compact".into(),
text_elements: Vec::new(),
@@ -827,6 +837,7 @@ async fn remote_compact_trim_estimate_uses_session_base_instructions() -> Result
baseline_codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: first_user_message.into(),
text_elements: Vec::new(),
@@ -842,6 +853,7 @@ async fn remote_compact_trim_estimate_uses_session_base_instructions() -> Result
baseline_codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: second_user_message.into(),
text_elements: Vec::new(),
@@ -931,6 +943,7 @@ async fn remote_compact_trim_estimate_uses_session_base_instructions() -> Result
override_codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: first_user_message.into(),
text_elements: Vec::new(),
@@ -946,6 +959,7 @@ async fn remote_compact_trim_estimate_uses_session_base_instructions() -> Result
override_codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: second_user_message.into(),
text_elements: Vec::new(),
@@ -1015,6 +1029,7 @@ async fn remote_manual_compact_emits_context_compaction_items() -> Result<()> {
codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "manual remote compact".into(),
text_elements: Vec::new(),
@@ -1094,6 +1109,7 @@ async fn remote_manual_compact_failure_emits_task_error_event() -> Result<()> {
codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "manual remote compact".into(),
text_elements: Vec::new(),
@@ -1177,6 +1193,7 @@ async fn remote_compact_persists_replacement_history_in_rollout() -> Result<()>
codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "needs compaction".into(),
text_elements: Vec::new(),
@@ -1319,6 +1336,7 @@ async fn remote_compact_and_resume_refresh_stale_developer_instructions() -> Res
initial
.codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "start remote compact flow".into(),
text_elements: Vec::new(),
@@ -1335,6 +1353,7 @@ async fn remote_compact_and_resume_refresh_stale_developer_instructions() -> Res
initial
.codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "after compact in same session".into(),
text_elements: Vec::new(),
@@ -1358,6 +1377,7 @@ async fn remote_compact_and_resume_refresh_stale_developer_instructions() -> Res
resumed
.codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "after resume".into(),
text_elements: Vec::new(),
@@ -1453,6 +1473,7 @@ async fn remote_compact_refreshes_stale_developer_instructions_without_resume()
test.codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "start remote compact flow".into(),
text_elements: Vec::new(),
@@ -1468,6 +1489,7 @@ async fn remote_compact_refreshes_stale_developer_instructions_without_resume()
test.codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "after compact in same session".into(),
text_elements: Vec::new(),
@@ -1538,6 +1560,7 @@ async fn snapshot_request_shape_remote_pre_turn_compaction_restates_realtime_sta
test.codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "USER_ONE".to_string(),
text_elements: Vec::new(),
@@ -1550,6 +1573,7 @@ async fn snapshot_request_shape_remote_pre_turn_compaction_restates_realtime_sta
test.codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "USER_TWO".to_string(),
text_elements: Vec::new(),
@@ -1615,6 +1639,7 @@ async fn remote_request_uses_custom_experimental_realtime_start_instructions() -
test.codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "USER_ONE".to_string(),
text_elements: Vec::new(),
@@ -1674,6 +1699,7 @@ async fn snapshot_request_shape_remote_pre_turn_compaction_restates_realtime_end
test.codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "USER_ONE".to_string(),
text_elements: Vec::new(),
@@ -1688,6 +1714,7 @@ async fn snapshot_request_shape_remote_pre_turn_compaction_restates_realtime_end
test.codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "USER_TWO".to_string(),
text_elements: Vec::new(),
@@ -1761,6 +1788,7 @@ async fn snapshot_request_shape_remote_manual_compact_restates_realtime_start()
test.codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "USER_ONE".to_string(),
text_elements: Vec::new(),
@@ -1776,6 +1804,7 @@ async fn snapshot_request_shape_remote_manual_compact_restates_realtime_start()
test.codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "USER_TWO".to_string(),
text_elements: Vec::new(),
@@ -1857,6 +1886,7 @@ async fn snapshot_request_shape_remote_mid_turn_compaction_does_not_restate_real
test.codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "SETUP_USER".to_string(),
text_elements: Vec::new(),
@@ -1871,6 +1901,7 @@ async fn snapshot_request_shape_remote_mid_turn_compaction_does_not_restate_real
test.codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "USER_TWO".to_string(),
text_elements: Vec::new(),
@@ -1960,6 +1991,7 @@ async fn snapshot_request_shape_remote_compact_resume_restates_realtime_end() ->
initial
.codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "USER_ONE".to_string(),
text_elements: Vec::new(),
@@ -1988,6 +2020,7 @@ async fn snapshot_request_shape_remote_compact_resume_restates_realtime_end() ->
resumed
.codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "USER_TWO".to_string(),
text_elements: Vec::new(),
@@ -2082,6 +2115,7 @@ async fn snapshot_request_shape_remote_pre_turn_compaction_including_incoming_us
}
codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: user.to_string(),
text_elements: Vec::new(),
@@ -2167,6 +2201,7 @@ async fn snapshot_request_shape_remote_pre_turn_compaction_strips_incoming_model
codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "BEFORE_SWITCH_USER".to_string(),
text_elements: Vec::new(),
@@ -2194,6 +2229,7 @@ async fn snapshot_request_shape_remote_pre_turn_compaction_strips_incoming_model
.await?;
codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "AFTER_SWITCH_USER".to_string(),
text_elements: Vec::new(),
@@ -2311,6 +2347,7 @@ async fn snapshot_request_shape_remote_pre_turn_compaction_context_window_exceed
codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "USER_ONE".to_string(),
text_elements: Vec::new(),
@@ -2323,6 +2360,7 @@ async fn snapshot_request_shape_remote_pre_turn_compaction_context_window_exceed
codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "USER_TWO".to_string(),
text_elements: Vec::new(),
@@ -2406,6 +2444,7 @@ async fn snapshot_request_shape_remote_mid_turn_continuation_compaction() -> Res
codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "USER_ONE".to_string(),
text_elements: Vec::new(),
@@ -2482,6 +2521,7 @@ async fn snapshot_request_shape_remote_mid_turn_compaction_summary_only_reinject
codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "USER_ONE".to_string(),
text_elements: Vec::new(),
@@ -2566,6 +2606,7 @@ async fn snapshot_request_shape_remote_mid_turn_compaction_multi_summary_reinjec
codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "USER_ONE".to_string(),
text_elements: Vec::new(),
@@ -2581,6 +2622,7 @@ async fn snapshot_request_shape_remote_mid_turn_compaction_multi_summary_reinjec
codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "USER_TWO".to_string(),
text_elements: Vec::new(),
@@ -2661,6 +2703,7 @@ async fn snapshot_request_shape_remote_manual_compact_without_previous_user_mess
codex
.submit(Op::UserInput {
environments: None,
items: vec![UserInput::Text {
text: "USER_ONE".to_string(),
text_elements: Vec::new(),