From 2f79c7ad9d6eec1b79245e9c3fea05f2913f0cdd Mon Sep 17 00:00:00 2001 From: Channing Conger Date: Sun, 10 May 2026 17:54:54 -0700 Subject: [PATCH] fix(v8): align windows gnullvm with 147 --- .github/scripts/test_rusty_v8_bazel.py | 4 +++ third_party/v8/BUILD.bazel | 36 +++++++++++++++++--------- 2 files changed, 28 insertions(+), 12 deletions(-) diff --git a/.github/scripts/test_rusty_v8_bazel.py b/.github/scripts/test_rusty_v8_bazel.py index a5654ba837..19690dbece 100644 --- a/.github/scripts/test_rusty_v8_bazel.py +++ b/.github/scripts/test_rusty_v8_bazel.py @@ -22,10 +22,12 @@ class RustyV8BazelTest(unittest.TestCase): for selector in [ "aarch64_apple_darwin_bazel", + "aarch64_pc_windows_gnullvm", "aarch64_pc_windows_msvc", "aarch64_unknown_linux_gnu_bazel", "aarch64_unknown_linux_musl_release_base", "x86_64_apple_darwin_bazel", + "x86_64_pc_windows_gnullvm", "x86_64_pc_windows_msvc", "x86_64_unknown_linux_gnu_bazel", "x86_64_unknown_linux_musl_release", @@ -37,10 +39,12 @@ class RustyV8BazelTest(unittest.TestCase): for selector in [ "aarch64_apple_darwin", + "aarch64_pc_windows_gnullvm", "aarch64_pc_windows_msvc", "aarch64_unknown_linux_gnu", "aarch64_unknown_linux_musl", "x86_64_apple_darwin", + "x86_64_pc_windows_gnullvm", "x86_64_pc_windows_msvc", "x86_64_unknown_linux_gnu", "x86_64_unknown_linux_musl", diff --git a/third_party/v8/BUILD.bazel b/third_party/v8/BUILD.bazel index 4d7e174ed2..df8e06328c 100644 --- a/third_party/v8/BUILD.bazel +++ b/third_party/v8/BUILD.bazel @@ -40,16 +40,16 @@ alias( ) alias( - name = "v8_146_4_0_aarch64_pc_windows_gnullvm", + name = "v8_147_4_0_aarch64_pc_windows_gnullvm", # `rusty_v8` only ships prebuilt Windows archives for MSVC. Build the # GNU-flavored archive in-tree so windows-gnullvm consumers can link # against a matching ABI instead of trying to reuse the MSVC release. - actual = ":v8_146_4_0_aarch64_pc_windows_gnullvm_bazel", + actual = ":v8_147_4_0_aarch64_pc_windows_gnullvm_bazel", ) alias( - name = "v8_146_4_0_x86_64_pc_windows_gnullvm", - actual = ":v8_146_4_0_x86_64_pc_windows_gnullvm_bazel", + name = "v8_147_4_0_x86_64_pc_windows_gnullvm", + actual = ":v8_147_4_0_x86_64_pc_windows_gnullvm_bazel", ) filegroup( @@ -73,29 +73,29 @@ filegroup( ) alias( - name = "src_binding_release_x86_64_pc_windows_gnullvm", + name = "src_binding_release_x86_64_pc_windows_gnullvm_147_4_0_release", # `rusty_v8` does not publish a Windows GNU binding file. The generated # binding only describes this V8 release's C++ API surface, so reuse the # Linux release binding while the windows-gnullvm archive build is still # experimental. - actual = ":src_binding_release_x86_64_unknown_linux_gnu", + actual = ":src_binding_release_x86_64_unknown_linux_gnu_147_4_0_release", ) alias( - name = "src_binding_release_aarch64_pc_windows_gnullvm", - actual = ":src_binding_release_aarch64_unknown_linux_gnu", + name = "src_binding_release_aarch64_pc_windows_gnullvm_147_4_0_release", + actual = ":src_binding_release_aarch64_unknown_linux_gnu_147_4_0_release", ) alias( name = "rusty_v8_archive_for_target", actual = select({ "@rules_rs//rs/experimental/platforms/config:aarch64-apple-darwin": ":v8_147_4_0_aarch64_apple_darwin_bazel", - "@rules_rs//rs/experimental/platforms/config:aarch64-pc-windows-gnullvm": ":v8_146_4_0_aarch64_pc_windows_gnullvm", + "@rules_rs//rs/experimental/platforms/config:aarch64-pc-windows-gnullvm": ":v8_147_4_0_aarch64_pc_windows_gnullvm", "@rules_rs//rs/experimental/platforms/config:aarch64-pc-windows-msvc": ":v8_147_4_0_aarch64_pc_windows_msvc", "@rules_rs//rs/experimental/platforms/config:aarch64-unknown-linux-gnu": ":v8_147_4_0_aarch64_unknown_linux_gnu_bazel", ":platform_aarch64_unknown_linux_musl": ":v8_147_4_0_aarch64_unknown_linux_musl_release_base", "@rules_rs//rs/experimental/platforms/config:x86_64-apple-darwin": ":v8_147_4_0_x86_64_apple_darwin_bazel", - "@rules_rs//rs/experimental/platforms/config:x86_64-pc-windows-gnullvm": ":v8_146_4_0_x86_64_pc_windows_gnullvm", + "@rules_rs//rs/experimental/platforms/config:x86_64-pc-windows-gnullvm": ":v8_147_4_0_x86_64_pc_windows_gnullvm", "@rules_rs//rs/experimental/platforms/config:x86_64-pc-windows-msvc": ":v8_147_4_0_x86_64_pc_windows_msvc", "@rules_rs//rs/experimental/platforms/config:x86_64-unknown-linux-gnu": ":v8_147_4_0_x86_64_unknown_linux_gnu_bazel", ":platform_x86_64_unknown_linux_musl": ":v8_147_4_0_x86_64_unknown_linux_musl_release", @@ -107,12 +107,12 @@ alias( name = "rusty_v8_binding_for_target", actual = select({ "@rules_rs//rs/experimental/platforms/config:aarch64-apple-darwin": ":src_binding_release_aarch64_apple_darwin_147_4_0_release", - "@rules_rs//rs/experimental/platforms/config:aarch64-pc-windows-gnullvm": ":src_binding_release_aarch64_pc_windows_gnullvm", + "@rules_rs//rs/experimental/platforms/config:aarch64-pc-windows-gnullvm": ":src_binding_release_aarch64_pc_windows_gnullvm_147_4_0_release", "@rules_rs//rs/experimental/platforms/config:aarch64-pc-windows-msvc": ":src_binding_release_aarch64_pc_windows_msvc_147_4_0_release", "@rules_rs//rs/experimental/platforms/config:aarch64-unknown-linux-gnu": ":src_binding_release_aarch64_unknown_linux_gnu_147_4_0_release", ":platform_aarch64_unknown_linux_musl": ":src_binding_release_aarch64_unknown_linux_musl_147_4_0_release", "@rules_rs//rs/experimental/platforms/config:x86_64-apple-darwin": ":src_binding_release_x86_64_apple_darwin_147_4_0_release", - "@rules_rs//rs/experimental/platforms/config:x86_64-pc-windows-gnullvm": ":src_binding_release_x86_64_pc_windows_gnullvm", + "@rules_rs//rs/experimental/platforms/config:x86_64-pc-windows-gnullvm": ":src_binding_release_x86_64_pc_windows_gnullvm_147_4_0_release", "@rules_rs//rs/experimental/platforms/config:x86_64-pc-windows-msvc": ":src_binding_release_x86_64_pc_windows_msvc_147_4_0_release", "@rules_rs//rs/experimental/platforms/config:x86_64-unknown-linux-gnu": ":src_binding_release_x86_64_unknown_linux_gnu_147_4_0_release", ":platform_x86_64_unknown_linux_musl": ":src_binding_release_x86_64_unknown_linux_musl_147_4_0_release", @@ -342,6 +342,12 @@ cc_static_library( features = V8_STATIC_LIBRARY_FEATURES, ) +cc_static_library( + name = "v8_147_4_0_aarch64_pc_windows_gnullvm_bazel", + deps = [":v8_147_4_0_binding"], + features = V8_STATIC_LIBRARY_FEATURES, +) + cc_static_library( name = "v8_147_4_0_aarch64_unknown_linux_musl_release_base", deps = [ @@ -393,6 +399,12 @@ cc_static_library( features = V8_STATIC_LIBRARY_FEATURES, ) +cc_static_library( + name = "v8_147_4_0_x86_64_pc_windows_gnullvm_bazel", + deps = [":v8_147_4_0_binding"], + features = V8_STATIC_LIBRARY_FEATURES, +) + cc_static_library( name = "v8_147_4_0_x86_64_unknown_linux_musl_release", deps = [