clone/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-04-24 22:54:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: release session ID when not used (#7592)

Browse Source
This commit is contained in:
jif-oai
2025-12-04 17:42:16 +00:00
committed by GitHub
parent 1b2509f05a
commit 36edb412b1
2 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
codex-rs/core/src/tools/handlers/unified_exec.rs
View File

@@ -146,6 +146,7 @@ impl ToolHandler for UnifiedExecHandler {
codex_protocol::protocol::AskForApproval::OnRequest
)
{
manager.release_process_id(&process_id).await;
return Err(FunctionCallError::RespondToModel(format!(
"approval policy is {policy:?}; reject command — you cannot ask for escalated permissions if the approval policy is {policy:?}",
policy = context.turn.approval_policy
@@ -169,6 +170,7 @@ impl ToolHandler for UnifiedExecHandler {
)
.await?
{
manager.release_process_id(&process_id).await;
return Ok(output);
}

16
codex-rs/core/src/unified_exec/session_manager.rs
View File

@@ -111,6 +111,11 @@ impl UnifiedExecSessionManager {
}
}
pub(crate) async fn release_process_id(&self, process_id: &str) {
let mut store = self.session_store.lock().await;
store.remove(process_id);
}
pub(crate) async fn exec_command(
&self,
request: ExecCommandRequest,
@@ -129,7 +134,15 @@ impl UnifiedExecSessionManager {
request.justification,
context,
)
.await?;
.await;
let session = match session {
Ok(session) => session,
Err(err) => {
self.release_process_id(&request.process_id).await;
return Err(err);
}
};
let max_tokens = resolve_max_tokens(request.max_output_tokens);
let yield_time_ms = clamp_yield_time(request.yield_time_ms);
@@ -157,6 +170,7 @@ impl UnifiedExecSessionManager {
let chunk_id = generate_chunk_id();
let process_id = request.process_id.clone();
if has_exited {
self.release_process_id(&request.process_id).await;
let exit = exit_code.unwrap_or(-1);
Self::emit_exec_end_from_context(
context,