mirror of
https://github.com/openai/codex.git
synced 2026-04-26 23:55:25 +00:00
[codex] reduce module visibility (#16978)
## Summary - reduce public module visibility across Rust crates, preferring private or crate-private modules with explicit crate-root public exports - update external call sites and tests to use the intended public crate APIs instead of reaching through module trees - add the module visibility guideline to AGENTS.md ## Validation - `cargo check --workspace --all-targets --message-format=short` passed before the final fix/format pass - `just fix` completed successfully - `just fmt` completed successfully - `git diff --check` passed
This commit is contained in:
@@ -22,20 +22,20 @@ macro_rules! assert_contains {
|
||||
}
|
||||
|
||||
struct TestScenario {
|
||||
term: codex_tui::custom_terminal::Terminal<VT100Backend>,
|
||||
term: codex_tui::Terminal<VT100Backend>,
|
||||
}
|
||||
|
||||
impl TestScenario {
|
||||
fn new(width: u16, height: u16, viewport: Rect) -> Self {
|
||||
let backend = VT100Backend::new(width, height);
|
||||
let mut term = codex_tui::custom_terminal::Terminal::with_options(backend)
|
||||
.expect("failed to construct terminal");
|
||||
let mut term =
|
||||
codex_tui::Terminal::with_options(backend).expect("failed to construct terminal");
|
||||
term.set_viewport_area(viewport);
|
||||
Self { term }
|
||||
}
|
||||
|
||||
fn run_insert(&mut self, lines: Vec<Line<'static>>) {
|
||||
codex_tui::insert_history::insert_history_lines(&mut self.term, lines)
|
||||
codex_tui::insert_history_lines(&mut self.term, lines)
|
||||
.expect("Failed to insert history lines in test");
|
||||
}
|
||||
}
|
||||
|
||||
@@ -5,7 +5,7 @@ use ratatui::text::Line;
|
||||
#[test]
|
||||
fn live_001_commit_on_overflow() {
|
||||
let backend = VT100Backend::new(/*width*/ 20, /*height*/ 6);
|
||||
let mut term = match codex_tui::custom_terminal::Terminal::with_options(backend) {
|
||||
let mut term = match codex_tui::Terminal::with_options(backend) {
|
||||
Ok(t) => t,
|
||||
Err(e) => panic!("failed to construct terminal: {e}"),
|
||||
};
|
||||
@@ -15,7 +15,7 @@ fn live_001_commit_on_overflow() {
|
||||
term.set_viewport_area(area);
|
||||
|
||||
// Build 5 explicit rows at width 20.
|
||||
let mut rb = codex_tui::live_wrap::RowBuilder::new(/*target_width*/ 20);
|
||||
let mut rb = codex_tui::RowBuilder::new(/*target_width*/ 20);
|
||||
rb.push_fragment("one\n");
|
||||
rb.push_fragment("two\n");
|
||||
rb.push_fragment("three\n");
|
||||
@@ -26,7 +26,7 @@ fn live_001_commit_on_overflow() {
|
||||
let commit_rows = rb.drain_commit_ready(/*max_keep*/ 3);
|
||||
let lines: Vec<Line<'static>> = commit_rows.into_iter().map(|r| r.text.into()).collect();
|
||||
|
||||
codex_tui::insert_history::insert_history_lines(&mut term, lines)
|
||||
codex_tui::insert_history_lines(&mut term, lines)
|
||||
.expect("Failed to insert history lines in test");
|
||||
|
||||
let screen = term.backend().vt100().screen();
|
||||
|
||||
Reference in New Issue
Block a user