clone/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-05-04 03:16:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: clarify the value of SkillMetadata.path (#12729)

Browse Source 
Rename `SkillMetadata.path` to `SkillMetadata.path_to_skills_md` for
clarity.

Would ideally change the type to `AbsolutePathBuf`, but that can be done
later.
This commit is contained in:
Michael Bolin
2026-02-24 17:15:54 -08:00
committed by GitHub
parent 63c2ac96cd
commit 448fb6ac22
14 changed files with 80 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
codex-rs/tui/src/chatwidget/skills.rs
View File

@@ -78,7 +78,7 @@ impl ChatWidget {
let display_name = skill_display_name(&core_skill).to_string();
let description = skill_description(&core_skill).to_string();
let name = core_skill.name.clone();
let path = core_skill.path;
let path = core_skill.path_to_skills_md;
SkillsToggleItem {
name: display_name,
skill_name: name,
@@ -191,7 +191,7 @@ fn protocol_skill_to_core(skill: &ProtocolSkillMetadata) -> SkillMetadata {
}),
policy: None,
permissions: None,
path: skill.path.clone(),
path_to_skills_md: skill.path.clone(),
scope: skill.scope,
}
}
@@ -229,23 +229,23 @@ pub(crate) fn find_skill_mentions_with_tool_mentions(
let mut matches: Vec<SkillMetadata> = Vec::new();
for skill in skills {
if seen_paths.contains(&skill.path) {
if seen_paths.contains(&skill.path_to_skills_md) {
continue;
}
let path_str = skill.path.to_string_lossy();
let path_str = skill.path_to_skills_md.to_string_lossy();
if mention_skill_paths.contains(path_str.as_ref()) {
seen_paths.insert(skill.path.clone());
seen_paths.insert(skill.path_to_skills_md.clone());
seen_names.insert(skill.name.clone());
matches.push(skill.clone());
}
}
for skill in skills {
if seen_paths.contains(&skill.path) {
if seen_paths.contains(&skill.path_to_skills_md) {
continue;
}
if mentions.names.contains(&skill.name) && seen_names.insert(skill.name.clone()) {
seen_paths.insert(skill.path.clone());
seen_paths.insert(skill.path_to_skills_md.clone());
matches.push(skill.clone());
}
}

4
codex-rs/tui/src/chatwidget/tests.rs
View File

@@ -931,7 +931,7 @@ async fn submission_prefers_selected_duplicate_skill_path() {
dependencies: None,
policy: None,
permissions: None,
path: repo_skill_path,
path_to_skills_md: repo_skill_path,
scope: SkillScope::Repo,
},
SkillMetadata {
@@ -942,7 +942,7 @@ async fn submission_prefers_selected_duplicate_skill_path() {
dependencies: None,
policy: None,
permissions: None,
path: user_skill_path.clone(),
path_to_skills_md: user_skill_path.clone(),
scope: SkillScope::User,
},
]));