clone/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-02-01 22:47:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixing main and make plan mode reasoning effort medium (#9980)

Browse Source 
It's overthinking so much on high and going over the context window.
This commit is contained in:
Ahmed Ibrahim
2026-01-26 22:30:24 -08:00
committed by GitHub
parent cabb2085cc
commit 509ff1c643
2 changed files with 32 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
codex-rs/core/src/models_manager/collaboration_mode_presets.rs
View File

@@ -28,7 +28,7 @@ fn plan_preset() -> CollaborationModeMask {
name: "Plan".to_string(),
mode: Some(ModeKind::Plan),
model: None,
reasoning_effort: Some(Some(ReasoningEffort::High)),
reasoning_effort: Some(Some(ReasoningEffort::Medium)),
developer_instructions: Some(Some(COLLABORATION_MODE_PLAN.to_string())),
}
}

55
codex-rs/tui/src/bottom_pane/request_user_input/layout.rs
View File

@@ -62,12 +62,14 @@ impl RequestUserInputOverlay {
notes_area,
) = self.build_layout_areas(
area,
progress_height,
question_height,
answer_title_height,
options_height,
notes_title_height,
notes_height,
LayoutHeights {
progress_height,
question_height,
answer_title_height,
options_height,
notes_title_height,
notes_height,
},
);
LayoutSections {
@@ -276,12 +278,7 @@ impl RequestUserInputOverlay {
fn build_layout_areas(
&self,
area: Rect,
progress_height: u16,
question_height: u16,
answer_title_height: u16,
options_height: u16,
notes_title_height: u16,
notes_height: u16,
heights: LayoutHeights,
) -> (
Rect, // progress_area
Rect, // header_area
@@ -296,10 +293,10 @@ impl RequestUserInputOverlay {
x: area.x,
y: cursor_y,
width: area.width,
height: progress_height,
height: heights.progress_height,
};
cursor_y = cursor_y.saturating_add(progress_height);
let header_height = area.height.saturating_sub(progress_height).min(1);
cursor_y = cursor_y.saturating_add(heights.progress_height);
let header_height = area.height.saturating_sub(heights.progress_height).min(1);
let header_area = Rect {
x: area.x,
y: cursor_y,
@@ -311,37 +308,37 @@ impl RequestUserInputOverlay {
x: area.x,
y: cursor_y,
width: area.width,
height: question_height,
height: heights.question_height,
};
cursor_y = cursor_y.saturating_add(question_height);
cursor_y = cursor_y.saturating_add(heights.question_height);
let answer_title_area = Rect {
x: area.x,
y: cursor_y,
width: area.width,
height: answer_title_height,
height: heights.answer_title_height,
};
cursor_y = cursor_y.saturating_add(answer_title_height);
cursor_y = cursor_y.saturating_add(heights.answer_title_height);
let options_area = Rect {
x: area.x,
y: cursor_y,
width: area.width,
height: options_height,
height: heights.options_height,
};
cursor_y = cursor_y.saturating_add(options_height);
cursor_y = cursor_y.saturating_add(heights.options_height);
let notes_title_area = Rect {
x: area.x,
y: cursor_y,
width: area.width,
height: notes_title_height,
height: heights.notes_title_height,
};
cursor_y = cursor_y.saturating_add(notes_title_height);
cursor_y = cursor_y.saturating_add(heights.notes_title_height);
let notes_area = Rect {
x: area.x,
y: cursor_y,
width: area.width,
height: notes_height,
height: heights.notes_height,
};
(
@@ -355,3 +352,13 @@ impl RequestUserInputOverlay {
)
}
}
#[derive(Clone, Copy, Debug)]
struct LayoutHeights {
progress_height: u16,
question_height: u16,
answer_title_height: u16,
options_height: u16,
notes_title_height: u16,
notes_height: u16,
}