From 5b41df26135c83237d3abf3eca3e8bce4c9807a0 Mon Sep 17 00:00:00 2001 From: Eric Traut Date: Sat, 16 May 2026 17:57:42 -0700 Subject: [PATCH] Simplify turn context update cleanup --- codex-rs/core/src/codex_thread.rs | 5 ++--- codex-rs/docs/protocol_v1.md | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/codex-rs/core/src/codex_thread.rs b/codex-rs/core/src/codex_thread.rs index b9d9dba06a..d54f134b0e 100644 --- a/codex-rs/core/src/codex_thread.rs +++ b/codex-rs/core/src/codex_thread.rs @@ -271,10 +271,9 @@ impl CodexThread { pub async fn update_turn_context_overrides( &self, overrides: CodexThreadTurnContextOverrides, - ) -> ConstraintResult { + ) -> ConstraintResult<()> { let updates = self.turn_context_settings_update(overrides).await; - self.codex.session.update_settings(updates).await?; - Ok(self.config_snapshot().await) + self.codex.session.update_settings(updates).await } async fn turn_context_settings_update( diff --git a/codex-rs/docs/protocol_v1.md b/codex-rs/docs/protocol_v1.md index 44b767dfa1..464e8187b4 100644 --- a/codex-rs/docs/protocol_v1.md +++ b/codex-rs/docs/protocol_v1.md @@ -70,7 +70,7 @@ For complete documentation of the `Op` and `EventMsg` variants, refer to [protoc - `Op::Interrupt` – Interrupts a running turn - `Op::ExecApproval` – Approve or deny code execution - `Op::UserInputAnswer` – Provide answers for a `request_user_input` tool call - - `Op::UserTurn` and `Op::UserInputWithTurnContext` accept an optional `personality` override that updates the model’s communication style + - `Op::UserInput` accepts an optional `personality` turn-context override that updates the model’s communication style Valid `personality` values are `friendly`, `pragmatic`, and `none`. When `none` is selected, the personality placeholder is replaced with an empty string.