From 64a9aa24f430e075c66e67ecea703badfc3fa76e Mon Sep 17 00:00:00 2001 From: Channing Conger Date: Fri, 22 May 2026 21:39:45 -0700 Subject: [PATCH] Drop read and overwrite trait methods --- codex-rs/code-mode/src/service.rs | 32 +------------------------------ 1 file changed, 1 insertion(+), 31 deletions(-) diff --git a/codex-rs/code-mode/src/service.rs b/codex-rs/code-mode/src/service.rs index d726c6a9c2..c58d3ee36e 100644 --- a/codex-rs/code-mode/src/service.rs +++ b/codex-rs/code-mode/src/service.rs @@ -138,15 +138,6 @@ pub trait CodeModeSession: Send + Sync { fn terminate<'a>(&'a self, cell_id: String) -> CodeModeSessionResultFuture<'a, WaitOutcome>; - fn stored_values<'a>( - &'a self, - ) -> Pin> + Send + 'a>>; - - fn replace_stored_values<'a>( - &'a self, - values: HashMap, - ) -> Pin + Send + 'a>>; - fn shutdown<'a>(&'a self) -> CodeModeSessionResultFuture<'a, ()>; } @@ -213,14 +204,6 @@ impl CodeModeService { } } - async fn stored_values(&self) -> HashMap { - self.inner.stored_values.lock().await.clone() - } - - pub async fn replace_stored_values(&self, values: HashMap) { - *self.inner.stored_values.lock().await = values; - } - fn allocate_cell_id(&self) -> CellId { CellId( self.inner @@ -283,7 +266,7 @@ impl CodeModeService { let cell_id_text = cell_id.to_string(); let (event_tx, event_rx) = mpsc::unbounded_channel(); let (control_tx, control_rx) = mpsc::unbounded_channel(); - let stored_values = self.stored_values().await; + let stored_values = self.inner.stored_values.lock().await.clone(); let cancellation_token = CancellationToken::new(); let (runtime_tx, runtime_control_tx, runtime_terminate_handle) = { let mut sessions = self.inner.sessions.lock().await; @@ -469,19 +452,6 @@ impl CodeModeSession for CodeModeService { Box::pin(CodeModeService::terminate(self, cell_id)) } - fn stored_values<'a>( - &'a self, - ) -> Pin> + Send + 'a>> { - Box::pin(CodeModeService::stored_values(self)) - } - - fn replace_stored_values<'a>( - &'a self, - values: HashMap, - ) -> Pin + Send + 'a>> { - Box::pin(CodeModeService::replace_stored_values(self, values)) - } - fn shutdown<'a>(&'a self) -> CodeModeSessionResultFuture<'a, ()> { Box::pin(CodeModeService::shutdown(self)) }