From 79154e6952eee25aab591a58b414c6909e0bf57d Mon Sep 17 00:00:00 2001 From: Zanie Blue Date: Thu, 7 May 2026 16:14:18 -0700 Subject: [PATCH] Use `--locked` in cargo build and lint invocations (#21602) This ensures CI fails if the committed lockfile is outdated --- .github/workflows/rust-ci-full.yml | 2 +- .github/workflows/rust-release-argument-comment-lint.yml | 2 +- .github/workflows/rust-release-windows.yml | 2 +- .github/workflows/rust-release.yml | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/rust-ci-full.yml b/.github/workflows/rust-ci-full.yml index d0edf6751b..4ebf748b90 100644 --- a/.github/workflows/rust-ci-full.yml +++ b/.github/workflows/rust-ci-full.yml @@ -445,7 +445,7 @@ jobs: cargo chef cook --recipe-path "$RECIPE" --target ${{ matrix.target }} --release - name: cargo clippy - run: cargo clippy --target ${{ matrix.target }} --tests --profile ${{ matrix.profile }} --timings -- -D warnings + run: cargo clippy --target ${{ matrix.target }} --tests --profile ${{ matrix.profile }} --timings --locked -- -D warnings - name: Upload Cargo timings (clippy) if: always() diff --git a/.github/workflows/rust-release-argument-comment-lint.yml b/.github/workflows/rust-release-argument-comment-lint.yml index 277dcd122a..dda53794d6 100644 --- a/.github/workflows/rust-release-argument-comment-lint.yml +++ b/.github/workflows/rust-release-argument-comment-lint.yml @@ -75,7 +75,7 @@ jobs: - name: Cargo build working-directory: tools/argument-comment-lint shell: bash - run: cargo build --release --target ${{ matrix.target }} + run: cargo build --release --target ${{ matrix.target }} --locked - name: Stage artifact shell: bash diff --git a/.github/workflows/rust-release-windows.yml b/.github/workflows/rust-release-windows.yml index 24d6d67e03..370e171978 100644 --- a/.github/workflows/rust-release-windows.yml +++ b/.github/workflows/rust-release-windows.yml @@ -109,7 +109,7 @@ jobs: for binary in ${{ matrix.binaries }}; do build_args+=(--bin "$binary") done - cargo build --target ${{ matrix.target }} --release --timings "${build_args[@]}" + cargo build --target ${{ matrix.target }} --release --timings --locked "${build_args[@]}" - name: Upload Cargo timings uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0 diff --git a/.github/workflows/rust-release.yml b/.github/workflows/rust-release.yml index 43d70e5a3f..7d388acef4 100644 --- a/.github/workflows/rust-release.yml +++ b/.github/workflows/rust-release.yml @@ -261,7 +261,7 @@ jobs: run: | set -euo pipefail target="${{ matrix.target }}" - cargo build --target "$target" --release --timings --bin bwrap + cargo build --target "$target" --release --timings --locked --bin bwrap bwrap_path="target/${target}/release/bwrap" if [[ ! -f "$bwrap_path" ]]; then @@ -281,7 +281,7 @@ jobs: build_args+=(--bin "$binary") done echo "CARGO_PROFILE_RELEASE_LTO: ${CARGO_PROFILE_RELEASE_LTO}" - cargo build --target ${{ matrix.target }} --release --timings "${build_args[@]}" + cargo build --target ${{ matrix.target }} --release --timings --locked "${build_args[@]}" - name: Upload Cargo timings uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0