From 7edbdc555c46ecf7c74de58d75ca4763107ed133 Mon Sep 17 00:00:00 2001 From: Ahmed Ibrahim Date: Sat, 9 May 2026 13:49:35 +0300 Subject: [PATCH] Add approval callback TODO Co-authored-by: Codex --- sdk/python/scripts/update_sdk_artifacts.py | 2 ++ sdk/python/src/openai_codex/api.py | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/sdk/python/scripts/update_sdk_artifacts.py b/sdk/python/scripts/update_sdk_artifacts.py index bfbeee4168..2e6aa782e3 100755 --- a/sdk/python/scripts/update_sdk_artifacts.py +++ b/sdk/python/scripts/update_sdk_artifacts.py @@ -932,6 +932,8 @@ def _model_arg_lines( for field in fields: value = field.py_name if field.py_name == "approval_policy": + # TODO: Add a public approval callback API that lets callers return + # typed approval results, then honor caller-supplied policies. value = "_approval_policy_never(approval_policy)" lines.append(f"{indent}{field.wire_name}={value},") return lines diff --git a/sdk/python/src/openai_codex/api.py b/sdk/python/src/openai_codex/api.py index db948c2700..d7a761388e 100644 --- a/sdk/python/src/openai_codex/api.py +++ b/sdk/python/src/openai_codex/api.py @@ -70,8 +70,8 @@ def _split_user_agent(user_agent: str) -> tuple[str | None, str | None]: def _approval_policy_never(_approval_policy: AskForApproval | None) -> AskForApproval: - # TODO: Handle approval requests in the SDK before honoring caller-supplied - # policies. + # TODO: Add a public approval callback API that lets callers return typed + # approval results, then honor caller-supplied policies. return AskForApproval.never