clone/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-04-24 14:45:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

clean

Browse Source
This commit is contained in:
Ahmed Ibrahim
2026-01-13 14:26:34 -08:00
parent 5bd85b38b8
commit 8d7362df44
6 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
codex-rs/core/src/codex.rs
View File

@@ -255,7 +255,7 @@ impl Codex {
let config = Arc::new(config);
let model = models_manager
.get_model(
.get_default_model(
&config.model,
&config,
crate::models_manager::manager::RefreshStrategy::default(),

3
codex-rs/core/src/models_manager/manager.rs
View File

@@ -105,7 +105,7 @@ impl ModelsManager {
///
/// If `model` is provided, returns it directly. Otherwise selects the default based on
/// auth mode and available models (prefers `codex-auto-balanced` for ChatGPT auth).
pub async fn get_model(
pub async fn get_default_model(
&self,
model: &Option<String>,
config: &Config,
@@ -136,6 +136,7 @@ impl ModelsManager {
OPENAI_DEFAULT_API_MODEL.to_string()
}
// todo(aibrahim): look if we can tighten it to pub(crate)
/// Look up model metadata, applying remote overrides and config adjustments.
pub async fn get_model_info(&self, model: &str, config: &Config) -> ModelInfo {
let remote = self

4
codex-rs/core/tests/suite/remote_models.rs
View File

@@ -478,7 +478,7 @@ async fn remote_models_request_times_out_after_5s() -> Result<()> {
let start = Instant::now();
let model = timeout(
Duration::from_secs(7),
manager.get_model(&None, &config, RefreshStrategy::OnlineIfUncached),
manager.get_default_model(&None, &config, RefreshStrategy::OnlineIfUncached),
)
.await;
let elapsed = start.elapsed();
@@ -543,7 +543,7 @@ async fn remote_models_hide_picker_only_models() -> Result<()> {
);
let selected = manager
.get_model(&None, &config, RefreshStrategy::OnlineIfUncached)
.get_default_model(&None, &config, RefreshStrategy::OnlineIfUncached)
.await;
assert_eq!(selected, "gpt-5.2-codex");

2
codex-rs/exec/src/lib.rs
View File

@@ -311,7 +311,7 @@ pub async fn run_main(cli: Cli, codex_linux_sandbox_exe: Option<PathBuf>) -> any
);
let default_model = thread_manager
.get_models_manager()
.get_model(&config.model, &config, RefreshStrategy::default())
.get_default_model(&config.model, &config, RefreshStrategy::default())
.await;
// Handle resume subcommand by resolving a rollout path and using explicit resume API.

2
codex-rs/tui/src/app.rs
View File

@@ -372,7 +372,7 @@ impl App {
));
let mut model = thread_manager
.get_models_manager()
.get_model(&config.model, &config, RefreshStrategy::default())
.get_default_model(&config.model, &config, RefreshStrategy::default())
.await;
let exit_info = handle_model_migration_prompt_if_needed(
tui,

2
codex-rs/tui2/src/app.rs
View File

@@ -435,7 +435,7 @@ impl App {
));
let mut model = thread_manager
.get_models_manager()
.get_model(&config.model, &config, RefreshStrategy::default())
.get_default_model(&config.model, &config, RefreshStrategy::default())
.await;
let exit_info = handle_model_migration_prompt_if_needed(
tui,