From a1ef35b7b066f9c9a145a74eaa944dff891f0ff7 Mon Sep 17 00:00:00 2001 From: Ahmed Ibrahim Date: Fri, 15 May 2026 20:07:49 -0700 Subject: [PATCH] Format Python SDK dangerous bypass updates --- sdk/python/scripts/update_sdk_artifacts.py | 4 +--- sdk/python/src/openai_codex/_approval_mode.py | 4 +--- sdk/python/src/openai_codex/api.py | 24 +++++-------------- sdk/python/tests/test_app_server_approvals.py | 8 ++----- 4 files changed, 10 insertions(+), 30 deletions(-) diff --git a/sdk/python/scripts/update_sdk_artifacts.py b/sdk/python/scripts/update_sdk_artifacts.py index 405595d025..67f10473a6 100755 --- a/sdk/python/scripts/update_sdk_artifacts.py +++ b/sdk/python/scripts/update_sdk_artifacts.py @@ -882,9 +882,7 @@ def _approval_mode_turn_sandbox_policy_lines(*, indent: str = " ") -> lis ] -def _model_arg_lines( - fields: list[PublicFieldSpec], *, indent: str = " " -) -> list[str]: +def _model_arg_lines(fields: list[PublicFieldSpec], *, indent: str = " ") -> list[str]: return [f"{indent}{field.wire_name}={field.py_name}," for field in fields] diff --git a/sdk/python/src/openai_codex/_approval_mode.py b/sdk/python/src/openai_codex/_approval_mode.py index 033dfe6f19..ea5eccd30f 100644 --- a/sdk/python/src/openai_codex/_approval_mode.py +++ b/sdk/python/src/openai_codex/_approval_mode.py @@ -15,9 +15,7 @@ class ApprovalMode(str, Enum): deny_all = "deny_all" auto_review = "auto_review" - dangerously_bypass_approvals_and_sandbox = ( - "dangerously_bypass_approvals_and_sandbox" - ) + dangerously_bypass_approvals_and_sandbox = "dangerously_bypass_approvals_and_sandbox" def _approval_mode_settings( diff --git a/sdk/python/src/openai_codex/api.py b/sdk/python/src/openai_codex/api.py index a3078eb039..eced0361ee 100644 --- a/sdk/python/src/openai_codex/api.py +++ b/sdk/python/src/openai_codex/api.py @@ -194,9 +194,7 @@ class Codex: sandbox: SandboxMode | None = None, service_tier: str | None = None, ) -> Thread: - approval_policy, approvals_reviewer = _approval_mode_override_settings( - approval_mode - ) + approval_policy, approvals_reviewer = _approval_mode_override_settings(approval_mode) sandbox = _thread_sandbox_for_approval_mode(approval_mode, sandbox) params = ThreadResumeParams( thread_id=thread_id, @@ -231,9 +229,7 @@ class Codex: service_tier: str | None = None, thread_source: ThreadSource | None = None, ) -> Thread: - approval_policy, approvals_reviewer = _approval_mode_override_settings( - approval_mode - ) + approval_policy, approvals_reviewer = _approval_mode_override_settings(approval_mode) sandbox = _thread_sandbox_for_approval_mode(approval_mode, sandbox) params = ThreadForkParams( thread_id=thread_id, @@ -405,9 +401,7 @@ class AsyncCodex: service_tier: str | None = None, ) -> AsyncThread: await self._ensure_initialized() - approval_policy, approvals_reviewer = _approval_mode_override_settings( - approval_mode - ) + approval_policy, approvals_reviewer = _approval_mode_override_settings(approval_mode) sandbox = _thread_sandbox_for_approval_mode(approval_mode, sandbox) params = ThreadResumeParams( thread_id=thread_id, @@ -443,9 +437,7 @@ class AsyncCodex: thread_source: ThreadSource | None = None, ) -> AsyncThread: await self._ensure_initialized() - approval_policy, approvals_reviewer = _approval_mode_override_settings( - approval_mode - ) + approval_policy, approvals_reviewer = _approval_mode_override_settings(approval_mode) sandbox = _thread_sandbox_for_approval_mode(approval_mode, sandbox) params = ThreadForkParams( thread_id=thread_id, @@ -534,9 +526,7 @@ class Thread: summary: ReasoningSummary | None = None, ) -> TurnHandle: wire_input = _to_wire_input(input) - approval_policy, approvals_reviewer = _approval_mode_override_settings( - approval_mode - ) + approval_policy, approvals_reviewer = _approval_mode_override_settings(approval_mode) sandbox_policy = _turn_sandbox_policy_for_approval_mode( approval_mode, sandbox_policy, @@ -624,9 +614,7 @@ class AsyncThread: ) -> AsyncTurnHandle: await self._codex._ensure_initialized() wire_input = _to_wire_input(input) - approval_policy, approvals_reviewer = _approval_mode_override_settings( - approval_mode - ) + approval_policy, approvals_reviewer = _approval_mode_override_settings(approval_mode) sandbox_policy = _turn_sandbox_policy_for_approval_mode( approval_mode, sandbox_policy, diff --git a/sdk/python/tests/test_app_server_approvals.py b/sdk/python/tests/test_app_server_approvals.py index 959adb2345..fb190611ba 100644 --- a/sdk/python/tests/test_app_server_approvals.py +++ b/sdk/python/tests/test_app_server_approvals.py @@ -255,18 +255,14 @@ def test_outside_workspace_write_rejected_for_deny_all_and_allowed_for_bypass( with AppServerHarness(tmp_path) as harness: rejected_args = json.dumps( { - "command": ( - f"printf %s rejected > {shlex.quote(str(rejected_path))}" - ), + "command": (f"printf %s rejected > {shlex.quote(str(rejected_path))}"), "login": False, "timeout_ms": 1_000, } ) dangerous_args = json.dumps( { - "command": ( - f"printf %s dangerous > {shlex.quote(str(allowed_path))}" - ), + "command": (f"printf %s dangerous > {shlex.quote(str(allowed_path))}"), "login": False, "timeout_ms": 1_000, }