remove order from thread/list

This commit is contained in:
Owen Lin
2025-11-02 12:15:46 -08:00
parent fbe3078c2f
commit afd59a99af
3 changed files with 4 additions and 9 deletions

View File

@@ -245,8 +245,6 @@ pub struct ThreadListParams {
pub cursor: Option<String>,
/// Optional page size; defaults to a reasonable server-side value.
pub limit: Option<i32>,
/// Optional sort order; defaults to descending.
pub order: Option<SortOrder>,
/// Optional provider filter; when set, only sessions recorded under these
/// providers are returned. When present but empty, includes all providers.
pub model_providers: Option<Vec<String>>,

View File

@@ -1114,7 +1114,6 @@ impl CodexMessageProcessor {
let ThreadListParams {
cursor,
limit,
order: _,
model_providers,
} = params;

View File

@@ -25,7 +25,6 @@ async fn thread_list_basic_empty() -> Result<()> {
.send_thread_list_request(ThreadListParams {
cursor: None,
limit: Some(10),
order: None,
model_providers: None,
})
.await?;
@@ -140,7 +139,6 @@ async fn thread_list_pagination_next_cursor_none_on_last_page() -> Result<()> {
.send_thread_list_request(ThreadListParams {
cursor: None,
limit: Some(2),
order: None,
model_providers: None,
})
.await?;
@@ -161,7 +159,6 @@ async fn thread_list_pagination_next_cursor_none_on_last_page() -> Result<()> {
.send_thread_list_request(ThreadListParams {
cursor: Some(cursor1),
limit: Some(2),
order: None,
model_providers: None,
})
.await?;
@@ -204,7 +201,8 @@ async fn thread_list_respects_provider_filter() -> Result<()> {
.join("02");
std::fs::create_dir_all(&dir)?;
let file_path = dir.join(format!("rollout-2025-01-02T11-00-00-{uuid}.jsonl"));
let lines = [json!({
let lines = [
json!({
"timestamp": "2025-01-02T11:00:00Z",
"type": "session_meta",
"payload": {
@@ -230,7 +228,8 @@ async fn thread_list_respects_provider_filter() -> Result<()> {
"type":"event_msg",
"payload": {"type":"user_message","message":"X","kind":"plain"}
})
.to_string()];
.to_string(),
];
std::fs::write(file_path, lines.join("\n") + "\n")?;
let mut mcp = McpProcess::new(codex_home.path()).await?;
@@ -241,7 +240,6 @@ async fn thread_list_respects_provider_filter() -> Result<()> {
.send_thread_list_request(ThreadListParams {
cursor: None,
limit: Some(10),
order: None,
model_providers: Some(vec!["other_provider".to_string()]),
})
.await?;