mirror of
https://github.com/openai/codex.git
synced 2026-04-28 08:34:54 +00:00
Apply argument comment lint across codex-rs (#14652)
## Why Once the repo-local lint exists, `codex-rs` needs to follow the checked-in convention and CI needs to keep it from drifting. This commit applies the fallback `/*param*/` style consistently across existing positional literal call sites without changing those APIs. The longer-term preference is still to avoid APIs that require comments by choosing clearer parameter types and call shapes. This PR is intentionally the mechanical follow-through for the places where the existing signatures stay in place. After rebasing onto newer `main`, the rollout also had to cover newly introduced `tui_app_server` call sites. That made it clear the first cut of the CI job was too expensive for the common path: it was spending almost as much time installing `cargo-dylint` and re-testing the lint crate as a representative test job spends running product tests. The CI update keeps the full workspace enforcement but trims that extra overhead from ordinary `codex-rs` PRs. ## What changed - keep a dedicated `argument_comment_lint` job in `rust-ci` - mechanically annotate remaining opaque positional literals across `codex-rs` with exact `/*param*/` comments, including the rebased `tui_app_server` call sites that now fall under the lint - keep the checked-in style aligned with the lint policy by using `/*param*/` and leaving string and char literals uncommented - cache `cargo-dylint`, `dylint-link`, and the relevant Cargo registry/git metadata in the lint job - split changed-path detection so the lint crate's own `cargo test` step runs only when `tools/argument-comment-lint/*` or `rust-ci.yml` changes - continue to run the repo wrapper over the `codex-rs` workspace, so product-code enforcement is unchanged Most of the code changes in this commit are intentionally mechanical comment rewrites or insertions driven by the lint itself. ## Verification - `./tools/argument-comment-lint/run.sh --workspace` - `cargo test -p codex-tui-app-server -p codex-tui` - parsed `.github/workflows/rust-ci.yml` locally with PyYAML --- * -> #14652 * #14651
This commit is contained in:
@@ -81,7 +81,7 @@ pub async fn start_streaming_sse_server(
|
||||
tokio::spawn(async move {
|
||||
let (request, body_prefix) = read_http_request(&mut stream).await;
|
||||
let Some((method, path)) = parse_request_line(&request) else {
|
||||
let _ = write_http_response(&mut stream, 400, "bad request", "text/plain").await;
|
||||
let _ = write_http_response(&mut stream, /*status*/ 400, "bad request", "text/plain").await;
|
||||
return;
|
||||
};
|
||||
|
||||
@@ -90,7 +90,7 @@ pub async fn start_streaming_sse_server(
|
||||
.await
|
||||
.is_err()
|
||||
{
|
||||
let _ = write_http_response(&mut stream, 400, "bad request", "text/plain").await;
|
||||
let _ = write_http_response(&mut stream, /*status*/ 400, "bad request", "text/plain").await;
|
||||
return;
|
||||
}
|
||||
let body = serde_json::json!({
|
||||
@@ -98,7 +98,7 @@ pub async fn start_streaming_sse_server(
|
||||
"object": "list"
|
||||
})
|
||||
.to_string();
|
||||
let _ = write_http_response(&mut stream, 200, &body, "application/json").await;
|
||||
let _ = write_http_response(&mut stream, /*status*/ 200, &body, "application/json").await;
|
||||
return;
|
||||
}
|
||||
|
||||
@@ -108,13 +108,13 @@ pub async fn start_streaming_sse_server(
|
||||
{
|
||||
Ok(body) => body,
|
||||
Err(_) => {
|
||||
let _ = write_http_response(&mut stream, 400, "bad request", "text/plain").await;
|
||||
let _ = write_http_response(&mut stream, /*status*/ 400, "bad request", "text/plain").await;
|
||||
return;
|
||||
}
|
||||
};
|
||||
requests.lock().await.push(body);
|
||||
let Some((chunks, completion)) = take_next_stream(&state).await else {
|
||||
let _ = write_http_response(&mut stream, 500, "no responses queued", "text/plain").await;
|
||||
let _ = write_http_response(&mut stream, /*status*/ 500, "no responses queued", "text/plain").await;
|
||||
return;
|
||||
};
|
||||
|
||||
@@ -138,7 +138,7 @@ pub async fn start_streaming_sse_server(
|
||||
return;
|
||||
}
|
||||
|
||||
let _ = write_http_response(&mut stream, 404, "not found", "text/plain").await;
|
||||
let _ = write_http_response(&mut stream, /*status*/ 404, "not found", "text/plain").await;
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user