Apply argument comment lint across codex-rs (#14652)

## Why

Once the repo-local lint exists, `codex-rs` needs to follow the
checked-in convention and CI needs to keep it from drifting. This commit
applies the fallback `/*param*/` style consistently across existing
positional literal call sites without changing those APIs.

The longer-term preference is still to avoid APIs that require comments
by choosing clearer parameter types and call shapes. This PR is
intentionally the mechanical follow-through for the places where the
existing signatures stay in place.

After rebasing onto newer `main`, the rollout also had to cover newly
introduced `tui_app_server` call sites. That made it clear the first cut
of the CI job was too expensive for the common path: it was spending
almost as much time installing `cargo-dylint` and re-testing the lint
crate as a representative test job spends running product tests. The CI
update keeps the full workspace enforcement but trims that extra
overhead from ordinary `codex-rs` PRs.

## What changed

- keep a dedicated `argument_comment_lint` job in `rust-ci`
- mechanically annotate remaining opaque positional literals across
`codex-rs` with exact `/*param*/` comments, including the rebased
`tui_app_server` call sites that now fall under the lint
- keep the checked-in style aligned with the lint policy by using
`/*param*/` and leaving string and char literals uncommented
- cache `cargo-dylint`, `dylint-link`, and the relevant Cargo
registry/git metadata in the lint job
- split changed-path detection so the lint crate's own `cargo test` step
runs only when `tools/argument-comment-lint/*` or `rust-ci.yml` changes
- continue to run the repo wrapper over the `codex-rs` workspace, so
product-code enforcement is unchanged

Most of the code changes in this commit are intentionally mechanical
comment rewrites or insertions driven by the lint itself.

## Verification

- `./tools/argument-comment-lint/run.sh --workspace`
- `cargo test -p codex-tui-app-server -p codex-tui`
- parsed `.github/workflows/rust-ci.yml` locally with PyYAML

---

* -> #14652
* #14651
This commit is contained in:
Michael Bolin
2026-03-16 16:48:15 -07:00
committed by GitHub
parent 6f05d8d735
commit b77fe8fefe
261 changed files with 2311 additions and 1377 deletions

View File

@@ -306,13 +306,13 @@ impl DiffSummary {
impl Renderable for FileChange {
fn render(&self, area: Rect, buf: &mut Buffer) {
let mut lines = vec![];
render_change(self, &mut lines, area.width as usize, None);
render_change(self, &mut lines, area.width as usize, /*lang*/ None);
Paragraph::new(lines).render(area, buf);
}
fn desired_height(&self, width: u16) -> u16 {
let mut lines = vec![];
render_change(self, &mut lines, width as usize, None);
render_change(self, &mut lines, width as usize, /*lang*/ None);
lines.len() as u16
}
}
@@ -332,7 +332,9 @@ impl From<DiffSummary> for Box<dyn Renderable> {
rows.push(Box::new(RtLine::from("")));
rows.push(Box::new(InsetRenderable::new(
Box::new(row.change) as Box<dyn Renderable>,
Insets::tlbr(0, 2, 0, 0),
Insets::tlbr(
/*top*/ 0, /*left*/ 2, /*bottom*/ 0, /*right*/ 0,
),
)));
}
@@ -502,7 +504,7 @@ fn render_change(
raw,
width,
line_number_width,
None,
/*syntax_spans*/ None,
style_context.theme,
style_context.color_level,
style_context.diff_backgrounds,
@@ -534,7 +536,7 @@ fn render_change(
raw,
width,
line_number_width,
None,
/*syntax_spans*/ None,
style_context.theme,
style_context.color_level,
style_context.diff_backgrounds,
@@ -649,7 +651,7 @@ fn render_change(
s,
width,
line_number_width,
None,
/*syntax_spans*/ None,
style_context.theme,
style_context.color_level,
style_context.diff_backgrounds,
@@ -682,7 +684,7 @@ fn render_change(
s,
width,
line_number_width,
None,
/*syntax_spans*/ None,
style_context.theme,
style_context.color_level,
style_context.diff_backgrounds,
@@ -715,7 +717,7 @@ fn render_change(
s,
width,
line_number_width,
None,
/*syntax_spans*/ None,
style_context.theme,
style_context.color_level,
style_context.diff_backgrounds,
@@ -796,7 +798,7 @@ pub(crate) fn push_wrapped_diff_line_with_style_context(
text,
width,
line_number_width,
None,
/*syntax_spans*/ None,
style_context.theme,
style_context.color_level,
style_context.diff_backgrounds,