clone/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-05-24 21:14:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Centralize hidden hook presentation policy

Browse Source
This commit is contained in:
Abhinav Vedmala
2026-05-13 14:57:31 +00:00
parent ca9f9839bd
commit bc4b0c27ff
1 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
codex-rs/tui/src/history_cell/hook_cell.rs
View File

@@ -695,6 +695,8 @@ pub(crate) fn hook_run_should_skip_render(run: &HookRunSummary) -> bool {
/// Chooses the transcript presentation for a hook run:
///
/// - Normal hooks render exactly as reported.
/// - Hooks that complete without entries stay quiet, preserving the pre-existing "quiet success"
/// behavior.
/// - Hidden hooks stay silent while running.
/// - Hidden hooks that complete with only model-only context stay out of the transcript.
/// - Hidden hooks that complete with context plus user-facing output keep only the user-facing
@@ -702,6 +704,10 @@ pub(crate) fn hook_run_should_skip_render(run: &HookRunSummary) -> bool {
/// - Hidden hooks that block, fail, or stop always render so the transcript still explains
/// consequential hook behavior.
fn hook_presentation(run: &HookRunSummary) -> HookPresentation {
if run.status == HookRunStatus::Completed && run.entries.is_empty() {
return HookPresentation::Skip;
}
if run.visibility_hint != HookVisibilityHint::Hidden {
return HookPresentation::Render {
entries: run.entries.clone(),
@@ -865,6 +871,15 @@ mod tests {
assert!(hook_run_should_skip_render(&run));
}
#[test]
fn default_hook_keeps_empty_completion_quiet() {
let mut run = hook_run_summary("hook-1");
run.status = HookRunStatus::Completed;
assert!(hook_run_should_skip_render(&run));
assert_eq!(hook_presentation(&run), HookPresentation::Skip);
}
#[test]
fn hidden_hook_still_surfaces_user_relevant_outcomes() {
let mut run = hook_run_summary("hook-1");