clone/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-04-24 14:45:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Bump rmcp to 0.15 (#11539)

Browse Source 
https://github.com/modelcontextprotocol/rust-sdk/pull/598 in 0.14 broke
some MCP oauth (like Linear) and
https://github.com/modelcontextprotocol/rust-sdk/pull/641 fixed it in
0.15
This commit is contained in:
Gabriel Peal
2026-02-11 22:04:17 -08:00
committed by GitHub
parent 2aa8a2e11f
commit bd3ce98190
13 changed files with 59 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
codex-rs/Cargo.lock generated
View File

@@ -7395,9 +7395,9 @@ dependencies = [
[[package]]
name = "rmcp"
version = "0.14.0"
version = "0.15.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "0a621b37a548ff6ab6292d57841eb25785a7f146d89391a19c9f199414bd13da"
checksum = "1bef41ebc9ebed2c1b1d90203e9d1756091e8a00bbc3107676151f39868ca0ee"
dependencies = [
"async-trait",
"axum",
@@ -7431,9 +7431,9 @@ dependencies = [
[[package]]
name = "rmcp-macros"
version = "0.14.0"
version = "0.15.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "6b79ed92303f9262db79575aa8c3652581668e9d136be6fd0b9ededa78954c95"
checksum = "0e88ad84b8b6237a934534a62b379a5be6388915663c0cc598ceb9b3292bbbfe"
dependencies = [
"darling 0.23.0",
"proc-macro2",

2
codex-rs/Cargo.toml
View File

@@ -214,7 +214,7 @@ ratatui-macros = "0.6.0"
regex = "1.12.3"
regex-lite = "0.1.8"
reqwest = "0.12"
rmcp = { version = "0.14.0", default-features = false }
rmcp = { version = "0.15.0", default-features = false }
runfiles = { git = "https://github.com/dzbarsky/rules_rust", rev = "b56cbaa8465e74127f1ea216f813cd377295ad81" }
rustls = { version = "0.23", default-features = false, features = [
"ring",

1
codex-rs/core/src/codex.rs
View File

@@ -5393,6 +5393,7 @@ mod tests {
input_schema: Arc::new(JsonObject::default()),
output_schema: None,
annotations: None,
execution: None,
icons: None,
meta: None,
},

21
codex-rs/core/src/mcp_connection_manager.rs
View File

@@ -43,7 +43,9 @@ use futures::future::BoxFuture;
use futures::future::FutureExt;
use futures::future::Shared;
use rmcp::model::ClientCapabilities;
use rmcp::model::CreateElicitationRequestParams;
use rmcp::model::ElicitationCapability;
use rmcp::model::FormElicitationCapability;
use rmcp::model::Implementation;
use rmcp::model::InitializeRequestParams;
use rmcp::model::ListResourceTemplatesResult;
@@ -223,7 +225,16 @@ impl ElicitationRequestManager {
ProtocolRequestId::Integer(value)
}
},
message: elicitation.message,
message: match elicitation {
CreateElicitationRequestParams::FormElicitationParams {
message,
..
}
| CreateElicitationRequestParams::UrlElicitationParams {
message,
..
} => message,
},
}),
})
.await;
@@ -985,12 +996,16 @@ async fn start_server_task(
meta: None,
capabilities: ClientCapabilities {
experimental: None,
extensions: None,
roots: None,
sampling: None,
// https://modelcontextprotocol.io/specification/2025-06-18/client/elicitation#capabilities
// indicates this should be an empty object.
elicitation: Some(ElicitationCapability {
schema_validation: None,
form: Some(FormElicitationCapability {
schema_validation: None,
}),
url: None,
}),
tasks: None,
},
@@ -998,6 +1013,7 @@ async fn start_server_task(
name: "codex-mcp-client".to_owned(),
version: env!("CARGO_PKG_VERSION").to_owned(),
title: Some("Codex".into()),
description: None,
icons: None,
website_url: None,
},
@@ -1247,6 +1263,7 @@ mod tests {
input_schema: Arc::new(JsonObject::default()),
output_schema: None,
annotations: None,
execution: None,
icons: None,
meta: None,
},

2
codex-rs/core/src/tools/spec.rs
View File

@@ -1624,6 +1624,7 @@ mod tests {
input_schema: std::sync::Arc::new(rmcp::model::object(input_schema)),
output_schema: None,
annotations: None,
execution: None,
icons: None,
meta: None,
}
@@ -1641,6 +1642,7 @@ mod tests {
input_schema: std::sync::Arc::new(schema),
output_schema: None,
annotations: None,
execution: None,
icons: None,
meta: None,
};

2
codex-rs/exec-server/src/posix/mcp_escalation_policy.rs
View File

@@ -69,7 +69,7 @@ impl McpEscalationPolicy {
.pause_for(async {
context
.peer
.create_elicitation(CreateElicitationRequestParams {
.create_elicitation(CreateElicitationRequestParams::FormElicitationParams {
meta: None,
message: format!(
"Allow agent to run `{command}` in `{}`?",

6
codex-rs/exec-server/tests/common/lib.rs
View File

@@ -166,7 +166,11 @@ impl ClientHandler for InteractiveClient {
.unwrap()
.push(request.clone());
let accept = self.elicitations_to_accept.contains(&request.message);
let message = match &request {
CreateElicitationRequestParams::FormElicitationParams { message, .. }
| CreateElicitationRequestParams::UrlElicitationParams { message, .. } => message,
};
let accept = self.elicitations_to_accept.contains(message);
async move {
if accept {
Ok(CreateElicitationResult {

9
codex-rs/exec-server/tests/suite/accept_elicitation.rs
View File

@@ -138,7 +138,14 @@ prefix_rule(
.lock()
.unwrap()
.iter()
.map(|r| r.message.clone())
.map(|r| match r {
rmcp::model::CreateElicitationRequestParams::FormElicitationParams {
message, ..
}
| rmcp::model::CreateElicitationRequestParams::UrlElicitationParams {
message, ..
} => message.clone(),
})
.collect::<Vec<_>>();
assert_eq!(vec![expected_elicitation_message], elicitation_messages);

1
codex-rs/exec-server/tests/suite/list_tools.rs
View File

@@ -67,6 +67,7 @@ async fn list_tools() -> Result<()> {
"type": "object",
}))),
output_schema: None,
execution: None,
annotations: None,
icons: None,
meta: None

2
codex-rs/mcp-server/src/codex_tool_config.rs
View File

@@ -127,6 +127,7 @@ pub(crate) fn create_tool_for_codex_tool_call_param() -> Tool {
.into(),
),
annotations: None,
execution: None,
icons: None,
meta: None,
}
@@ -248,6 +249,7 @@ pub(crate) fn create_tool_for_codex_tool_call_reply_param() -> Tool {
"Continue a Codex conversation by providing the thread id and prompt.".into(),
),
annotations: None,
execution: None,
icons: None,
meta: None,
}

1
codex-rs/mcp-server/src/message_processor.rs
View File

@@ -209,6 +209,7 @@ impl MessageProcessor {
name: "codex-mcp-server".to_string(),
title: Some("Codex".to_string()),
version: env!("CARGO_PKG_VERSION").to_string(),
description: None,
icons: None,
website_url: None,
};

8
codex-rs/mcp-server/tests/common/mcp_process.rs
View File

@@ -18,6 +18,7 @@ use rmcp::model::ClientCapabilities;
use rmcp::model::CustomNotification;
use rmcp::model::CustomRequest;
use rmcp::model::ElicitationCapability;
use rmcp::model::FormElicitationCapability;
use rmcp::model::Implementation;
use rmcp::model::InitializeRequestParams;
use rmcp::model::JsonRpcMessage;
@@ -116,9 +117,13 @@ impl McpProcess {
meta: None,
capabilities: ClientCapabilities {
elicitation: Some(ElicitationCapability {
schema_validation: None,
form: Some(FormElicitationCapability {
schema_validation: None,
}),
url: None,
}),
experimental: None,
extensions: None,
roots: None,
sampling: None,
tasks: None,
@@ -127,6 +132,7 @@ impl McpProcess {
name: "elicitation test".into(),
title: Some("Elicitation Test".into()),
version: "0.0.0".into(),
description: None,
icons: None,
website_url: None,
},

8
codex-rs/rmcp-client/tests/resources.rs
View File

@@ -10,6 +10,7 @@ use futures::FutureExt as _;
use rmcp::model::AnnotateAble;
use rmcp::model::ClientCapabilities;
use rmcp::model::ElicitationCapability;
use rmcp::model::FormElicitationCapability;
use rmcp::model::Implementation;
use rmcp::model::InitializeRequestParams;
use rmcp::model::ListResourceTemplatesResult;
@@ -29,10 +30,14 @@ fn init_params() -> InitializeRequestParams {
meta: None,
capabilities: ClientCapabilities {
experimental: None,
extensions: None,
roots: None,
sampling: None,
elicitation: Some(ElicitationCapability {
schema_validation: None,
form: Some(FormElicitationCapability {
schema_validation: None,
}),
url: None,
}),
tasks: None,
},
@@ -40,6 +45,7 @@ fn init_params() -> InitializeRequestParams {
name: "codex-test".into(),
version: "0.0.0-test".into(),
title: Some("Codex rmcp resource test".into()),
description: None,
icons: None,
website_url: None,
},