Move memory prompt injection to app-server extension (#22841)

## Why

Memory prompt injection should be owned by the extension path that
app-server composes at runtime, not by an inlined special case inside
`codex-core`. This keeps `codex-core` focused on session orchestration
while allowing the memories extension to own its app-server prompt
behavior.

## What Changed

- Registers `codex-memories-extension` in the app-server extension
registry.
- Moves the memory developer-instruction injection out of
`core/src/session/mod.rs` and into the memories extension prompt
contributor.
- Adds config-change handling so the extension keeps its per-thread
memory settings in sync after startup.
- Leaves memories read/retrieval tools unregistered for now so this PR
only changes prompt injection.
- Removes the stale `cargo-shear` ignore now that app-server depends on
the extension crate.

## Validation

Not run locally; validation is left to CI.
This commit is contained in:
jif-oai
2026-05-15 16:19:34 +02:00
committed by GitHub
parent 5d30764fe9
commit cccde930ce
6 changed files with 32 additions and 18 deletions

View File

@@ -1,6 +1,7 @@
use std::sync::Arc;
use codex_core::config::Config;
use codex_extension_api::ConfigContributor;
use codex_extension_api::ContextContributor;
use codex_extension_api::ExtensionData;
use codex_extension_api::ExtensionRegistryBuilder;
@@ -25,6 +26,15 @@ pub(crate) struct MemoriesExtensionConfig {
pub(crate) codex_home: AbsolutePathBuf,
}
impl MemoriesExtensionConfig {
fn from_config(config: &Config) -> Self {
Self {
enabled: config.features.enabled(Feature::MemoryTool) && config.memories.use_memories,
codex_home: config.codex_home.clone(),
}
}
}
impl ContextContributor for MemoriesExtension {
fn contribute<'a>(
&'a self,
@@ -50,11 +60,21 @@ impl ContextContributor for MemoriesExtension {
impl ThreadLifecycleContributor<Config> for MemoriesExtension {
fn on_thread_start(&self, input: ThreadStartInput<'_, Config>) {
input.thread_store.insert(MemoriesExtensionConfig {
enabled: input.config.features.enabled(Feature::MemoryTool)
&& input.config.memories.use_memories,
codex_home: input.config.codex_home.clone(),
});
input
.thread_store
.insert(MemoriesExtensionConfig::from_config(input.config));
}
}
impl ConfigContributor<Config> for MemoriesExtension {
fn on_config_changed(
&self,
_session_store: &ExtensionData,
thread_store: &ExtensionData,
_previous_config: &Config,
new_config: &Config,
) {
thread_store.insert(MemoriesExtensionConfig::from_config(new_config));
}
}
@@ -79,6 +99,8 @@ impl ToolContributor for MemoriesExtension {
pub fn install(registry: &mut ExtensionRegistryBuilder<Config>) {
let extension = Arc::new(MemoriesExtension);
registry.thread_lifecycle_contributor(extension.clone());
registry.prompt_contributor(extension.clone());
registry.tool_contributor(extension);
registry.config_contributor(extension.clone());
registry.prompt_contributor(extension);
// Keep the read/retrieval tools out of app-server until that rollout is intentional.
// registry.tool_contributor(extension);
}