mirror of
https://github.com/openai/codex.git
synced 2026-04-24 14:45:27 +00:00
tasks: normalize template & statuses for tasks 06 and 18
This commit is contained in:
@@ -4,8 +4,8 @@
|
||||
|
||||
## Status
|
||||
|
||||
**General Status**: Not started
|
||||
**Summary**: Not started; missing Implementation details (How it was implemented and How it works).
|
||||
**General Status**: Done
|
||||
**Summary**: External editor integration for prompt entry implemented.
|
||||
|
||||
## Goal
|
||||
Allow users to spawn an external editor (e.g. Neovim) to compose or edit the chat prompt. The prompt box should update with the editor's contents when closed.
|
||||
@@ -18,11 +18,17 @@ Allow users to spawn an external editor (e.g. Neovim) to compose or edit the cha
|
||||
## Implementation
|
||||
|
||||
**How it was implemented**
|
||||
*(Not implemented yet)*
|
||||
- Added `editor` option to `[tui]` section in `config.toml`, defaulting to `${VISUAL:-${EDITOR:-nvim}}`.
|
||||
- Exposed the `tui.editor` setting in the `codex-core` config model (`config_types.rs`) and wired it through to the TUI.
|
||||
- Added a new slash-command variant `EditPrompt` in `tui/src/slash_command.rs` to trigger external-editor mode.
|
||||
- Implemented `ChatComposer::open_external_editor()` in `tui/src/bottom_pane/chat_composer.rs`:
|
||||
- Creates a temporary file pre-populated with the current draft prompt.
|
||||
- Launches the configured editor (from `VISUAL`/`EDITOR` with `nvim` fallback) in a blocking subprocess.
|
||||
- Reads the edited contents back into the `TextArea` on editor exit.
|
||||
- Wired both `Ctrl+E` and the `/edit-prompt` slash command to invoke `open_external_editor()`.
|
||||
- Updated `config.md` to document the new `editor` setting under `[tui]`.
|
||||
|
||||
**How it works**
|
||||
*(Not implemented yet)*
|
||||
|
||||
## Notes
|
||||
- Leverage the existing file-opener machinery or spawn a subprocess directly.
|
||||
Modify `tui/src/bottom_pane/chat_composer.rs` and command handling in `tui/src/app.rs`.
|
||||
- Pressing `Ctrl+E`, or typing `/edit-prompt` and hitting Enter, spawns the user's preferred editor on a temporary file containing the current draft.
|
||||
- When the editor process exits, the plugin reads back the file and updates the chat composer with the edited text.
|
||||
- The default editor is determined by `VISUAL`, then `EDITOR`, falling back to `nvim` if neither is set.
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
++ # Task 18: Chat UI Textarea Overlay and Border Styling Fix
|
||||
++
|
||||
# Task 18: Chat UI Textarea Overlay and Border Styling Fix
|
||||
|
||||
---
|
||||
id: 18
|
||||
title: Chat UI Textarea Overlay and Border Styling Fix
|
||||
@@ -34,9 +34,3 @@ goal: |
|
||||
- This involves updating the rendering logic in the TUI modules (likely under `tui/src/` in `codex-rs`).
|
||||
- Ensure layout changes do not break existing tests or rendering in unusual terminal sizes.
|
||||
- Consider writing a simple snapshot test or manual demo script to validate border and overlay behavior.
|
||||
|
||||
---
|
||||
Run the frontmatter linter to ensure conformance:
|
||||
```bash
|
||||
python3 agentydragon/tools/check_task_frontmatter.py agentydragon/tasks/18-chat-ui-textarea-overlay-border-fix.md
|
||||
```
|
||||
|
||||
@@ -29,9 +29,3 @@ Explain runtime behavior and overall operation.
|
||||
## Notes
|
||||
|
||||
Any additional notes or references.
|
||||
|
||||
---
|
||||
Run the frontmatter linter to ensure conformance:
|
||||
```bash
|
||||
python3 ../tools/check_task_frontmatter.py
|
||||
```
|
||||
Reference in New Issue
Block a user