diff --git a/.codex/skills/code-review-breaking-changes/SKILL.md b/.codex/skills/code-review-breaking-changes/SKILL.md new file mode 100644 index 0000000000..f24360514b --- /dev/null +++ b/.codex/skills/code-review-breaking-changes/SKILL.md @@ -0,0 +1,13 @@ +--- +name: code-breaking-changes +description: Breacking +--- + +Search for breaking changes in external integration surfaces: +- app-server APIs +- CLI parameters +- configuration loading +- resuming sessions from existing rollouts + + +Do not stop after finding one issue, analyze all possible ways breaking changes can happen. \ No newline at end of file diff --git a/.codex/skills/code-review-change-size/SKILL.md b/.codex/skills/code-review-change-size/SKILL.md new file mode 100644 index 0000000000..4e8cd2bdb4 --- /dev/null +++ b/.codex/skills/code-review-change-size/SKILL.md @@ -0,0 +1,10 @@ +--- +name: code-review-change-size +description: Change size guidance (800 lines) +--- + +Unless the change is mechanical the total number of changed lines should not exceed 800 lines. +For complex logic changes the size should be under 500 lines. + +If the change is larger consider how the change can be done in stages. This must be well informed and reasearch ed suggestion. +Optimize for the ease of review, group mechanical changes separately from complex logic changes. diff --git a/.codex/skills/code-review-testing/SKILL.md b/.codex/skills/code-review-testing/SKILL.md new file mode 100644 index 0000000000..1bc5a46e14 --- /dev/null +++ b/.codex/skills/code-review-testing/SKILL.md @@ -0,0 +1,11 @@ +--- +name: code-review-testing +description: Test authoring guidance +--- + +For agent changes prefer integration tests over unit tests. Integration tests are under `core/suite` and use `test_codex` to set up a test instance of codex. + +Features change change the agent logic MUST add an integration test: +- Provide a list of major logic changes and user-facing behaviors that need to be tested. + +Check whether there are existing helpers to make tests more streamlined and readable. \ No newline at end of file diff --git a/.codex/skills/code-review/SKILL.md b/.codex/skills/code-review/SKILL.md new file mode 100644 index 0000000000..00b3145a7a --- /dev/null +++ b/.codex/skills/code-review/SKILL.md @@ -0,0 +1,14 @@ +--- +name: code-review +description: Run a final code review on a pull request +--- + +Use subagents to review code using all code-review-* skills in this repository. One subagent per skill. Pass full skill path to subagents. Use xhigh reasoning. + +You can return an unlimited number of findings. +Use raw Markdown to report findings. +Number findings for the ease of reference. + +If the GitHub user running the review is the owner of the pull request add a `code-reviewed` label. +Do not leave GitHub comments unless explicitly asked. +