clone/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-04-29 00:55:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

codex: address PR review feedback (#14988)

Browse Source
This commit is contained in:
Eric Traut
2026-03-18 12:40:22 -06:00
parent 8a3d8c5c16
commit e2b5dbcb65
30 changed files with 89 additions and 144 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
codex-rs/app-server-protocol/schema/json/ClientRequest.json
View File

@@ -2884,6 +2884,7 @@
"ThreadShellCommandParams": {
"properties": {
"command": {
"description": "Shell command string evaluated by the thread's configured shell. Unlike `command/exec`, this intentionally preserves shell syntax such as pipes, redirects, and quoting for legacy `!` parity.",
"type": "string"
},
"threadId": {

15
codex-rs/app-server-protocol/schema/json/ServerNotification.json
View File

@@ -725,9 +725,17 @@
"CommandExecutionOutputDeltaNotification": {
"properties": {
"delta": {
"description": "Raw bytes from the command stream (may not be valid UTF-8).",
"description": "Best-effort UTF-8 view of the output chunk for backwards compatibility.",
"type": "string"
},
"deltaBase64": {
"default": null,
"description": "Exact raw bytes for the chunk, base64-encoded.",
"type": [
"string",
"null"
]
},
"itemId": {
"type": "string"
},
@@ -2392,11 +2400,6 @@
"null"
]
},
"formattedOutput": {
"default": "",
"description": "The command's output after applying the model-facing formatter/truncation policy.",
"type": "string"
},
"id": {
"type": "string"
},

16
codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.schemas.json
View File

@@ -6113,9 +6113,17 @@
"$schema": "http://json-schema.org/draft-07/schema#",
"properties": {
"delta": {
"description": "Raw bytes from the command stream (may not be valid UTF-8).",
"description": "Best-effort UTF-8 view of the output chunk for backwards compatibility.",
"type": "string"
},
"deltaBase64": {
"default": null,
"description": "Exact raw bytes for the chunk, base64-encoded.",
"type": [
"string",
"null"
]
},
"itemId": {
"type": "string"
},
@@ -12082,11 +12090,6 @@
"null"
]
},
"formattedOutput": {
"default": "",
"description": "The command's output after applying the model-facing formatter/truncation policy.",
"type": "string"
},
"id": {
"type": "string"
},
@@ -13148,6 +13151,7 @@
"$schema": "http://json-schema.org/draft-07/schema#",
"properties": {
"command": {
"description": "Shell command string evaluated by the thread's configured shell. Unlike `command/exec`, this intentionally preserves shell syntax such as pipes, redirects, and quoting for legacy `!` parity.",
"type": "string"
},
"threadId": {

16
codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.v2.schemas.json
View File

@@ -2757,9 +2757,17 @@
"$schema": "http://json-schema.org/draft-07/schema#",
"properties": {
"delta": {
"description": "Raw bytes from the command stream (may not be valid UTF-8).",
"description": "Best-effort UTF-8 view of the output chunk for backwards compatibility.",
"type": "string"
},
"deltaBase64": {
"default": null,
"description": "Exact raw bytes for the chunk, base64-encoded.",
"type": [
"string",
"null"
]
},
"itemId": {
"type": "string"
},
@@ -9842,11 +9850,6 @@
"null"
]
},
"formattedOutput": {
"default": "",
"description": "The command's output after applying the model-facing formatter/truncation policy.",
"type": "string"
},
"id": {
"type": "string"
},
@@ -10908,6 +10911,7 @@
"$schema": "http://json-schema.org/draft-07/schema#",
"properties": {
"command": {
"description": "Shell command string evaluated by the thread's configured shell. Unlike `command/exec`, this intentionally preserves shell syntax such as pipes, redirects, and quoting for legacy `!` parity.",
"type": "string"
},
"threadId": {

10
codex-rs/app-server-protocol/schema/json/v2/CommandExecutionOutputDeltaNotification.json
View File

@@ -2,9 +2,17 @@
"$schema": "http://json-schema.org/draft-07/schema#",
"properties": {
"delta": {
"description": "Raw bytes from the command stream (may not be valid UTF-8).",
"description": "Best-effort UTF-8 view of the output chunk for backwards compatibility.",
"type": "string"
},
"deltaBase64": {
"default": null,
"description": "Exact raw bytes for the chunk, base64-encoded.",
"type": [
"string",
"null"
]
},
"itemId": {
"type": "string"
},

5
codex-rs/app-server-protocol/schema/json/v2/ItemCompletedNotification.json
View File

@@ -641,11 +641,6 @@
"null"
]
},
"formattedOutput": {
"default": "",
"description": "The command's output after applying the model-facing formatter/truncation policy.",
"type": "string"
},
"id": {
"type": "string"
},

5
codex-rs/app-server-protocol/schema/json/v2/ItemStartedNotification.json
View File

@@ -641,11 +641,6 @@
"null"
]
},
"formattedOutput": {
"default": "",
"description": "The command's output after applying the model-facing formatter/truncation policy.",
"type": "string"
},
"id": {
"type": "string"
},

5
codex-rs/app-server-protocol/schema/json/v2/ReviewStartResponse.json
View File

@@ -755,11 +755,6 @@
"null"
]
},
"formattedOutput": {
"default": "",
"description": "The command's output after applying the model-facing formatter/truncation policy.",
"type": "string"
},
"id": {
"type": "string"
},

5
codex-rs/app-server-protocol/schema/json/v2/ThreadForkResponse.json
View File

@@ -1248,11 +1248,6 @@
"null"
]
},
"formattedOutput": {
"default": "",
"description": "The command's output after applying the model-facing formatter/truncation policy.",
"type": "string"
},
"id": {
"type": "string"
},

5
codex-rs/app-server-protocol/schema/json/v2/ThreadListResponse.json
View File

@@ -1006,11 +1006,6 @@
"null"
]
},
"formattedOutput": {
"default": "",
"description": "The command's output after applying the model-facing formatter/truncation policy.",
"type": "string"
},
"id": {
"type": "string"
},

5
codex-rs/app-server-protocol/schema/json/v2/ThreadMetadataUpdateResponse.json
View File

@@ -1006,11 +1006,6 @@
"null"
]
},
"formattedOutput": {
"default": "",
"description": "The command's output after applying the model-facing formatter/truncation policy.",
"type": "string"
},
"id": {
"type": "string"
},

5
codex-rs/app-server-protocol/schema/json/v2/ThreadReadResponse.json
View File

@@ -1006,11 +1006,6 @@
"null"
]
},
"formattedOutput": {
"default": "",
"description": "The command's output after applying the model-facing formatter/truncation policy.",
"type": "string"
},
"id": {
"type": "string"
},

5
codex-rs/app-server-protocol/schema/json/v2/ThreadResumeResponse.json
View File

@@ -1248,11 +1248,6 @@
"null"
]
},
"formattedOutput": {
"default": "",
"description": "The command's output after applying the model-facing formatter/truncation policy.",
"type": "string"
},
"id": {
"type": "string"
},

5
codex-rs/app-server-protocol/schema/json/v2/ThreadRollbackResponse.json
View File

@@ -1006,11 +1006,6 @@
"null"
]
},
"formattedOutput": {
"default": "",
"description": "The command's output after applying the model-facing formatter/truncation policy.",
"type": "string"
},
"id": {
"type": "string"
},

1
codex-rs/app-server-protocol/schema/json/v2/ThreadShellCommandParams.json
View File

@@ -2,6 +2,7 @@
"$schema": "http://json-schema.org/draft-07/schema#",
"properties": {
"command": {
"description": "Shell command string evaluated by the thread's configured shell. Unlike `command/exec`, this intentionally preserves shell syntax such as pipes, redirects, and quoting for legacy `!` parity.",
"type": "string"
},
"threadId": {

5
codex-rs/app-server-protocol/schema/json/v2/ThreadStartResponse.json
View File

@@ -1248,11 +1248,6 @@
"null"
]
},
"formattedOutput": {
"default": "",
"description": "The command's output after applying the model-facing formatter/truncation policy.",
"type": "string"
},
"id": {
"type": "string"
},

5
codex-rs/app-server-protocol/schema/json/v2/ThreadStartedNotification.json
View File

@@ -1006,11 +1006,6 @@
"null"
]
},
"formattedOutput": {
"default": "",
"description": "The command's output after applying the model-facing formatter/truncation policy.",
"type": "string"
},
"id": {
"type": "string"
},

5
codex-rs/app-server-protocol/schema/json/v2/ThreadUnarchiveResponse.json
View File

@@ -1006,11 +1006,6 @@
"null"
]
},
"formattedOutput": {
"default": "",
"description": "The command's output after applying the model-facing formatter/truncation policy.",
"type": "string"
},
"id": {
"type": "string"
},

5
codex-rs/app-server-protocol/schema/json/v2/TurnCompletedNotification.json
View File

@@ -755,11 +755,6 @@
"null"
]
},
"formattedOutput": {
"default": "",
"description": "The command's output after applying the model-facing formatter/truncation policy.",
"type": "string"
},
"id": {
"type": "string"
},

5
codex-rs/app-server-protocol/schema/json/v2/TurnStartResponse.json
View File

@@ -755,11 +755,6 @@
"null"
]
},
"formattedOutput": {
"default": "",
"description": "The command's output after applying the model-facing formatter/truncation policy.",
"type": "string"
},
"id": {
"type": "string"
},

5
codex-rs/app-server-protocol/schema/json/v2/TurnStartedNotification.json
View File

@@ -755,11 +755,6 @@
"null"
]
},
"formattedOutput": {
"default": "",
"description": "The command's output after applying the model-facing formatter/truncation policy.",
"type": "string"
},
"id": {
"type": "string"
},