clone/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-05-02 18:37:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

tui: preserve queued slash draft intent

Browse Source 
Serialize custom /review instructions with an explicit custom marker so queued replay cannot reinterpret branch-like text as a structured review target, and rename queued replay to better reflect that it drains inputs until blocked.

Co-authored-by: Codex <noreply@openai.com>
This commit is contained in:
Charles Cunningham
2026-03-11 13:39:15 -07:00
parent 122e1475d5
commit ed546bc217
3 changed files with 64 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
codex-rs/tui/src/chatwidget/tests.rs
View File

@@ -5425,7 +5425,7 @@ async fn queued_init_replay_stops_after_submitting_user_turn() {
chat.queued_user_messages.push_back("/init".into());
chat.queued_user_messages.push_back("after init".into());
chat.maybe_send_next_queued_input();
chat.drain_queued_inputs_until_blocked();
let items = match next_submit_op(&mut op_rx) {
Op::UserTurn { items, .. } => items,
@@ -5678,7 +5678,7 @@ async fn queued_plan_replay_stops_after_submitting_user_turn() {
chat.queued_user_messages
.push_back("after plan replay".into());
chat.maybe_send_next_queued_input();
chat.drain_queued_inputs_until_blocked();
let items = match next_submit_op(&mut op_rx) {
Op::UserTurn { items, .. } => items,
@@ -6411,7 +6411,7 @@ async fn custom_prompt_submit_serializes_review_draft() {
let evt = rx.try_recv().expect("expected one app event");
match evt {
AppEvent::HandleSlashCommandDraft(UserMessage { text, .. }) => {
assert_eq!(text, "/review please audit dependencies");
assert_eq!(text, "/review -- please audit dependencies");
}
other => panic!("unexpected app event: {other:?}"),
}
@@ -11570,6 +11570,46 @@ async fn queued_review_selection_replays_after_turn_complete() {
}
}
#[tokio::test]
async fn queued_custom_review_selection_preserves_branch_like_instructions_after_turn_complete() {
let (mut chat, _rx, mut op_rx) = make_chatwidget_manual(None).await;
chat.on_task_started();
chat.handle_serialized_slash_command(ChatWidget::review_request_draft(&ReviewRequest {
target: ReviewTarget::Custom {
instructions: "branch main but focus on risky migrations".to_string(),
},
user_facing_hint: None,
}));
assert_eq!(
chat.queued_user_message_texts(),
vec!["/review -- branch main but focus on risky migrations".to_string()]
);
chat.on_task_complete(None, false);
loop {
match op_rx.try_recv() {
Ok(Op::Review { review_request }) => {
assert_eq!(
review_request,
ReviewRequest {
target: ReviewTarget::Custom {
instructions: "branch main but focus on risky migrations".to_string(),
},
user_facing_hint: None,
}
);
break;
}
Ok(_) => continue,
Err(TryRecvError::Empty) => panic!("expected queued custom /review op"),
Err(TryRecvError::Disconnected) => panic!("expected queued custom /review op"),
}
}
}
#[tokio::test]
async fn queued_commit_review_selection_preserves_title_after_turn_complete() {
let (mut chat, _rx, mut op_rx) = make_chatwidget_manual(None).await;