clone/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-04-28 08:34:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

add none personality option (#10688)

Browse Source 
- add none personality enum value and empty placeholder behavior\n- add
docs/schema updates and e2e coverage
This commit is contained in:
Ahmed Ibrahim
2026-02-04 15:40:33 -08:00
committed by GitHub
parent 7bcc552325
commit f9c38f531c
16 changed files with 157 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
codex-rs/protocol/src/openai_models.rs
View File

@@ -335,6 +335,7 @@ impl ModelInstructionsVariables {
pub fn get_personality_message(&self, personality: Option<Personality>) -> Option<String> {
if let Some(personality) = personality {
match personality {
Personality::None => Some(String::new()),
Personality::Friendly => self.personality_friendly.clone(),
Personality::Pragmatic => self.personality_pragmatic.clone(),
}
@@ -546,6 +547,10 @@ mod tests {
model.get_model_instructions(Some(Personality::Pragmatic)),
"Hello\n"
);
assert_eq!(
model.get_model_instructions(Some(Personality::None)),
"Hello\n"
);
assert_eq!(model.get_model_instructions(None), "Hello\n");
let model_no_personality = test_model(Some(ModelMessages {
@@ -564,6 +569,10 @@ mod tests {
model_no_personality.get_model_instructions(Some(Personality::Pragmatic)),
"Hello\n"
);
assert_eq!(
model_no_personality.get_model_instructions(Some(Personality::None)),
"Hello\n"
);
assert_eq!(model_no_personality.get_model_instructions(None), "Hello\n");
}
@@ -603,6 +612,10 @@ mod tests {
personality_variables.get_personality_message(Some(Personality::Pragmatic)),
Some("pragmatic".to_string())
);
assert_eq!(
personality_variables.get_personality_message(Some(Personality::None)),
Some(String::new())
);
assert_eq!(
personality_variables.get_personality_message(None),
Some("default".to_string())
@@ -621,6 +634,10 @@ mod tests {
personality_variables.get_personality_message(Some(Personality::Pragmatic)),
None
);
assert_eq!(
personality_variables.get_personality_message(Some(Personality::None)),
Some(String::new())
);
assert_eq!(
personality_variables.get_personality_message(None),
Some("default".to_string())
@@ -639,6 +656,10 @@ mod tests {
personality_variables.get_personality_message(Some(Personality::Pragmatic)),
Some("pragmatic".to_string())
);
assert_eq!(
personality_variables.get_personality_message(Some(Personality::None)),
Some(String::new())
);
assert_eq!(personality_variables.get_personality_message(None), None);
}
}