mirror of
https://github.com/openai/codex.git
synced 2026-05-25 21:45:22 +00:00
782191547c
## Summary Persisted subagent parent/child topology currently leaks through `StateRuntime`'s SQLite-specific thread-spawn helpers. This PR introduces a narrow `AgentGraphStore` boundary so follow-up work can route graph operations through a local or remote store without coupling orchestration code directly to the state DB graph API. ## Changes - Adds the new `codex-agent-graph-store` crate. - Defines a flat `AgentGraphStore` trait for the v1 graph surface: upsert edge, set edge status, list direct children, and list descendants. - Adds public graph types for `ThreadSpawnEdgeStatus`, `AgentGraphStoreError`, and `AgentGraphStoreResult`. - Implements `LocalAgentGraphStore` on top of an existing `codex_state::StateRuntime`, preserving today's SQLite-backed `thread_spawn_edges` behavior. - Registers the crate in Cargo/Bazel metadata. This PR only adds the local contract and implementation; call-site migration and the remote gRPC store are left to the follow-up PRs in the stack. ## Testing - `cargo test -p codex-agent-graph-store` The new unit tests cover local parity with the existing `StateRuntime` graph methods, `Open`/`Closed` filtering, status updates, and stable breadth-first descendant ordering.
56 lines
2.3 KiB
Rust
56 lines
2.3 KiB
Rust
use async_trait::async_trait;
|
|
use codex_protocol::ThreadId;
|
|
|
|
use crate::AgentGraphStoreResult;
|
|
use crate::ThreadSpawnEdgeStatus;
|
|
|
|
/// Storage-neutral boundary for persisted thread-spawn parent/child topology.
|
|
///
|
|
/// Implementations are expected to return stable ordering for list methods so callers can merge
|
|
/// persisted graph state with live in-memory state without introducing nondeterministic output.
|
|
#[async_trait]
|
|
pub trait AgentGraphStore: Send + Sync {
|
|
/// Insert or replace the directional parent/child edge for a spawned thread.
|
|
///
|
|
/// `child_thread_id` has at most one persisted parent. Re-inserting the same child should
|
|
/// update both the parent and status to match the supplied values.
|
|
async fn upsert_thread_spawn_edge(
|
|
&self,
|
|
parent_thread_id: ThreadId,
|
|
child_thread_id: ThreadId,
|
|
status: ThreadSpawnEdgeStatus,
|
|
) -> AgentGraphStoreResult<()>;
|
|
|
|
/// Update the persisted lifecycle status of a spawned thread's incoming edge.
|
|
///
|
|
/// Implementations should treat missing children as a successful no-op.
|
|
async fn set_thread_spawn_edge_status(
|
|
&self,
|
|
child_thread_id: ThreadId,
|
|
status: ThreadSpawnEdgeStatus,
|
|
) -> AgentGraphStoreResult<()>;
|
|
|
|
/// List direct spawned children of a parent thread.
|
|
///
|
|
/// When `status_filter` is `Some`, only child edges with that exact status are returned. When
|
|
/// it is `None`, all direct child edges are returned regardless of status, including statuses
|
|
/// that may be added by a future store implementation.
|
|
async fn list_thread_spawn_children(
|
|
&self,
|
|
parent_thread_id: ThreadId,
|
|
status_filter: Option<ThreadSpawnEdgeStatus>,
|
|
) -> AgentGraphStoreResult<Vec<ThreadId>>;
|
|
|
|
/// List spawned descendants breadth-first by depth, then by thread id.
|
|
///
|
|
/// `status_filter` is applied to every traversed edge, not just to the returned descendants.
|
|
/// For example, `Some(Open)` walks only open edges, so descendants under a closed edge are not
|
|
/// included even if their own incoming edge is open. `None` walks and returns every persisted
|
|
/// edge regardless of status.
|
|
async fn list_thread_spawn_descendants(
|
|
&self,
|
|
root_thread_id: ThreadId,
|
|
status_filter: Option<ThreadSpawnEdgeStatus>,
|
|
) -> AgentGraphStoreResult<Vec<ThreadId>>;
|
|
}
|