Matthew Zeng 1b900bee8a Unify skip-review handling for approval_mode = "approve" (#20750) ...

## Summary
- Treat `approval_mode = "approve"` as skip-review across all permission
modes.
- Remove the mode-specific split in the MCP auto-approval gate so
approved tools bypass review consistently.
- Expand regression coverage in the shared MCP helper and the core
tool-call flow.

## Testing
- `just fmt`
- `cargo test -p codex-mcp`
- `cargo test -p codex-core
approve_mode_skips_arc_and_guardian_in_every_permission_mode`
- `git diff --check`
- Full `cargo test -p codex-core` was also attempted, but the suite hit
an unrelated pre-existing stack overflow in an existing multi-agent test

2026-05-04 10:30:47 -07:00

..

agent

feat: add remote compaction v2 Responses client path (#20773)

2026-05-04 14:15:01 +02:00

apps

Split DeveloperInstructions into individual fragments. (#18813)

2026-04-21 10:22:36 -07:00

bin

…

config

feat: support template interpolation in multi-agent usage hints (#20973)

2026-05-04 11:50:01 +02:00

context

Surface multi-environment choices in environment context (#20646)

2026-05-01 22:11:06 +00:00

context_manager

feat: add remote compaction v2 Responses client path (#20773)

2026-05-04 14:15:01 +02:00

guardian

Gate multi-agent v2 tools independently of collab (#20246)

2026-04-30 10:23:31 +02:00

plugins

Move plugin out of core. (#20348)

2026-04-30 14:26:14 -07:00

sandboxing

permissions: derive legacy exec policies at boundaries (#19737)

2026-04-26 22:11:49 -07:00

session

feat: add remote compaction v2 Responses client path (#20773)

2026-05-04 14:15:01 +02:00

state

Move plugin out of core. (#20348)

2026-04-30 14:26:14 -07:00

tasks

feat: add remote compaction v2 Responses client path (#20773)

2026-05-04 14:15:01 +02:00

tools

[codex] Emit MCP tool calls as turn items (#20677)

2026-05-03 22:50:13 -07:00

unified_exec

Use selected turn environments for runtime context (#20281)

2026-05-01 11:00:14 -07:00

utils

…

agents_md_tests.rs

Remove js_repl feature (#19410)

2026-04-24 17:49:29 -07:00

agents_md.rs

[codex] Move config loading into codex-config (#19487)

2026-04-26 15:10:53 -07:00

apply_patch_tests.rs

…

apply_patch.rs

permissions: migrate approval and sandbox consumers to profiles (#19393)

2026-04-26 15:30:40 -07:00

arc_monitor_tests.rs

Surface multi-environment choices in environment context (#20646)

2026-05-01 22:11:06 +00:00

arc_monitor.rs

feat: add remote compaction v2 Responses client path (#20773)

2026-05-04 14:15:01 +02:00

client_common_tests.rs

Allow guardian bare allow output (#18797)

2026-04-21 15:37:12 -07:00

client_common.rs

[codex] Trace cancelled inference streams (#19839)

2026-04-27 21:58:29 +00:00

client_tests.rs

[rollout-trace] Include x-request-id in rollout trace. (#20066)

2026-04-28 21:11:17 +00:00

client.rs

core: share responses request builder with compact requests (#20989)

2026-05-04 17:18:38 +00:00

codex_delegate_tests.rs

Fix /review interrupt and TUI exit wedges (#18921)

2026-04-23 13:28:12 -07:00

codex_delegate.rs

Use selected turn environments for runtime context (#20281)

2026-05-01 11:00:14 -07:00

codex_thread.rs

Make thread store process-scoped (#19474)

2026-04-30 21:24:59 -07:00

command_canonicalization_tests.rs

…

command_canonicalization.rs

…

commit_attribution_tests.rs

…

commit_attribution.rs

…

compact_remote_v2.rs

feat: add remote compaction v2 Responses client path (#20773)

2026-05-04 14:15:01 +02:00

compact_remote.rs

feat: add remote compaction v2 Responses client path (#20773)

2026-05-04 14:15:01 +02:00

compact_tests.rs

Delete unused ResponseItem::Message.end_turn (#19605)

2026-04-26 17:18:09 -07:00

compact.rs

feat: add remote compaction v2 Responses client path (#20773)

2026-05-04 14:15:01 +02:00

config_lock.rs

feat: export and replay effective config locks (#20405)

2026-05-01 17:46:02 +02:00

connectors_tests.rs

Support disabling tool suggest for specific tools. (#20072)

2026-04-29 00:19:34 +00:00

connectors.rs

Move plugin out of core. (#20348)

2026-04-30 14:26:14 -07:00

consequential_tool_message_templates.json

…

environment_selection.rs

Surface multi-environment choices in environment context (#20646)

2026-05-01 22:11:06 +00:00

event_mapping_tests.rs

Delete unused ResponseItem::Message.end_turn (#19605)

2026-04-26 17:18:09 -07:00

event_mapping.rs

Organize context fragments (#18794)

2026-04-20 22:39:17 -07:00

exec_env_tests.rs

[codex] Move config loading into codex-config (#19487)

2026-04-26 15:10:53 -07:00

exec_env.rs

[codex] Move config loading into codex-config (#19487)

2026-04-26 15:10:53 -07:00

exec_policy_tests.rs

fix(exec_policy) heredoc parsing file_redirect (#20113)

2026-05-01 01:05:02 +00:00

exec_policy_windows_tests.rs

execpolicy: unwrap PowerShell -Command wrappers on Windows (#20336)

2026-05-01 00:56:20 +00:00

exec_policy.rs

fix(exec_policy) heredoc parsing file_redirect (#20113)

2026-05-01 01:05:02 +00:00

exec_tests.rs

fix: handle deferred network proxy denials (#19184)

2026-04-29 19:13:57 +00:00

exec.rs

fix: handle deferred network proxy denials (#19184)

2026-04-29 19:13:57 +00:00

file_watcher_tests.rs

fix: FS watcher when file does not exist yet (#18492)

2026-04-20 11:23:00 +01:00

file_watcher.rs

fix: FS watcher when file does not exist yet (#18492)

2026-04-20 11:23:00 +01:00

flags.rs

…

function_tool.rs

…

git_info_tests.rs

…

goals.rs

Keep paused goals paused on thread resume (#20790)

2026-05-04 08:58:07 -07:00

hook_runtime.rs

Add persisted hook enablement state (#19840)

2026-04-30 04:46:32 +00:00

installation_id.rs

feat: split memories part 2 (#19860)

2026-04-28 13:03:28 +02:00

landlock.rs

linux-sandbox: switch helper plumbing to PermissionProfile (#20106)

2026-04-28 19:43:44 -07:00

lib.rs

feat: add remote compaction v2 Responses client path (#20773)

2026-05-04 14:15:01 +02:00

mcp_openai_file.rs

refactor: route Codex auth through AuthProvider (#18811)

2026-04-23 17:14:02 -07:00

mcp_skill_dependencies.rs

[codex] Remove unused event messages (#20511)

2026-04-30 20:03:26 -07:00

mcp_tool_approval_templates.rs

…

mcp_tool_call_tests.rs

Unify skip-review handling for approval_mode = "approve" (#20750)

2026-05-04 10:30:47 -07:00

mcp_tool_call.rs

[codex] Emit MCP tool calls as turn items (#20677)

2026-05-03 22:50:13 -07:00

mcp_tool_exposure_test.rs

permissions: make runtime config profile-backed (#19606)

2026-04-26 13:29:54 -07:00

mcp_tool_exposure.rs

…

mcp.rs

Move plugin out of core. (#20348)

2026-04-30 14:26:14 -07:00

memory_usage.rs

chore: split memories part 1 (#19818)

2026-04-27 16:01:05 +02:00

mention_syntax.rs

…

message_history_tests.rs

…

message_history.rs

…

network_policy_decision_tests.rs

…

network_policy_decision.rs

…

network_proxy_loader_tests.rs

…

network_proxy_loader.rs

inline hostname resolution for remote sandbox config (#19739)

2026-04-27 03:18:57 +00:00

original_image_detail.rs

Remove js_repl feature (#19410)

2026-04-24 17:49:29 -07:00

otel_init.rs

…

personality_migration_tests.rs

…

personality_migration.rs

Make thread store process-scoped (#19474)

2026-04-30 21:24:59 -07:00

prompt_debug.rs

Make thread store process-scoped (#19474)

2026-04-30 21:24:59 -07:00

realtime_context_tests.rs

Delete unused ResponseItem::Message.end_turn (#19605)

2026-04-26 17:18:09 -07:00

realtime_context.rs

[codex] Route live thread writes through ThreadStore (#18882)

2026-04-23 10:17:09 -07:00

realtime_conversation_tests.rs

Update realtime handoff transcript handling (#18597)

2026-04-20 14:04:09 -07:00

realtime_conversation.rs

realtime: rename provider session ids (#20361)

2026-04-30 13:39:48 +03:00

realtime_prompt.rs

…

review_format.rs

…

review_prompts.rs

…

rollout.rs

feat: split memories part 2 (#19860)

2026-04-28 13:03:28 +02:00

safety_tests.rs

permissions: remove cwd special path (#19841)

2026-04-27 13:41:27 -07:00

safety.rs

permissions: migrate approval and sandbox consumers to profiles (#19393)

2026-04-26 15:30:40 -07:00

sandbox_tags_tests.rs

permissions: make runtime config profile-backed (#19606)

2026-04-26 13:29:54 -07:00

sandbox_tags.rs

permissions: make runtime config profile-backed (#19606)

2026-04-26 13:29:54 -07:00

session_prefix.rs

Organize context fragments (#18794)

2026-04-20 22:39:17 -07:00

session_rollout_init_error.rs

…

session_startup_prewarm.rs

…

shell_detect.rs

…

shell_snapshot_tests.rs

…

shell_snapshot.rs

Avoid false shell snapshot cleanup warnings (#18441)

2026-04-20 15:15:05 +01:00

shell_tests.rs

…

shell.rs

…

skills_watcher.rs

Move plugin out of core. (#20348)

2026-04-30 14:26:14 -07:00

skills.rs

Split DeveloperInstructions into individual fragments. (#18813)

2026-04-21 10:22:36 -07:00

spawn.rs

…

state_db_bridge.rs

…

stream_events_utils_tests.rs

Delete unused ResponseItem::Message.end_turn (#19605)

2026-04-26 17:18:09 -07:00

stream_events_utils.rs

Remove no-tool goal continuation suppression (#20523)

2026-05-01 09:09:55 -07:00

test_support.rs

Make thread store process-scoped (#19474)

2026-04-30 21:24:59 -07:00

thread_manager_tests.rs

Keep paused goals paused on thread resume (#20790)

2026-05-04 08:58:07 -07:00

thread_manager.rs

Use selected turn environments for runtime context (#20281)

2026-05-01 11:00:14 -07:00

thread_rollout_truncation_tests.rs

Delete unused ResponseItem::Message.end_turn (#19605)

2026-04-26 17:18:09 -07:00

thread_rollout_truncation.rs

…

turn_diff_tracker_tests.rs

…

turn_diff_tracker.rs

…

turn_metadata_tests.rs

Escape turn metadata headers as ASCII JSON (#19620)

2026-04-29 15:35:33 -07:00

turn_metadata.rs

Escape turn metadata headers as ASCII JSON (#19620)

2026-04-29 15:35:33 -07:00

turn_timing_tests.rs

Add turn start timestamp to turn metadata (#19473)

2026-04-28 16:36:59 +00:00

turn_timing.rs

feat: add remote compaction v2 Responses client path (#20773)

2026-05-04 14:15:01 +02:00

unavailable_tool.rs

…

user_shell_command_tests.rs

Organize context fragments (#18794)

2026-04-20 22:39:17 -07:00

user_shell_command.rs

Organize context fragments (#18794)

2026-04-20 22:39:17 -07:00

util_tests.rs

Update models.json (#18586)

2026-04-20 10:27:01 -07:00

util.rs

…

web_search.rs

…

windows_sandbox_read_grants_tests.rs

…

windows_sandbox_read_grants.rs

…

windows_sandbox_tests.rs

…

windows_sandbox.rs

…