mirror of
https://github.com/openai/codex.git
synced 2026-04-27 08:05:51 +00:00
413c1e1fdf
## Summary - reduce public module visibility across Rust crates, preferring private or crate-private modules with explicit crate-root public exports - update external call sites and tests to use the intended public crate APIs instead of reaching through module trees - add the module visibility guideline to AGENTS.md ## Validation - `cargo check --workspace --all-targets --message-format=short` passed before the final fix/format pass - `just fix` completed successfully - `just fmt` completed successfully - `git diff --check` passed
92 lines
2.6 KiB
Rust
92 lines
2.6 KiB
Rust
use codex_otel::MetricsClient;
|
|
use codex_otel::MetricsConfig;
|
|
use codex_otel::MetricsError;
|
|
use codex_otel::Result;
|
|
use opentelemetry_sdk::metrics::InMemoryMetricExporter;
|
|
|
|
fn build_in_memory_client() -> Result<MetricsClient> {
|
|
let exporter = InMemoryMetricExporter::default();
|
|
let config = MetricsConfig::in_memory("test", "codex-cli", env!("CARGO_PKG_VERSION"), exporter);
|
|
MetricsClient::new(config)
|
|
}
|
|
|
|
// Ensures invalid tag components are rejected during config build.
|
|
#[test]
|
|
fn invalid_tag_component_is_rejected() -> Result<()> {
|
|
let err = MetricsConfig::in_memory(
|
|
"test",
|
|
"codex-cli",
|
|
env!("CARGO_PKG_VERSION"),
|
|
InMemoryMetricExporter::default(),
|
|
)
|
|
.with_tag("bad key", "value")
|
|
.unwrap_err();
|
|
assert!(matches!(
|
|
err,
|
|
MetricsError::InvalidTagComponent { label, value }
|
|
if label == "tag key" && value == "bad key"
|
|
));
|
|
Ok(())
|
|
}
|
|
|
|
// Ensures per-metric tag keys are validated.
|
|
#[test]
|
|
fn counter_rejects_invalid_tag_key() -> Result<()> {
|
|
let metrics = build_in_memory_client()?;
|
|
let err = metrics
|
|
.counter("codex.turns", /*inc*/ 1, &[("bad key", "value")])
|
|
.unwrap_err();
|
|
assert!(matches!(
|
|
err,
|
|
MetricsError::InvalidTagComponent { label, value }
|
|
if label == "tag key" && value == "bad key"
|
|
));
|
|
metrics.shutdown()?;
|
|
Ok(())
|
|
}
|
|
|
|
// Ensures per-metric tag values are validated.
|
|
#[test]
|
|
fn histogram_rejects_invalid_tag_value() -> Result<()> {
|
|
let metrics = build_in_memory_client()?;
|
|
let err = metrics
|
|
.histogram(
|
|
"codex.request_latency",
|
|
/*value*/ 3,
|
|
&[("route", "bad value")],
|
|
)
|
|
.unwrap_err();
|
|
assert!(matches!(
|
|
err,
|
|
MetricsError::InvalidTagComponent { label, value }
|
|
if label == "tag value" && value == "bad value"
|
|
));
|
|
metrics.shutdown()?;
|
|
Ok(())
|
|
}
|
|
|
|
// Ensures invalid metric names are rejected.
|
|
#[test]
|
|
fn counter_rejects_invalid_metric_name() -> Result<()> {
|
|
let metrics = build_in_memory_client()?;
|
|
let err = metrics.counter("bad name", /*inc*/ 1, &[]).unwrap_err();
|
|
assert!(matches!(
|
|
err,
|
|
MetricsError::InvalidMetricName { name } if name == "bad name"
|
|
));
|
|
metrics.shutdown()?;
|
|
Ok(())
|
|
}
|
|
|
|
#[test]
|
|
fn counter_rejects_negative_increment() -> Result<()> {
|
|
let metrics = build_in_memory_client()?;
|
|
let err = metrics.counter("codex.turns", /*inc*/ -1, &[]).unwrap_err();
|
|
assert!(matches!(
|
|
err,
|
|
MetricsError::NegativeCounterIncrement { name, inc } if name == "codex.turns" && inc == -1
|
|
));
|
|
metrics.shutdown()?;
|
|
Ok(())
|
|
}
|