Matthew Zeng 71174574ad Add server-level approval defaults for custom MCP servers (#17843) ...

## Summary
- Add `default_tools_approval_mode` support for custom MCP server
configs, matching the existing `codex_apps` behavior
- Apply approval precedence as per-tool override, then server default,
then `auto`
- Update config serialization, CLI display, schema generation, docs, and
tests

## Testing
- `cargo check -p codex-config`
- `cargo check -p codex-core`
- `just write-config-schema`
- `just fmt`
- `cargo test -p codex-config`
- Targeted `codex-core` tests for config parsing, config writes, and MCP
approval precedence
- `just fix -p codex-config -p codex-core`

2026-04-16 18:18:07 +00:00

..

snapshots

Clarify realtime v2 context and handoff messages (#17896)

2026-04-15 16:26:20 -07:00

abort_tasks.rs

Forward app-server turn clientMetadata to Responses (#16009)

2026-04-09 11:52:37 -07:00

agent_jobs.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

agent_websocket.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

agents_md.rs

Run exec-server fs operations through sandbox helper (#17294)

2026-04-12 18:36:03 -07:00

apply_patch_cli.rs

fix: Revert danger-full-access denylist-only mode (#17732)

2026-04-14 09:50:14 -07:00

approvals.rs

Stabilize Bazel tests (timeout tweaks and flake fixes) (#17791)

2026-04-16 07:57:51 -07:00

cli_stream.rs

Remove OPENAI_BASE_URL config fallback (#16720)

2026-04-03 15:03:21 -07:00

client_websockets.rs

[codex-analytics] add session source to client metadata (#17374)

2026-04-14 08:55:12 -07:00

client.rs

Revert "Option to Notify Workspace Owner When Usage Limit is Reached" (#17391)

2026-04-10 23:33:13 +00:00

code_mode.rs

Add server-level approval defaults for custom MCP servers (#17843)

2026-04-16 18:18:07 +00:00

codex_delegate.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

collaboration_instructions.rs

Forward app-server turn clientMetadata to Responses (#16009)

2026-04-09 11:52:37 -07:00

compact_remote.rs

Stabilize Bazel tests (timeout tweaks and flake fixes) (#17791)

2026-04-16 07:57:51 -07:00

compact_resume_fork.rs

Forward app-server turn clientMetadata to Responses (#16009)

2026-04-09 11:52:37 -07:00

compact.rs

Stabilize Bazel tests (timeout tweaks and flake fixes) (#17791)

2026-04-16 07:57:51 -07:00

deprecation_notice.rs

Split features into codex-features crate (#15253)

2026-03-19 20:12:07 -07:00

exec_policy.rs

chore(core) Add approvals reviewer to UserTurn (#15426)

2026-03-23 15:19:01 -07:00

exec.rs

sandbox: remove dead seatbelt helper and update tests (#17859)

2026-04-14 20:48:01 -07:00

fork_thread.rs

Forward app-server turn clientMetadata to Responses (#16009)

2026-04-09 11:52:37 -07:00

hierarchical_agents.rs

Run exec-server fs operations through sandbox helper (#17294)

2026-04-12 18:36:03 -07:00

hooks.rs

Forward app-server turn clientMetadata to Responses (#16009)

2026-04-09 11:52:37 -07:00

image_rollout.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

items.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

js_repl.rs

Add server-level approval defaults for custom MCP servers (#17843)

2026-04-16 18:18:07 +00:00

json_result.rs

chore(core) Add approvals reviewer to UserTurn (#15426)

2026-03-23 15:19:01 -07:00

live_cli.rs

feat: introduce codex-utils-cargo-bin as an alternative to assert_cmd::Command (#8496)

2025-12-23 19:29:32 -08:00

live_reload.rs

Refactor config types into a separate crate (#16962)

2026-04-07 00:32:41 +00:00

memories.rs

feat: cleaning of memories extension (#17844)

2026-04-15 10:38:11 +01:00

mod.rs

sandbox: remove dead seatbelt helper and update tests (#17859)

2026-04-14 20:48:01 -07:00

model_overrides.rs

Add Smart Approvals guardian review across core, app-server, and TUI (#13860)

2026-03-13 15:27:00 -07:00

model_switching.rs

Use model metadata for Fast Mode status (#16949)

2026-04-07 17:55:40 -07:00

model_visible_layout.rs

Forward app-server turn clientMetadata to Responses (#16009)

2026-04-09 11:52:37 -07:00

models_cache_ttl.rs

Use model metadata for Fast Mode status (#16949)

2026-04-07 17:55:40 -07:00

models_etag_responses.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

openai_file_mcp.rs

register all mcp tools with namespace (#17404)

2026-04-15 21:02:59 +08:00

otel.rs

Forward app-server turn clientMetadata to Responses (#16009)

2026-04-09 11:52:37 -07:00

override_updates.rs

Add Smart Approvals guardian review across core, app-server, and TUI (#13860)

2026-03-13 15:27:00 -07:00

pending_input.rs

fix: Revert danger-full-access denylist-only mode (#17732)

2026-04-14 09:50:14 -07:00

permissions_messages.rs

Forward app-server turn clientMetadata to Responses (#16009)

2026-04-09 11:52:37 -07:00

personality_migration.rs

fix(app-server) revert null instructions changes (#17047)

2026-04-07 15:18:34 -07:00

personality.rs

Use model metadata for Fast Mode status (#16949)

2026-04-07 17:55:40 -07:00

plugins.rs

register all mcp tools with namespace (#17404)

2026-04-15 21:02:59 +08:00

prompt_caching.rs

Forward app-server turn clientMetadata to Responses (#16009)

2026-04-09 11:52:37 -07:00

quota_exceeded.rs

Forward app-server turn clientMetadata to Responses (#16009)

2026-04-09 11:52:37 -07:00

realtime_conversation.rs

Clarify realtime v2 context and handoff messages (#17896)

2026-04-15 16:26:20 -07:00

remote_env.rs

Stabilize exec-server filesystem tests in CI (#17671)

2026-04-13 16:53:42 -07:00

remote_models.rs

Use model metadata for Fast Mode status (#16949)

2026-04-07 17:55:40 -07:00

request_compression.rs

Forward app-server turn clientMetadata to Responses (#16009)

2026-04-09 11:52:37 -07:00

request_permissions_tool.rs

chore(core) Add approvals reviewer to UserTurn (#15426)

2026-03-23 15:19:01 -07:00

request_permissions.rs

permissions: remove macOS seatbelt extension profiles (#15918)

2026-03-26 17:12:45 -07:00

request_user_input.rs

chore(core) Add approvals reviewer to UserTurn (#15426)

2026-03-23 15:19:01 -07:00

responses_api_proxy_headers.rs

fix: more flake (#18006)

2026-04-16 10:01:45 +01:00

resume_warning.rs

feat(permissions): add glob deny-read policy support (#15979)

2026-04-16 10:31:51 -07:00

resume.rs

Forward app-server turn clientMetadata to Responses (#16009)

2026-04-09 11:52:37 -07:00

review.rs

Forward app-server turn clientMetadata to Responses (#16009)

2026-04-09 11:52:37 -07:00

rmcp_client.rs

Add server-level approval defaults for custom MCP servers (#17843)

2026-04-16 18:18:07 +00:00

rollout_list_find.rs

chore: merge name and title (#17116)

2026-04-09 18:44:26 +01:00

safety_check_downgrade.rs

chore(core) Add approvals reviewer to UserTurn (#15426)

2026-03-23 15:19:01 -07:00

search_tool.rs

Add server-level approval defaults for custom MCP servers (#17843)

2026-04-16 18:18:07 +00:00

shell_command.rs

fix: preserve platform-specific core shell env vars (#16707)

2026-04-03 12:07:07 -07:00

shell_serialization.rs

[codex] Apply patches through executor filesystem (#17048)

2026-04-07 16:35:02 -07:00

shell_snapshot.rs

Route apply_patch through the environment filesystem (#17674)

2026-04-14 12:49:02 -07:00

skill_approval.rs

core: remove special execve handling for skill scripts (#15812)

2026-03-26 07:46:04 -07:00

skills.rs

Make skill loading filesystem-aware (#17720)

2026-04-14 15:40:40 -07:00

spawn_agent_description.rs

Use model metadata for Fast Mode status (#16949)

2026-04-07 17:55:40 -07:00

sqlite_state.rs

Add server-level approval defaults for custom MCP servers (#17843)

2026-04-16 18:18:07 +00:00

stream_error_allows_next_turn.rs

Forward app-server turn clientMetadata to Responses (#16009)

2026-04-09 11:52:37 -07:00

stream_no_completed.rs

Forward app-server turn clientMetadata to Responses (#16009)

2026-04-09 11:52:37 -07:00

subagent_notifications.rs

Use AbsolutePathBuf in skill loading and codex_home (#17407)

2026-04-13 10:26:51 -07:00

tool_harness.rs

chore(core) Add approvals reviewer to UserTurn (#15426)

2026-03-23 15:19:01 -07:00

tool_parallelism.rs

chore(core) Add approvals reviewer to UserTurn (#15426)

2026-03-23 15:19:01 -07:00

tool_suggest.rs

remove temporary ownership re-exports (#16626)

2026-04-03 00:33:34 -07:00

tools.rs

Add server-level approval defaults for custom MCP servers (#17843)

2026-04-16 18:18:07 +00:00

truncation.rs

Add server-level approval defaults for custom MCP servers (#17843)

2026-04-16 18:18:07 +00:00

turn_state.rs

Stabilize websocket response.failed error delivery (#14017)

2026-03-11 12:33:09 -07:00

undo.rs

Split features into codex-features crate (#15253)

2026-03-19 20:12:07 -07:00

unified_exec.rs

Stabilize Bazel tests (timeout tweaks and flake fixes) (#17791)

2026-04-16 07:57:51 -07:00

unstable_features_warning.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

user_notification.rs

Forward app-server turn clientMetadata to Responses (#16009)

2026-04-09 11:52:37 -07:00

user_shell_cmd.rs

fix: add more detail to test assertion (#16606)

2026-04-02 12:34:42 -07:00

view_image.rs

Stabilize Bazel tests (timeout tweaks and flake fixes) (#17791)

2026-04-16 07:57:51 -07:00

web_search.rs

Split features into codex-features crate (#15253)

2026-03-19 20:12:07 -07:00

websocket_fallback.rs

remove temporary ownership re-exports (#16626)

2026-04-03 00:33:34 -07:00

window_headers.rs

Forward app-server turn clientMetadata to Responses (#16009)

2026-04-09 11:52:37 -07:00