mirror of
https://github.com/openai/codex.git
synced 2026-05-29 15:30:22 +00:00
d4f842f3b3
## Why The goal extension can create and surface goals, but the live turn-accounting path still stopped short of persisting active-goal progress. That leaves token and wall-clock usage, plus `ThreadGoalUpdated` events, out of sync with the extension boundary once work actually advances or a goal transitions out of active state. ## What changed - Teach `GoalAccountingState` to track the current turn, active goal, token deltas, and wall-clock progress snapshots against the persisted goal id. - Flush active-goal accounting from tool-finish, turn-stop, and turn-abort lifecycle hooks, and emit `ThreadGoalUpdated` events when persisted progress changes. - Route `create_goal` and `update_goal` through the same accounting state so new goals start from the right baseline, final progress is flushed before status changes, and `update_goal` can mark a goal `blocked` as well as `complete`. - Keep budget-limited goals accruing through the end of the turn while clearing local active-goal state once a turn or explicit update is finished. - Expand backend and lifecycle coverage around store ids, baseline reset, tool-finish accounting, budget-limited carry-through, and blocked-goal updates. ## Testing - Added focused backend coverage in `codex-rs/ext/goal/tests/goal_extension_backend.rs` for baseline reset, tool-finish accounting, budget-limited turns, and blocked-goal updates. - Extended `codex-rs/core/src/session/tests.rs` to assert that lifecycle inputs expose the expected session, thread, and turn store ids.
91 lines
3.6 KiB
Rust
91 lines
3.6 KiB
Rust
//! Responses API tool definitions for persisted thread goals.
|
|
|
|
use codex_tools::JsonSchema;
|
|
use codex_tools::ResponsesApiTool;
|
|
use codex_tools::ToolSpec;
|
|
use serde_json::json;
|
|
use std::collections::BTreeMap;
|
|
|
|
pub const GET_GOAL_TOOL_NAME: &str = "get_goal";
|
|
pub const CREATE_GOAL_TOOL_NAME: &str = "create_goal";
|
|
pub const UPDATE_GOAL_TOOL_NAME: &str = "update_goal";
|
|
|
|
pub fn create_get_goal_tool() -> ToolSpec {
|
|
ToolSpec::Function(ResponsesApiTool {
|
|
name: GET_GOAL_TOOL_NAME.to_string(),
|
|
description: "Get the current goal for this thread, including status, budgets, token and elapsed-time usage, and remaining token budget."
|
|
.to_string(),
|
|
strict: false,
|
|
defer_loading: None,
|
|
parameters: JsonSchema::object(BTreeMap::new(), Some(Vec::new()), Some(false.into())),
|
|
output_schema: None,
|
|
})
|
|
}
|
|
|
|
pub fn create_create_goal_tool() -> ToolSpec {
|
|
let properties = BTreeMap::from([
|
|
(
|
|
"objective".to_string(),
|
|
JsonSchema::string(Some(
|
|
"Required. The concrete objective to start pursuing. This starts a new active goal only when no goal is currently defined; if a goal already exists, this tool fails."
|
|
.to_string(),
|
|
)),
|
|
),
|
|
(
|
|
"token_budget".to_string(),
|
|
JsonSchema::integer(Some(
|
|
"Optional positive token budget for the new active goal.".to_string(),
|
|
)),
|
|
),
|
|
]);
|
|
|
|
ToolSpec::Function(ResponsesApiTool {
|
|
name: CREATE_GOAL_TOOL_NAME.to_string(),
|
|
description: format!(
|
|
r#"Create a goal only when explicitly requested by the user or system/developer instructions; do not infer goals from ordinary tasks.
|
|
Set token_budget only when an explicit token budget is requested. Fails if a goal exists; use {UPDATE_GOAL_TOOL_NAME} only for status."#
|
|
),
|
|
strict: false,
|
|
defer_loading: None,
|
|
parameters: JsonSchema::object(
|
|
properties,
|
|
/*required*/ Some(vec!["objective".to_string()]),
|
|
Some(false.into()),
|
|
),
|
|
output_schema: None,
|
|
})
|
|
}
|
|
|
|
pub fn create_update_goal_tool() -> ToolSpec {
|
|
let properties = BTreeMap::from([(
|
|
"status".to_string(),
|
|
JsonSchema::string_enum(
|
|
vec![json!("complete"), json!("blocked")],
|
|
Some(
|
|
"Required. Set to complete only when the objective is achieved and no required work remains. Set to blocked only when the goal cannot currently proceed without a user decision, missing dependency, or external unblock."
|
|
.to_string(),
|
|
),
|
|
),
|
|
)]);
|
|
|
|
ToolSpec::Function(ResponsesApiTool {
|
|
name: UPDATE_GOAL_TOOL_NAME.to_string(),
|
|
description: r#"Update the existing goal.
|
|
Use this tool only to mark the goal achieved or blocked.
|
|
Set status to `complete` only when the objective has actually been achieved and no required work remains.
|
|
Set status to `blocked` only when the goal cannot currently proceed until something external changes.
|
|
Do not mark a goal complete merely because its budget is nearly exhausted or because you are stopping work.
|
|
You cannot use this tool to pause, resume, or budget-limit a goal; those status changes are controlled by the user or system.
|
|
When marking a budgeted goal achieved with status `complete`, report the final token usage from the tool result to the user."#
|
|
.to_string(),
|
|
strict: false,
|
|
defer_loading: None,
|
|
parameters: JsonSchema::object(
|
|
properties,
|
|
/*required*/ Some(vec!["status".to_string()]),
|
|
Some(false.into()),
|
|
),
|
|
output_schema: None,
|
|
})
|
|
}
|