mirror of https://github.com/openai/codex.git synced 2026-04-24 22:54:54 +00:00

Files

Michael Bolin a6974087e5 chore: enusre the logic that creates ConfigLayerStack has access to cwd (#8353 )

`load_config_layers_state()` should load config from a
`.codex/config.toml` in any folder between the `cwd` for a thread and
the project root. Though in order to do that,
`load_config_layers_state()` needs to know what the `cwd` is, so this PR
does the work to thread the `cwd` through for existing callsites.

A notable exception is the `/config` endpoint in app server for which a
`cwd` is not guaranteed to be associated with the query, so the `cwd`
param is `Option<AbsolutePathBuf>` to account for this case.

The logic to make use of the `cwd` will be done in a follow-up PR.

2025-12-19 20:11:27 -08:00

2.4 KiB

Raw Blame History

`codex-core` config loader

This module is the canonical place to load and describe Codex configuration layers (user config, CLI/session overrides, managed config, and MDM-managed preferences) and to produce:

An effective merged TOML config.
Per-key origins metadata (which layer “wins” for a given key).
Per-layer versions (stable fingerprints) used for optimistic concurrency / conflict detection.

Public surface

Exported from codex_core::config_loader:

load_config_layers_state(codex_home, cwd_opt, cli_overrides, overrides) -> ConfigLayerStack
ConfigLayerStack
- effective_config() -> toml::Value
- origins() -> HashMap<String, ConfigLayerMetadata>
- layers_high_to_low() -> Vec<ConfigLayer>
- with_user_config(user_config) -> ConfigLayerStack
ConfigLayerEntry (one layer’s {name, config, version}; name carries source metadata)
LoaderOverrides (test/override hooks for managed config sources)
merge_toml_values(base, overlay) (public helper used elsewhere)

Layering model

Precedence is top overrides bottom:

MDM managed preferences (macOS only)
System managed config (e.g. managed_config.toml)
Session flags (CLI overrides, applied as dotted-path TOML writes)
User config (config.toml)

This is what ConfigLayerStack::effective_config() implements.

Typical usage

Most callers want the effective config plus metadata:

use codex_core::config_loader::{load_config_layers_state, LoaderOverrides};
use codex_utils_absolute_path::AbsolutePathBuf;
use toml::Value as TomlValue;

let cli_overrides: Vec<(String, TomlValue)> = Vec::new();
let cwd = AbsolutePathBuf::current_dir()?;
let layers = load_config_layers_state(
    &codex_home,
    Some(cwd),
    &cli_overrides,
    LoaderOverrides::default(),
).await?;

let effective = layers.effective_config();
let origins = layers.origins();
let layers_for_ui = layers.layers_high_to_low();

Internal layout

Implementation is split by concern:

state.rs: public types (ConfigLayerEntry, ConfigLayerStack) + merge/origins convenience methods.
layer_io.rs: reading config.toml, managed config, and managed preferences inputs.
overrides.rs: CLI dotted-path overrides → TOML “session flags” layer.
merge.rs: recursive TOML merge.
fingerprint.rs: stable per-layer hashing and per-key origins traversal.
macos.rs: managed preferences integration (macOS only).

2.4 KiB Raw Blame History Unescape Escape

codex-core config loader