mirror of
https://github.com/openai/codex.git
synced 2026-05-28 23:10:20 +00:00
Addresses #23181 ## Why Renamed threads can share names, so hints that suggest resuming directly by name are ambiguous. Issue #23181 asks for the picker hint to include the thread name and thread ID in parens so users can disambiguate safely. ## What - Adds a shared resume hint formatter for named threads: run `codex resume`, then select `<name> (<thread-id>)`. - Uses that hint for /rename confirmations, TUI session summaries, and CLI/TUI exit messages. - Keeps direct `codex resume <thread-id>` guidance for unnamed threads. ## Verification Manually verified that message after `/rename` and after `/exit` include session ID in parens. --------- Co-authored-by: Felipe Coury <felipe.coury@openai.com>
77 lines
2.0 KiB
Rust
77 lines
2.0 KiB
Rust
use clap::Parser;
|
|
use codex_arg0::Arg0DispatchPaths;
|
|
use codex_arg0::arg0_dispatch_or_else;
|
|
use codex_config::LoaderOverrides;
|
|
use codex_tui::AppExitInfo;
|
|
use codex_tui::Cli;
|
|
use codex_tui::ExitReason;
|
|
use codex_tui::run_main;
|
|
use codex_utils_cli::CliConfigOverrides;
|
|
use codex_utils_cli::resume_hint;
|
|
use supports_color::Stream;
|
|
|
|
fn format_exit_messages(exit_info: AppExitInfo, color_enabled: bool) -> Vec<String> {
|
|
let AppExitInfo {
|
|
token_usage,
|
|
thread_id,
|
|
thread_name,
|
|
..
|
|
} = exit_info;
|
|
|
|
let mut lines = Vec::new();
|
|
if !token_usage.is_zero() {
|
|
lines.push(token_usage.to_string());
|
|
}
|
|
|
|
if let Some(resume_cmd) = resume_hint(thread_name.as_deref(), thread_id) {
|
|
let command = if color_enabled {
|
|
format!("\u{1b}[36m{resume_cmd}\u{1b}[39m")
|
|
} else {
|
|
resume_cmd
|
|
};
|
|
lines.push(format!("To continue this session, run {command}"));
|
|
}
|
|
|
|
lines
|
|
}
|
|
|
|
#[derive(Parser, Debug)]
|
|
struct TopCli {
|
|
#[clap(flatten)]
|
|
config_overrides: CliConfigOverrides,
|
|
|
|
#[clap(flatten)]
|
|
inner: Cli,
|
|
}
|
|
|
|
fn main() -> anyhow::Result<()> {
|
|
arg0_dispatch_or_else(|arg0_paths: Arg0DispatchPaths| async move {
|
|
let top_cli = TopCli::parse();
|
|
let mut inner = top_cli.inner;
|
|
inner
|
|
.config_overrides
|
|
.raw_overrides
|
|
.splice(0..0, top_cli.config_overrides.raw_overrides);
|
|
let exit_info = run_main(
|
|
inner,
|
|
arg0_paths,
|
|
LoaderOverrides::default(),
|
|
/*explicit_remote_endpoint*/ None,
|
|
)
|
|
.await?;
|
|
match exit_info.exit_reason {
|
|
ExitReason::Fatal(message) => {
|
|
eprintln!("ERROR: {message}");
|
|
std::process::exit(1);
|
|
}
|
|
ExitReason::UserRequested => {}
|
|
}
|
|
|
|
let color_enabled = supports_color::on(Stream::Stdout).is_some();
|
|
for line in format_exit_messages(exit_info, color_enabled) {
|
|
println!("{line}");
|
|
}
|
|
Ok(())
|
|
})
|
|
}
|