mirror of
https://github.com/openai/codex.git
synced 2026-04-27 08:05:51 +00:00
86d5a9d80d
For the `approval_policy` config option, renames `unless-allow-listed` to `untrusted`. In general, when it comes to exec'ing commands, I think "trusted" is a more accurate term than "safe." Also drops the `AskForApproval::AutoEdit` variant, as we were not really making use of it, anyway. Fixes https://github.com/openai/codex/issues/1250. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/openai/codex/pull/1378). * #1379 * __->__ #1378
35 lines
1.2 KiB
Rust
35 lines
1.2 KiB
Rust
//! Standard type to use with the `--approval-mode` CLI option.
|
|
//! Available when the `cli` feature is enabled for the crate.
|
|
|
|
use clap::ValueEnum;
|
|
|
|
use codex_core::protocol::AskForApproval;
|
|
|
|
#[derive(Clone, Copy, Debug, ValueEnum)]
|
|
#[value(rename_all = "kebab-case")]
|
|
pub enum ApprovalModeCliArg {
|
|
/// Only run "trusted" commands (e.g. ls, cat, sed) without asking for user
|
|
/// approval. Will escalate to the user if the model proposes a command that
|
|
/// is not in the "trusted" set.
|
|
Untrusted,
|
|
|
|
/// Run all commands without asking for user approval.
|
|
/// Only asks for approval if a command fails to execute, in which case it
|
|
/// will escalate to the user to ask for un-sandboxed execution.
|
|
OnFailure,
|
|
|
|
/// Never ask for user approval
|
|
/// Execution failures are immediately returned to the model.
|
|
Never,
|
|
}
|
|
|
|
impl From<ApprovalModeCliArg> for AskForApproval {
|
|
fn from(value: ApprovalModeCliArg) -> Self {
|
|
match value {
|
|
ApprovalModeCliArg::Untrusted => AskForApproval::UnlessAllowListed,
|
|
ApprovalModeCliArg::OnFailure => AskForApproval::OnFailure,
|
|
ApprovalModeCliArg::Never => AskForApproval::Never,
|
|
}
|
|
}
|
|
}
|