pakrym-oai 408e6218ab Reapply "Move skills watcher to app-server" (#21652) ...

## Why

PR #21460 reverted the earlier move of skills change watching from
`codex-core` into app-server. This reapplies that boundary change so
app-server owns client-facing `skills/changed` notifications and core no
longer carries the watcher.

## What

- Restore the app-server `SkillsWatcher` and register it from thread
listener setup.
- Remove the core-owned skills watcher and its core live-reload
integration surface.
- Restore app-server coverage for `skills/changed` notifications after a
watched skill file changes.

## Validation

- `cargo test -p codex-app-server --test all
suite::v2::skills_list::skills_changed_notification_is_emitted_after_skill_change
-- --exact --nocapture`
- `cargo test -p codex-core --lib --no-run`

2026-05-08 17:41:15 -07:00

..

snapshots

Omit service_tier from remote /responses/compact requests under API auth (#21676)

2026-05-08 11:15:14 +03:00

abort_tasks.rs

Add turn-scoped environment selections (#18416)

2026-04-21 17:48:33 -07:00

agent_jobs.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

agent_websocket.rs

2- Use string service tiers in session protocol (#20971)

2026-05-06 18:00:21 +03:00

agents_md.rs

Run exec-server fs operations through sandbox helper (#17294)

2026-04-12 18:36:03 -07:00

apply_patch_cli.rs

[codex] Delete function-style apply_patch (#21651)

2026-05-08 13:00:57 -07:00

approvals.rs

[codex] Delete function-style apply_patch (#21651)

2026-05-08 13:00:57 -07:00

cli_stream.rs

Remove OPENAI_BASE_URL config fallback (#16720)

2026-04-03 15:03:21 -07:00

client_websockets.rs

[codex] request desktop attestation from app (#20619)

2026-05-08 12:36:02 -07:00

client.rs

[codex] request desktop attestation from app (#20619)

2026-05-08 12:36:02 -07:00

code_mode.rs

Prune unused code-mode globals (#20542)

2026-05-01 15:11:22 -07:00

codex_delegate.rs

[codex] Delete function-style apply_patch (#21651)

2026-05-08 13:00:57 -07:00

collaboration_instructions.rs

permissions: store only constrained permission profiles (#19735)

2026-04-26 20:59:58 -07:00

compact_remote.rs

Omit service_tier from remote /responses/compact requests under API auth (#21676)

2026-05-08 11:15:14 +03:00

compact_resume_fork.rs

[codex-analytics] rework thread_source for thread analytics (#20949)

2026-05-06 02:12:31 +00:00

compact.rs

Add compact lifecycle hooks (started by vincentkoc - external contrib) (#19905)

2026-05-06 18:08:31 -07:00

deprecation_notice.rs

revert legacy notify deprecation (#21152)

2026-05-05 10:34:44 -07:00

exec_policy.rs

execpolicy: unwrap PowerShell -Command wrappers on Windows (#20336)

2026-05-01 00:56:20 +00:00

exec.rs

core tests: migrate more turns to permission profiles (#20013)

2026-04-28 17:05:53 -07:00

fork_thread.rs

feat: add session_id (#20437)

2026-05-06 10:48:37 +02:00

hierarchical_agents.rs

Run exec-server fs operations through sandbox helper (#17294)

2026-04-12 18:36:03 -07:00

hooks_mcp.rs

hook trust metadata and enforcement (#20321)

2026-05-05 19:13:55 +00:00

hooks.rs

[codex] Delete function-style apply_patch (#21651)

2026-05-08 13:00:57 -07:00

image_rollout.rs

core tests: build user turns from permission profiles (#20011)

2026-04-28 17:03:20 -07:00

items.rs

feat: add session_id (#20437)

2026-05-06 10:48:37 +02:00

json_result.rs

core tests: build user turns from permission profiles (#20011)

2026-04-28 17:03:20 -07:00

live_cli.rs

…

mod.rs

Reapply "Move skills watcher to app-server" (#21652)

2026-05-08 17:41:15 -07:00

model_overrides.rs

app-server: accept permission profile overrides (#18279)

2026-04-22 13:34:33 -07:00

model_switching.rs

[codex] Generalize service tier slash commands (#21745)

2026-05-08 20:09:51 +03:00

model_visible_layout.rs

core tests: configure profiles directly (#20015)

2026-04-28 17:06:59 -07:00

models_cache_ttl.rs

1- Add model service tiers metadata (#20969)

2026-05-05 09:51:18 +03:00

models_etag_responses.rs

core tests: migrate more turns to permission profiles (#20013)

2026-04-28 17:05:53 -07:00

openai_file_mcp.rs

hook trust metadata and enforcement (#20321)

2026-05-05 19:13:55 +00:00

otel.rs

Add reasoning effort to turn tracing spans (#20060)

2026-05-04 12:57:05 -07:00

override_updates.rs

Enable --deny-warnings for cargo shear (#21616)

2026-05-08 20:29:00 +00:00

pending_input.rs

Remove core MCP list tools op (#21281)

2026-05-06 11:20:34 -07:00

permissions_messages.rs

[codex-analytics] rework thread_source for thread analytics (#20949)

2026-05-06 02:12:31 +00:00

personality_migration.rs

Revert state DB injection and agent graph store (#21481)

2026-05-06 22:48:29 -07:00

personality.rs

1- Add model service tiers metadata (#20969)

2026-05-05 09:51:18 +03:00

plugins.rs

Remove core MCP list tools op (#21281)

2026-05-06 11:20:34 -07:00

prompt_caching.rs

Avoid hard-coded environment context shell (#21390)

2026-05-06 19:54:26 +00:00

prompt_debug_tests.rs

Revert state DB injection and agent graph store (#21481)

2026-05-06 22:48:29 -07:00

quota_exceeded.rs

Add turn-scoped environment selections (#18416)

2026-04-21 17:48:33 -07:00

realtime_conversation.rs

Reapply "Move skills watcher to app-server" (#21652)

2026-05-08 17:41:15 -07:00

remote_env.rs

Route process tools to selected environments (#20647)

2026-05-05 12:12:03 -07:00

remote_models.rs

1- Add model service tiers metadata (#20969)

2026-05-05 09:51:18 +03:00

request_compression.rs

Add turn-scoped environment selections (#18416)

2026-04-21 17:48:33 -07:00

request_permissions_tool.rs

[codex] Delete function-style apply_patch (#21651)

2026-05-08 13:00:57 -07:00

request_permissions.rs

permissions: store only constrained permission profiles (#19735)

2026-04-26 20:59:58 -07:00

request_plugin_install.rs

[tool_suggest] More prompt polishes. (#20566)

2026-05-02 04:22:12 +00:00

request_user_input.rs

core tests: build user turns from permission profiles (#20011)

2026-04-28 17:03:20 -07:00

responses_api_proxy_headers.rs

core tests: send model turns with permission profiles (#20016)

2026-04-28 17:08:04 -07:00

resume_warning.rs

Revert state DB injection and agent graph store (#21481)

2026-05-06 22:48:29 -07:00

resume.rs

app-server: accept permission profile overrides (#18279)

2026-04-22 13:34:33 -07:00

review.rs

[codex] Remove unused event messages (#20511)

2026-04-30 20:03:26 -07:00

rmcp_client.rs

Remove core MCP list tools op (#21281)

2026-05-06 11:20:34 -07:00

rollout_list_find.rs

[codex-analytics] rework thread_source for thread analytics (#20949)

2026-05-06 02:12:31 +00:00

safety_check_downgrade.rs

core tests: migrate safety check turns to profiles (#20024)

2026-04-28 17:10:42 -07:00

search_tool.rs

feat: include thread ID in MCP turn metadata (#21329)

2026-05-06 11:36:15 +02:00

shell_command.rs

Update models.json (#18586)

2026-04-20 10:27:01 -07:00

shell_serialization.rs

[codex] Delete function-style apply_patch (#21651)

2026-05-08 13:00:57 -07:00

shell_snapshot.rs

core tests: migrate more turns to permission profiles (#20013)

2026-04-28 17:05:53 -07:00

skill_approval.rs

core tests: migrate zsh-fork permissions to profiles (#20034)

2026-04-28 17:15:58 -07:00

skills.rs

[codex] Remove legacy ListSkills op (#21282)

2026-05-05 18:58:18 -07:00

spawn_agent_description.rs

1- Add model service tiers metadata (#20969)

2026-05-05 09:51:18 +03:00

sqlite_state.rs

feat: make built-in MCPs first-class runtime servers (#21356)

2026-05-07 10:36:32 +02:00

stream_error_allows_next_turn.rs

Add turn-scoped environment selections (#18416)

2026-04-21 17:48:33 -07:00

stream_no_completed.rs

Add turn-scoped environment selections (#18416)

2026-04-21 17:48:33 -07:00

subagent_notifications.rs

feat: add session_id (#20437)

2026-05-06 10:48:37 +02:00

tool_harness.rs

[codex] Delete function-style apply_patch (#21651)

2026-05-08 13:00:57 -07:00

tool_parallelism.rs

core tests: build user turns from permission profiles (#20011)

2026-04-28 17:03:20 -07:00

tools.rs

[codex] Delete function-style apply_patch (#21651)

2026-05-08 13:00:57 -07:00

truncation.rs

core tests: submit turns with permission profiles (#20010)

2026-04-28 23:01:40 +00:00

turn_state.rs

Stabilize websocket response.failed error delivery (#14017)

2026-03-11 12:33:09 -07:00

unified_exec.rs

fix: handle deferred network proxy denials (#19184)

2026-04-29 19:13:57 +00:00

unstable_features_warning.rs

Revert state DB injection and agent graph store (#21481)

2026-05-06 22:48:29 -07:00

user_notification.rs

Add turn-scoped environment selections (#18416)

2026-04-21 17:48:33 -07:00

user_shell_cmd.rs

core tests: configure profiles directly (#20015)

2026-04-28 17:06:59 -07:00

view_image.rs

Route view_image through selected environments

2026-05-08 01:29:03 +00:00

web_search.rs

core tests: submit turns with permission profiles (#20010)

2026-04-28 23:01:40 +00:00

websocket_fallback.rs

core tests: build user turns from permission profiles (#20011)

2026-04-28 17:03:20 -07:00

window_headers.rs

[codex-analytics] rework thread_source for thread analytics (#20949)

2026-05-06 02:12:31 +00:00