mirror of
https://github.com/openai/codex.git
synced 2026-05-28 15:00:16 +00:00
## Why `/fast` was wired as a one-off slash command even though model metadata now exposes service tiers as catalog data. That meant adding another tier, such as a slower/cheaper tier, would require more hardcoded TUI plumbing instead of letting the model catalog drive the available commands. This change makes service-tier commands data-driven: each advertised `service_tiers` entry becomes a `/name` command using the catalog description, while the request path sends the tier `id` only when the selected model supports it. ## What Changed - Removed the hardcoded `/fast` slash-command variant and introduced dynamic service-tier command items in the composer and command popup. - Added toggle behavior for service-tier commands: invoking `/name` selects that tier, and invoking it again clears the selection. - Preserved the existing Fast-mode keybinding/status affordances by resolving the current model tier whose name is `fast`, while still sending the tier request value such as `priority`. - Persisted service-tier selections as raw request strings so non-fast tiers can round-trip through config. - Updated the Bedrock catalog entry to advertise fast support through `service_tiers` with `id: "priority"` and `name: "fast"`. - Added defensive filtering in core so unsupported selected service tiers are omitted from `/responses` requests. ## Validation - Added/updated coverage for dynamic service-tier slash command lookup, popup descriptions, composer dispatch, TUI fast toggling, and unsupported-tier omission in core request construction. - Local tests were not run per request. --------- Co-authored-by: Codex <noreply@openai.com>
284 lines
10 KiB
Rust
284 lines
10 KiB
Rust
use strum::IntoEnumIterator;
|
|
use strum_macros::AsRefStr;
|
|
use strum_macros::EnumIter;
|
|
use strum_macros::EnumString;
|
|
use strum_macros::IntoStaticStr;
|
|
|
|
/// Commands that can be invoked by starting a message with a leading slash.
|
|
#[derive(
|
|
Debug, Clone, Copy, PartialEq, Eq, Hash, EnumString, EnumIter, AsRefStr, IntoStaticStr,
|
|
)]
|
|
#[strum(serialize_all = "kebab-case")]
|
|
pub enum SlashCommand {
|
|
// DO NOT ALPHA-SORT! Enum order is presentation order in the popup, so
|
|
// more frequently used commands should be listed first.
|
|
Model,
|
|
Ide,
|
|
Permissions,
|
|
Keymap,
|
|
Vim,
|
|
#[strum(serialize = "setup-default-sandbox")]
|
|
ElevateSandbox,
|
|
#[strum(serialize = "sandbox-add-read-dir")]
|
|
SandboxReadRoot,
|
|
Experimental,
|
|
#[strum(to_string = "approve")]
|
|
AutoReview,
|
|
Memories,
|
|
Skills,
|
|
Hooks,
|
|
Review,
|
|
Rename,
|
|
New,
|
|
Resume,
|
|
Fork,
|
|
Init,
|
|
Compact,
|
|
Plan,
|
|
Goal,
|
|
Collab,
|
|
Agent,
|
|
Side,
|
|
Copy,
|
|
Raw,
|
|
Diff,
|
|
Mention,
|
|
Status,
|
|
DebugConfig,
|
|
Title,
|
|
Statusline,
|
|
Theme,
|
|
Mcp,
|
|
Apps,
|
|
Plugins,
|
|
Logout,
|
|
Quit,
|
|
Exit,
|
|
Feedback,
|
|
Rollout,
|
|
Ps,
|
|
#[strum(to_string = "stop", serialize = "clean")]
|
|
Stop,
|
|
Clear,
|
|
Personality,
|
|
Realtime,
|
|
Settings,
|
|
TestApproval,
|
|
#[strum(serialize = "subagents")]
|
|
MultiAgents,
|
|
// Debugging commands.
|
|
#[strum(serialize = "debug-m-drop")]
|
|
MemoryDrop,
|
|
#[strum(serialize = "debug-m-update")]
|
|
MemoryUpdate,
|
|
}
|
|
|
|
impl SlashCommand {
|
|
/// User-visible description shown in the popup.
|
|
pub fn description(self) -> &'static str {
|
|
match self {
|
|
SlashCommand::Feedback => "send logs to maintainers",
|
|
SlashCommand::New => "start a new chat during a conversation",
|
|
SlashCommand::Init => "create an AGENTS.md file with instructions for Codex",
|
|
SlashCommand::Compact => "summarize conversation to prevent hitting the context limit",
|
|
SlashCommand::Review => "review my current changes and find issues",
|
|
SlashCommand::Rename => "rename the current thread",
|
|
SlashCommand::Resume => "resume a saved chat",
|
|
SlashCommand::Clear => "clear the terminal and start a new chat",
|
|
SlashCommand::Fork => "fork the current chat",
|
|
SlashCommand::Quit | SlashCommand::Exit => "exit Codex",
|
|
SlashCommand::Copy => "copy last response as markdown",
|
|
SlashCommand::Raw => "toggle raw scrollback mode for copy-friendly terminal selection",
|
|
SlashCommand::Diff => "show git diff (including untracked files)",
|
|
SlashCommand::Mention => "mention a file",
|
|
SlashCommand::Skills => "use skills to improve how Codex performs specific tasks",
|
|
SlashCommand::Hooks => "view and manage lifecycle hooks",
|
|
SlashCommand::Status => "show current session configuration and token usage",
|
|
SlashCommand::DebugConfig => "show config layers and requirement sources for debugging",
|
|
SlashCommand::Title => "configure which items appear in the terminal title",
|
|
SlashCommand::Statusline => "configure which items appear in the status line",
|
|
SlashCommand::Theme => "choose a syntax highlighting theme",
|
|
SlashCommand::Ps => "list background terminals",
|
|
SlashCommand::Stop => "stop all background terminals",
|
|
SlashCommand::MemoryDrop => "DO NOT USE",
|
|
SlashCommand::MemoryUpdate => "DO NOT USE",
|
|
SlashCommand::Model => "choose what model and reasoning effort to use",
|
|
SlashCommand::Ide => {
|
|
"include current selection, open files, and other context from your IDE"
|
|
}
|
|
SlashCommand::Personality => "choose a communication style for Codex",
|
|
SlashCommand::Realtime => "toggle realtime voice mode (experimental)",
|
|
SlashCommand::Settings => "configure realtime microphone/speaker",
|
|
SlashCommand::Plan => "switch to Plan mode",
|
|
SlashCommand::Goal => "set or view the goal for a long-running task",
|
|
SlashCommand::Collab => "change collaboration mode (experimental)",
|
|
SlashCommand::Agent | SlashCommand::MultiAgents => "switch the active agent thread",
|
|
SlashCommand::Side => "start a side conversation in an ephemeral fork",
|
|
SlashCommand::Permissions => "choose what Codex is allowed to do",
|
|
SlashCommand::Keymap => "remap TUI shortcuts",
|
|
SlashCommand::Vim => "toggle Vim mode for the composer",
|
|
SlashCommand::ElevateSandbox => "set up elevated agent sandbox",
|
|
SlashCommand::SandboxReadRoot => {
|
|
"let sandbox read a directory: /sandbox-add-read-dir <absolute_path>"
|
|
}
|
|
SlashCommand::Experimental => "toggle experimental features",
|
|
SlashCommand::AutoReview => "approve one retry of a recent auto-review denial",
|
|
SlashCommand::Memories => "configure memory use and generation",
|
|
SlashCommand::Mcp => "list configured MCP tools; use /mcp verbose for details",
|
|
SlashCommand::Apps => "manage apps",
|
|
SlashCommand::Plugins => "browse plugins",
|
|
SlashCommand::Logout => "log out of Codex",
|
|
SlashCommand::Rollout => "print the rollout file path",
|
|
SlashCommand::TestApproval => "test approval request",
|
|
}
|
|
}
|
|
|
|
/// Command string without the leading '/'. Provided for compatibility with
|
|
/// existing code that expects a method named `command()`.
|
|
pub fn command(self) -> &'static str {
|
|
self.into()
|
|
}
|
|
|
|
/// Whether this command supports inline args (for example `/review ...`).
|
|
pub fn supports_inline_args(self) -> bool {
|
|
matches!(
|
|
self,
|
|
SlashCommand::Review
|
|
| SlashCommand::Rename
|
|
| SlashCommand::Plan
|
|
| SlashCommand::Goal
|
|
| SlashCommand::Ide
|
|
| SlashCommand::Keymap
|
|
| SlashCommand::Mcp
|
|
| SlashCommand::Raw
|
|
| SlashCommand::Side
|
|
| SlashCommand::Resume
|
|
| SlashCommand::SandboxReadRoot
|
|
)
|
|
}
|
|
|
|
/// Whether this command remains available inside an active side conversation.
|
|
pub fn available_in_side_conversation(self) -> bool {
|
|
matches!(
|
|
self,
|
|
SlashCommand::Copy
|
|
| SlashCommand::Raw
|
|
| SlashCommand::Diff
|
|
| SlashCommand::Mention
|
|
| SlashCommand::Status
|
|
| SlashCommand::Ide
|
|
)
|
|
}
|
|
|
|
/// Whether this command can be run while a task is in progress.
|
|
pub fn available_during_task(self) -> bool {
|
|
match self {
|
|
SlashCommand::New
|
|
| SlashCommand::Resume
|
|
| SlashCommand::Fork
|
|
| SlashCommand::Init
|
|
| SlashCommand::Compact
|
|
| SlashCommand::Model
|
|
| SlashCommand::Personality
|
|
| SlashCommand::Permissions
|
|
| SlashCommand::Keymap
|
|
| SlashCommand::Vim
|
|
| SlashCommand::ElevateSandbox
|
|
| SlashCommand::SandboxReadRoot
|
|
| SlashCommand::Experimental
|
|
| SlashCommand::Memories
|
|
| SlashCommand::Review
|
|
| SlashCommand::Plan
|
|
| SlashCommand::Clear
|
|
| SlashCommand::Logout
|
|
| SlashCommand::MemoryDrop
|
|
| SlashCommand::MemoryUpdate => false,
|
|
SlashCommand::Diff
|
|
| SlashCommand::Copy
|
|
| SlashCommand::Raw
|
|
| SlashCommand::Rename
|
|
| SlashCommand::Mention
|
|
| SlashCommand::Skills
|
|
| SlashCommand::Hooks
|
|
| SlashCommand::Status
|
|
| SlashCommand::DebugConfig
|
|
| SlashCommand::Ps
|
|
| SlashCommand::Stop
|
|
| SlashCommand::Goal
|
|
| SlashCommand::Mcp
|
|
| SlashCommand::Apps
|
|
| SlashCommand::Plugins
|
|
| SlashCommand::Title
|
|
| SlashCommand::Statusline
|
|
| SlashCommand::AutoReview
|
|
| SlashCommand::Feedback
|
|
| SlashCommand::Ide
|
|
| SlashCommand::Quit
|
|
| SlashCommand::Exit
|
|
| SlashCommand::Side => true,
|
|
SlashCommand::Rollout => true,
|
|
SlashCommand::TestApproval => true,
|
|
SlashCommand::Realtime => true,
|
|
SlashCommand::Settings => true,
|
|
SlashCommand::Collab => true,
|
|
SlashCommand::Agent | SlashCommand::MultiAgents => true,
|
|
SlashCommand::Theme => false,
|
|
}
|
|
}
|
|
|
|
fn is_visible(self) -> bool {
|
|
match self {
|
|
SlashCommand::SandboxReadRoot => cfg!(target_os = "windows"),
|
|
SlashCommand::Copy => !cfg!(target_os = "android"),
|
|
SlashCommand::Rollout | SlashCommand::TestApproval => cfg!(debug_assertions),
|
|
_ => true,
|
|
}
|
|
}
|
|
}
|
|
|
|
/// Return all built-in commands in a Vec paired with their command string.
|
|
pub fn built_in_slash_commands() -> Vec<(&'static str, SlashCommand)> {
|
|
SlashCommand::iter()
|
|
.filter(|command| command.is_visible())
|
|
.map(|c| (c.command(), c))
|
|
.collect()
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use pretty_assertions::assert_eq;
|
|
use std::str::FromStr;
|
|
|
|
use super::SlashCommand;
|
|
|
|
#[test]
|
|
fn stop_command_is_canonical_name() {
|
|
assert_eq!(SlashCommand::Stop.command(), "stop");
|
|
}
|
|
|
|
#[test]
|
|
fn clean_alias_parses_to_stop_command() {
|
|
assert_eq!(SlashCommand::from_str("clean"), Ok(SlashCommand::Stop));
|
|
}
|
|
|
|
#[test]
|
|
fn certain_commands_are_available_during_task() {
|
|
assert!(SlashCommand::Goal.available_during_task());
|
|
assert!(SlashCommand::Ide.available_during_task());
|
|
assert!(SlashCommand::Title.available_during_task());
|
|
assert!(SlashCommand::Statusline.available_during_task());
|
|
assert!(SlashCommand::Raw.available_during_task());
|
|
assert!(SlashCommand::Raw.available_in_side_conversation());
|
|
assert!(SlashCommand::Raw.supports_inline_args());
|
|
}
|
|
|
|
#[test]
|
|
fn auto_review_command_is_approve() {
|
|
assert_eq!(SlashCommand::AutoReview.command(), "approve");
|
|
assert_eq!(
|
|
SlashCommand::from_str("approve"),
|
|
Ok(SlashCommand::AutoReview)
|
|
);
|
|
}
|
|
}
|