mirror of
https://github.com/openai/codex.git
synced 2026-05-01 01:47:18 +00:00
18a26d7bbc
## Why `PermissionProfile` is becoming the canonical permissions shape shared by core and app-server. After app-server responses expose the active profile, clients need to be able to send that same shape back when starting, resuming, forking, or overriding a turn instead of translating through the legacy `sandbox`/`sandboxPolicy` shorthands. This still needs to preserve the existing requirements/platform enforcement model. A profile-shaped request can be downgraded or rejected by constraints, but the server should keep the user's elevated-access intent for project trust decisions. Turn-level profile overrides also need to retain existing read protections, including deny-read entries and bounded glob-scan metadata, so a permission override cannot accidentally drop configured protections such as `**/*.env = deny`. ## What changed - Adds optional `permissionProfile` request fields to `thread/start`, `thread/resume`, `thread/fork`, and `turn/start`. - Rejects ambiguous requests that specify both `permissionProfile` and the legacy `sandbox`/`sandboxPolicy` fields, including running-thread resume requests. - Converts profile-shaped overrides into core runtime filesystem/network permissions while continuing to derive the constrained legacy sandbox projection used by existing execution paths. - Preserves project-trust intent for profile overrides that are equivalent to workspace-write or full-access sandbox requests. - Preserves existing deny-read entries and `globScanMaxDepth` when applying turn-level `permissionProfile` overrides. - Updates app-server docs plus generated JSON/TypeScript schema fixtures and regression coverage. ## Verification - `cargo test -p codex-app-server-protocol schema_fixtures` - `cargo test -p codex-core session_configuration_apply_permission_profile_preserves_existing_deny_read_entries` --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/openai/codex/pull/18279). * #18288 * #18287 * #18286 * #18285 * #18284 * #18283 * #18282 * #18281 * #18280 * __->__ #18279
92 lines
3.1 KiB
Rust
92 lines
3.1 KiB
Rust
use codex_protocol::openai_models::ReasoningEffort;
|
|
use codex_protocol::protocol::EventMsg;
|
|
use codex_protocol::protocol::Op;
|
|
use core_test_support::responses::start_mock_server;
|
|
use core_test_support::test_codex::test_codex;
|
|
use core_test_support::wait_for_event;
|
|
use pretty_assertions::assert_eq;
|
|
|
|
const CONFIG_TOML: &str = "config.toml";
|
|
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn override_turn_context_does_not_persist_when_config_exists() {
|
|
let server = start_mock_server().await;
|
|
let initial_contents = "model = \"gpt-4o\"\n";
|
|
let mut builder = test_codex()
|
|
.with_pre_build_hook(move |home| {
|
|
let config_path = home.join(CONFIG_TOML);
|
|
std::fs::write(config_path, initial_contents).expect("seed config.toml");
|
|
})
|
|
.with_config(|config| {
|
|
config.model = Some("gpt-4o".to_string());
|
|
});
|
|
let test = builder.build(&server).await.expect("create conversation");
|
|
let codex = test.codex.clone();
|
|
let config_path = test.home.path().join(CONFIG_TOML);
|
|
|
|
codex
|
|
.submit(Op::OverrideTurnContext {
|
|
cwd: None,
|
|
approval_policy: None,
|
|
approvals_reviewer: None,
|
|
sandbox_policy: None,
|
|
permission_profile: None,
|
|
windows_sandbox_level: None,
|
|
model: Some("o3".to_string()),
|
|
effort: Some(Some(ReasoningEffort::High)),
|
|
summary: None,
|
|
service_tier: None,
|
|
collaboration_mode: None,
|
|
personality: None,
|
|
})
|
|
.await
|
|
.expect("submit override");
|
|
|
|
codex.submit(Op::Shutdown).await.expect("request shutdown");
|
|
wait_for_event(&codex, |ev| matches!(ev, EventMsg::ShutdownComplete)).await;
|
|
|
|
let contents = tokio::fs::read_to_string(&config_path)
|
|
.await
|
|
.expect("read config.toml after override");
|
|
assert_eq!(contents, initial_contents);
|
|
}
|
|
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn override_turn_context_does_not_create_config_file() {
|
|
let server = start_mock_server().await;
|
|
let mut builder = test_codex();
|
|
let test = builder.build(&server).await.expect("create conversation");
|
|
let codex = test.codex.clone();
|
|
let config_path = test.home.path().join(CONFIG_TOML);
|
|
assert!(
|
|
!config_path.exists(),
|
|
"test setup should start without config"
|
|
);
|
|
|
|
codex
|
|
.submit(Op::OverrideTurnContext {
|
|
cwd: None,
|
|
approval_policy: None,
|
|
approvals_reviewer: None,
|
|
sandbox_policy: None,
|
|
permission_profile: None,
|
|
windows_sandbox_level: None,
|
|
model: Some("o3".to_string()),
|
|
effort: Some(Some(ReasoningEffort::Medium)),
|
|
summary: None,
|
|
service_tier: None,
|
|
collaboration_mode: None,
|
|
personality: None,
|
|
})
|
|
.await
|
|
.expect("submit override");
|
|
|
|
codex.submit(Op::Shutdown).await.expect("request shutdown");
|
|
wait_for_event(&codex, |ev| matches!(ev, EventMsg::ShutdownComplete)).await;
|
|
|
|
assert!(
|
|
!config_path.exists(),
|
|
"override should not create config.toml"
|
|
);
|
|
}
|