mirror of
https://github.com/openai/codex.git
synced 2026-04-30 17:36:40 +00:00
96d35dd640
## Why The large Rust test suites are slow and include some of our flakiest tests, so we want to run them with Bazel native sharding while keeping shard membership stable between runs. This is the simpler follow-up to the explicit-label experiment in #17998. Since #18397 upgraded Codex to `rules_rs` `0.0.58`, which includes the stable test-name hashing support from hermeticbuild/rules_rust#14, this PR only needs to wire Codex's Bazel macros into that support. Using native sharding preserves BuildBuddy's sharded-test UI and Bazel's per-shard test action caching. Using stable name hashing avoids reshuffling every test when one test is added or removed. ## What Changed `codex_rust_crate` now accepts `test_shard_counts` and applies the right Bazel/rules_rust attributes to generated unit and integration test rules. Matched tests are also marked `flaky = True`, giving them Bazel's default three attempts. This PR shards these labels 8 ways: ```text //codex-rs/core:core-all-test //codex-rs/core:core-unit-tests //codex-rs/app-server:app-server-all-test //codex-rs/app-server:app-server-unit-tests //codex-rs/tui:tui-unit-tests ``` ## Verification `bazel query --output=build` over the selected public labels and their inner unit-test binaries confirmed the expected `shard_count = 8`, `flaky = True`, and `experimental_enable_sharding = True` attributes. Also verified that we see the shards as expected in BuildBuddy so they can be analyzed independently. Co-authored-by: Codex <noreply@openai.com>
31 lines
871 B
Python
31 lines
871 B
Python
load("//:defs.bzl", "MACOS_WEBRTC_RUSTC_LINK_FLAGS", "codex_rust_crate")
|
|
|
|
codex_rust_crate(
|
|
name = "tui",
|
|
crate_name = "codex_tui",
|
|
compile_data = glob(
|
|
include = ["**"],
|
|
exclude = [
|
|
"**/* *",
|
|
"BUILD.bazel",
|
|
"Cargo.toml",
|
|
],
|
|
allow_empty = True,
|
|
) + [
|
|
"//codex-rs/collaboration-mode-templates:templates/default.md",
|
|
"//codex-rs/collaboration-mode-templates:templates/plan.md",
|
|
],
|
|
test_data_extra = glob([
|
|
"src/**/*.rs",
|
|
"src/**/snapshots/**",
|
|
]) + ["//codex-rs/core:model_availability_nux_fixtures"],
|
|
integration_compile_data_extra = ["src/test_backend.rs"],
|
|
extra_binaries = [
|
|
"//codex-rs/cli:codex",
|
|
],
|
|
rustc_flags_extra = MACOS_WEBRTC_RUSTC_LINK_FLAGS,
|
|
test_shard_counts = {
|
|
"tui-unit-tests": 8,
|
|
},
|
|
)
|