codex/prs/bolinfest/PR-2466.md

PR #2466: fix: prefer cargo check to cargo build to save time and space

• URL: https://github.com/openai/codex/pull/2466
• Author: bolinfest
• Created: 2025-08-19 19:47:58 UTC
• Updated: 2025-08-19 19:57:38 UTC
• Changes: +7/-7, Files changed: 1, Commits: 1

Description

The ubuntu-24.04 - x86_64-unknown-linux-gnu build is failing with No space left on device on #2465, so let's get this in first, which should help.

Note that cargo check should be faster and use less disk than cargo build because it does not write out the object files.

Full Diff

diff --git a/.github/workflows/rust-ci.yml b/.github/workflows/rust-ci.yml
index 29733a46f6..fca1a02288 100644
--- a/.github/workflows/rust-ci.yml
+++ b/.github/workflows/rust-ci.yml
@@ -130,7 +130,7 @@ jobs:
       - if: ${{ matrix.target == 'x86_64-unknown-linux-musl' || matrix.target == 'aarch64-unknown-linux-musl'}}
         name: Install musl build tools
         run: |
-          sudo apt install -y musl-tools pkg-config
+          sudo apt install -y musl-tools pkg-config && sudo rm -rf /var/lib/apt/lists/*
 
       - name: cargo clippy
         id: clippy
@@ -139,15 +139,15 @@ jobs:
       # Running `cargo build` from the workspace root builds the workspace using
       # the union of all features from third-party crates. This can mask errors
       # where individual crates have underspecified features. To avoid this, we
-      # run `cargo build` for each crate individually, though because this is
+      # run `cargo check` for each crate individually, though because this is
       # slower, we only do this for the x86_64-unknown-linux-gnu target.
-      - name: cargo build individual crates
-        id: build
+      - name: cargo check individual crates
+        id: cargo_check_all_crates
         if: ${{ matrix.target == 'x86_64-unknown-linux-gnu' && matrix.profile != 'release' }}
         continue-on-error: true
         run: |
           find . -name Cargo.toml -mindepth 2 -maxdepth 2 -print0 \
-            | xargs -0 -n1 -I{} bash -c 'cd "$(dirname "{}")" && cargo build --profile ${{ matrix.profile }}'
+            | xargs -0 -n1 -I{} bash -c 'cd "$(dirname "{}")" && cargo check --profile ${{ matrix.profile }}'
 
       - name: cargo test
         id: test
@@ -162,10 +162,10 @@ jobs:
       - name: verify all steps passed
         if: |
           steps.clippy.outcome == 'failure' ||
-          steps.build.outcome == 'failure' ||
+          steps.cargo_check_all_crates.outcome == 'failure' ||
           steps.test.outcome == 'failure'
         run: |
-          echo "One or more checks failed (clippy, build, or test). See logs for details."
+          echo "One or more checks failed (clippy, cargo_check_all_crates, or test). See logs for details."
           exit 1
 
   # --- Gatherer job that you mark as the ONLY required status -----------------

Review Comments

.github/workflows/rust-ci.yml

• Created: 2025-08-19 19:57:20 UTC | Link: https://github.com/openai/codex/pull/2466#discussion_r2286198998

@@ -139,15 +139,15 @@ jobs:
       # Running `cargo build` from the workspace root builds the workspace using

The comment is correct as is: it is still the case that "Running cargo build from the workspace root builds the workspace using the union of all features from third-party crates."