mirror of https://github.com/openai/codex.git synced 2026-04-26 07:35:29 +00:00

Files

Michael Bolin 9a8730f31e ci: verify codex-rs Cargo manifests inherit workspace settings (#16353 )

## Why

Bazel clippy now catches lints that `cargo clippy` can still miss when a
crate under `codex-rs` forgets to opt into workspace lints. The concrete
example here was `codex-rs/app-server/tests/common/Cargo.toml`: Bazel
flagged a clippy violation in `models_cache.rs`, but Cargo did not
because that crate inherited workspace package metadata without
declaring `[lints] workspace = true`.

We already mirror the workspace clippy deny list into Bazel after
[#15955](https://github.com/openai/codex/pull/15955), so we also need a
repo-side check that keeps every `codex-rs` manifest opted into the same
workspace settings.

## What changed

- add `.github/scripts/verify_cargo_workspace_manifests.py`, which
parses every `codex-rs/**/Cargo.toml` with `tomllib` and verifies:
  - `version.workspace = true`
  - `edition.workspace = true`
  - `license.workspace = true`
  - `[lints] workspace = true`
- top-level crate names follow the `codex-*` / `codex-utils-*`
conventions, with explicit exceptions for `windows-sandbox-rs` and
`utils/path-utils`
- run that script in `.github/workflows/ci.yml`
- update the current outlier manifests so the check is enforceable
immediately
- fix the newly exposed clippy violations in the affected crates
(`app-server/tests/common`, `file-search`, `feedback`,
`shell-escalation`, and `debug-client`)






---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/openai/codex/pull/16353).
* #16351
* __->__ #16353

2026-03-31 21:59:28 +00:00

src

ci: verify codex-rs Cargo manifests inherit workspace settings (#16353 )

2026-03-31 21:59:28 +00:00

Cargo.toml

ci: verify codex-rs Cargo manifests inherit workspace settings (#16353 )

2026-03-31 21:59:28 +00:00

README.md

chore(core) Deprecate approval_policy: on-failure (#11631 )

2026-02-12 13:23:30 -08:00

README.md

WARNING: this code is mainly generated by Codex and should not be used in production

codex-debug-client

A tiny interactive client for codex app-server (protocol v2 only). It prints all JSON-RPC lines from the server and lets you send new turns as you type.

Usage

Start the app-server client (it will spawn codex app-server itself):

cargo run -p codex-debug-client -- \
  --codex-bin codex \
  --approval-policy on-request

You can resume a specific thread:

cargo run -p codex-debug-client -- --thread-id thr_123

CLI flags

--codex-bin <path>: path to the codex binary (default: codex).
-c, --config key=value: pass through --config overrides to codex.
--thread-id <id>: resume a thread instead of starting a new one.
--approval-policy <policy>: untrusted, on-failure (deprecated), on-request, never.
--auto-approve: auto-approve command/file-change approvals (default: decline).
--final-only: only show completed assistant messages and tool items.
--model <name>: optional model override for thread start/resume.
--model-provider <name>: optional provider override.
--cwd <path>: optional working directory override.

Interactive commands

Type a line to send it as a new turn. Commands are prefixed with ::

:help show help
:new start a new thread
:resume <thread-id> resume a thread
:use <thread-id> switch active thread without resuming
:refresh-thread list available threads
:quit exit

The prompt shows the active thread id. Client messages (help, errors, approvals) print to stderr; raw server JSON prints to stdout so you can pipe/record it unless --final-only is set.

Notes

The client performs the required initialize/initialized handshake.
It prints every server notification and response line as it arrives.
Approvals for item/commandExecution/requestApproval and item/fileChange/requestApproval are auto-responded to with decline unless --auto-approve is set.