mirror of https://github.com/openai/codex.git synced 2026-04-24 14:45:27 +00:00

Files

Michael Bolin f263607c60 bazel: lint rust_test targets in clippy workflow (#16450 )

## Why

`cargo clippy --tests` was catching warnings in inline `#[cfg(test)]`
code that the Bazel PR Clippy lane missed. The existing Bazel invocation
linted `//codex-rs/...`, but that did not apply Clippy to the generated
manual `rust_test` binaries, so warnings in targets such as
`//codex-rs/state:state-unit-tests-bin` only surfaced as plain compile
warnings instead of failing the lint job.

## What Changed

- added `scripts/list-bazel-clippy-targets.sh` to expand the Bazel
Clippy target set with the generated manual `rust_test` rules while
still excluding `//codex-rs/v8-poc:all`
- updated `.github/workflows/bazel.yml` to use that expanded target list
in the Bazel Clippy PR job
- updated `just bazel-clippy` to use the same target expansion locally
- updated `.github/workflows/README.md` to document that the Bazel PR
lint lane now covers inline `#[cfg(test)]` code

## Verification

- `./scripts/list-bazel-clippy-targets.sh` includes
`//codex-rs/state:state-unit-tests-bin`
- `bazel build --config=clippy -- //codex-rs/state:state-unit-tests-bin`
now fails with the same unused import in `state/src/runtime/logs.rs`
that `cargo clippy --tests` reports

2026-04-03 22:44:53 +00:00

1.5 KiB

Raw Blame History

Workflow Strategy

The workflows in this directory are split so that pull requests get fast, review-friendly signal while main still gets the full cross-platform verification pass.

Pull Requests

bazel.yml is the main pre-merge verification path for Rust code. It runs Bazel test and Bazel clippy on the supported Bazel targets, including the generated Rust test binaries needed to lint inline #[cfg(test)] code.
rust-ci.yml keeps the Cargo-native PR checks intentionally small:
- cargo fmt --check
- cargo shear
- argument-comment-lint on Linux, macOS, and Windows
- tools/argument-comment-lint package tests when the lint or its workflow wiring changes

Post-Merge On `main`

bazel.yml also runs on pushes to main. This re-verifies the merged Bazel path and helps keep the BuildBuddy caches warm.
rust-ci-full.yml is the full Cargo-native verification workflow. It keeps the heavier checks off the PR path while still validating them after merge:
- the full Cargo clippy matrix
- the full Cargo nextest matrix
- release-profile Cargo builds
- cross-platform argument-comment-lint
- Linux remote-env tests

Rule Of Thumb

If a build/test/clippy check can be expressed in Bazel, prefer putting the PR-time version in bazel.yml.
Keep rust-ci.yml fast enough that it usually does not dominate PR latency.
Reserve rust-ci-full.yml for heavyweight Cargo-native coverage that Bazel does not replace yet.

1.5 KiB Raw Blame History

Workflow Strategy

Pull Requests

Post-Merge On main

Rule Of Thumb

1.5 KiB

Raw Blame History

Post-Merge On `main`