mirror of
https://github.com/openai/codex.git
synced 2026-05-15 16:53:05 +00:00
## Why PR #13783 moved the `codex.rs` unit tests into `codex_tests.rs`. This applies the same extraction pattern across the rest of `codex-rs/core` so the production modules stay focused on runtime code instead of large inline test blocks. Keeping the tests in sibling files also makes follow-up edits easier to review because product changes no longer have to share a file with hundreds or thousands of lines of test scaffolding. ## What changed - replaced each inline `mod tests { ... }` in `codex-rs/core/src/**` with a path-based module declaration - moved each extracted unit test module into a sibling `*_tests.rs` file, using `mod_tests.rs` for `mod.rs` modules - preserved the existing `cfg(...)` guards and module-local structure so the refactor remains structural rather than behavioral ## Testing - `cargo test -p codex-core --lib` (`1653 passed; 0 failed; 5 ignored`) - `just fix -p codex-core` - `cargo fmt --check` - `cargo shear`
60 lines
1.7 KiB
Rust
60 lines
1.7 KiB
Rust
use std::time::Duration;
|
|
|
|
use codex_protocol::models::ResponseItem;
|
|
|
|
use crate::codex::TurnContext;
|
|
use crate::contextual_user_message::USER_SHELL_COMMAND_FRAGMENT;
|
|
use crate::exec::ExecToolCallOutput;
|
|
use crate::tools::format_exec_output_str;
|
|
|
|
fn format_duration_line(duration: Duration) -> String {
|
|
let duration_seconds = duration.as_secs_f64();
|
|
format!("Duration: {duration_seconds:.4} seconds")
|
|
}
|
|
|
|
fn format_user_shell_command_body(
|
|
command: &str,
|
|
exec_output: &ExecToolCallOutput,
|
|
turn_context: &TurnContext,
|
|
) -> String {
|
|
let mut sections = Vec::new();
|
|
sections.push("<command>".to_string());
|
|
sections.push(command.to_string());
|
|
sections.push("</command>".to_string());
|
|
sections.push("<result>".to_string());
|
|
sections.push(format!("Exit code: {}", exec_output.exit_code));
|
|
sections.push(format_duration_line(exec_output.duration));
|
|
sections.push("Output:".to_string());
|
|
sections.push(format_exec_output_str(
|
|
exec_output,
|
|
turn_context.truncation_policy,
|
|
));
|
|
sections.push("</result>".to_string());
|
|
sections.join("\n")
|
|
}
|
|
|
|
pub fn format_user_shell_command_record(
|
|
command: &str,
|
|
exec_output: &ExecToolCallOutput,
|
|
turn_context: &TurnContext,
|
|
) -> String {
|
|
let body = format_user_shell_command_body(command, exec_output, turn_context);
|
|
USER_SHELL_COMMAND_FRAGMENT.wrap(body)
|
|
}
|
|
|
|
pub fn user_shell_command_record_item(
|
|
command: &str,
|
|
exec_output: &ExecToolCallOutput,
|
|
turn_context: &TurnContext,
|
|
) -> ResponseItem {
|
|
USER_SHELL_COMMAND_FRAGMENT.into_message(format_user_shell_command_record(
|
|
command,
|
|
exec_output,
|
|
turn_context,
|
|
))
|
|
}
|
|
|
|
#[cfg(test)]
|
|
#[path = "user_shell_command_tests.rs"]
|
|
mod tests;
|