mirror of
https://github.com/openai/codex.git
synced 2026-05-25 21:45:22 +00:00
b77fe8fefe
## Why Once the repo-local lint exists, `codex-rs` needs to follow the checked-in convention and CI needs to keep it from drifting. This commit applies the fallback `/*param*/` style consistently across existing positional literal call sites without changing those APIs. The longer-term preference is still to avoid APIs that require comments by choosing clearer parameter types and call shapes. This PR is intentionally the mechanical follow-through for the places where the existing signatures stay in place. After rebasing onto newer `main`, the rollout also had to cover newly introduced `tui_app_server` call sites. That made it clear the first cut of the CI job was too expensive for the common path: it was spending almost as much time installing `cargo-dylint` and re-testing the lint crate as a representative test job spends running product tests. The CI update keeps the full workspace enforcement but trims that extra overhead from ordinary `codex-rs` PRs. ## What changed - keep a dedicated `argument_comment_lint` job in `rust-ci` - mechanically annotate remaining opaque positional literals across `codex-rs` with exact `/*param*/` comments, including the rebased `tui_app_server` call sites that now fall under the lint - keep the checked-in style aligned with the lint policy by using `/*param*/` and leaving string and char literals uncommented - cache `cargo-dylint`, `dylint-link`, and the relevant Cargo registry/git metadata in the lint job - split changed-path detection so the lint crate's own `cargo test` step runs only when `tools/argument-comment-lint/*` or `rust-ci.yml` changes - continue to run the repo wrapper over the `codex-rs` workspace, so product-code enforcement is unchanged Most of the code changes in this commit are intentionally mechanical comment rewrites or insertions driven by the lint itself. ## Verification - `./tools/argument-comment-lint/run.sh --workspace` - `cargo test -p codex-tui-app-server -p codex-tui` - parsed `.github/workflows/rust-ci.yml` locally with PyYAML --- * -> #14652 * #14651
47 lines
1.2 KiB
Rust
47 lines
1.2 KiB
Rust
use crate::render::renderable::Renderable;
|
||
use crate::render::renderable::RowRenderable;
|
||
use ratatui::style::Style;
|
||
use ratatui::style::Styled as _;
|
||
use ratatui::style::Stylize as _;
|
||
use ratatui::widgets::Paragraph;
|
||
use ratatui::widgets::Wrap;
|
||
use unicode_width::UnicodeWidthStr;
|
||
|
||
pub(crate) fn selection_option_row(
|
||
index: usize,
|
||
label: String,
|
||
is_selected: bool,
|
||
) -> Box<dyn Renderable> {
|
||
selection_option_row_with_dim(index, label, is_selected, /*dim*/ false)
|
||
}
|
||
|
||
pub(crate) fn selection_option_row_with_dim(
|
||
index: usize,
|
||
label: String,
|
||
is_selected: bool,
|
||
dim: bool,
|
||
) -> Box<dyn Renderable> {
|
||
let prefix = if is_selected {
|
||
format!("› {}. ", index + 1)
|
||
} else {
|
||
format!(" {}. ", index + 1)
|
||
};
|
||
let style = if is_selected {
|
||
Style::default().cyan()
|
||
} else if dim {
|
||
Style::default().dim()
|
||
} else {
|
||
Style::default()
|
||
};
|
||
let prefix_width = UnicodeWidthStr::width(prefix.as_str()) as u16;
|
||
let mut row = RowRenderable::new();
|
||
row.push(prefix_width, prefix.set_style(style));
|
||
row.push(
|
||
u16::MAX,
|
||
Paragraph::new(label)
|
||
.style(style)
|
||
.wrap(Wrap { trim: false }),
|
||
);
|
||
row.into()
|
||
}
|