mirror of
https://github.com/openai/codex.git
synced 2026-04-26 23:55:25 +00:00
fa2a2f0be9
## Why The argument-comment lint now has a packaged DotSlash artifact from [#15198](https://github.com/openai/codex/pull/15198), so the normal repo lint path should use that released payload instead of rebuilding the lint from source every time. That keeps `just clippy` and CI aligned with the shipped artifact while preserving a separate source-build path for people actively hacking on the lint crate. The current alpha package also exposed two integration wrinkles that the repo-side prebuilt wrapper needs to smooth over: - the bundled Dylint library filename includes the host triple, for example `@nightly-2025-09-18-aarch64-apple-darwin`, and Dylint derives `RUSTUP_TOOLCHAIN` from that filename - on Windows, Dylint's driver path also expects `RUSTUP_HOME` to be present in the environment Without those adjustments, the prebuilt CI jobs fail during `cargo metadata` or driver setup. This change makes the checked-in prebuilt wrapper normalize the packaged library name to the plain `nightly-2025-09-18` channel before invoking `cargo-dylint`, and it teaches both the wrapper and the packaged runner source to infer `RUSTUP_HOME` from `rustup show home` when the environment does not already provide it. After the prebuilt Windows lint job started running successfully, it also surfaced a handful of existing anonymous literal callsites in `windows-sandbox-rs`. This PR now annotates those callsites so the new cross-platform lint job is green on the current tree. ## What Changed - checked in the current `tools/argument-comment-lint/argument-comment-lint` DotSlash manifest - kept `tools/argument-comment-lint/run.sh` as the source-build wrapper for lint development - added `tools/argument-comment-lint/run-prebuilt-linter.sh` as the normal enforcement path, using the checked-in DotSlash package and bundled `cargo-dylint` - updated `just clippy` and `just argument-comment-lint` to use the prebuilt wrapper - split `.github/workflows/rust-ci.yml` so source-package checks live in a dedicated `argument_comment_lint_package` job, while the released lint runs in an `argument_comment_lint_prebuilt` matrix on Linux, macOS, and Windows - kept the pinned `nightly-2025-09-18` toolchain install in the prebuilt CI matrix, since the prebuilt package still relies on rustup-provided toolchain components - updated `tools/argument-comment-lint/run-prebuilt-linter.sh` to normalize host-qualified nightly library filenames, keep the `rustup` shim directory ahead of direct toolchain `cargo` binaries, and export `RUSTUP_HOME` when needed for Windows Dylint driver setup - updated `tools/argument-comment-lint/src/bin/argument-comment-lint.rs` so future published DotSlash artifacts apply the same nightly-filename normalization and `RUSTUP_HOME` inference internally - fixed the remaining Windows lint violations in `codex-rs/windows-sandbox-rs` by adding the required `/*param*/` comments at the reported callsites - documented the checked-in DotSlash file, wrapper split, archive layout, nightly prerequisite, and Windows `RUSTUP_HOME` requirement in `tools/argument-comment-lint/README.md`
80 lines
2.7 KiB
Plaintext
Executable File
80 lines
2.7 KiB
Plaintext
Executable File
#!/usr/bin/env dotslash
|
|
|
|
{
|
|
"name": "argument-comment-lint",
|
|
"platforms": {
|
|
"macos-aarch64": {
|
|
"size": 3402747,
|
|
"hash": "blake3",
|
|
"digest": "a11669d2f184a2c6f226cedce1bf10d1ec478d53413c42fe80d17dd873fdb2d7",
|
|
"format": "tar.gz",
|
|
"path": "argument-comment-lint/bin/argument-comment-lint",
|
|
"providers": [
|
|
{
|
|
"url": "https://github.com/openai/codex/releases/download/rust-v0.117.0-alpha.2/argument-comment-lint-aarch64-apple-darwin.tar.gz"
|
|
},
|
|
{
|
|
"type": "github-release",
|
|
"repo": "https://github.com/openai/codex",
|
|
"tag": "rust-v0.117.0-alpha.2",
|
|
"name": "argument-comment-lint-aarch64-apple-darwin.tar.gz"
|
|
}
|
|
]
|
|
},
|
|
"linux-x86_64": {
|
|
"size": 3869711,
|
|
"hash": "blake3",
|
|
"digest": "1015f4ba07d57edc5ec79c8f6709ddc1516f64c903e909820437a4b89d8d853a",
|
|
"format": "tar.gz",
|
|
"path": "argument-comment-lint/bin/argument-comment-lint",
|
|
"providers": [
|
|
{
|
|
"url": "https://github.com/openai/codex/releases/download/rust-v0.117.0-alpha.2/argument-comment-lint-x86_64-unknown-linux-gnu.tar.gz"
|
|
},
|
|
{
|
|
"type": "github-release",
|
|
"repo": "https://github.com/openai/codex",
|
|
"tag": "rust-v0.117.0-alpha.2",
|
|
"name": "argument-comment-lint-x86_64-unknown-linux-gnu.tar.gz"
|
|
}
|
|
]
|
|
},
|
|
"linux-aarch64": {
|
|
"size": 3759446,
|
|
"hash": "blake3",
|
|
"digest": "91f2a31e6390ca728ad09ae1aa6b6f379c67d996efcc22956001df89f068af5b",
|
|
"format": "tar.gz",
|
|
"path": "argument-comment-lint/bin/argument-comment-lint",
|
|
"providers": [
|
|
{
|
|
"url": "https://github.com/openai/codex/releases/download/rust-v0.117.0-alpha.2/argument-comment-lint-aarch64-unknown-linux-gnu.tar.gz"
|
|
},
|
|
{
|
|
"type": "github-release",
|
|
"repo": "https://github.com/openai/codex",
|
|
"tag": "rust-v0.117.0-alpha.2",
|
|
"name": "argument-comment-lint-aarch64-unknown-linux-gnu.tar.gz"
|
|
}
|
|
]
|
|
},
|
|
"windows-x86_64": {
|
|
"size": 3244599,
|
|
"hash": "blake3",
|
|
"digest": "dc711c6d85b1cabbe52447dda3872deb20c2e64b155da8be0ecb207c7c391683",
|
|
"format": "zip",
|
|
"path": "argument-comment-lint/bin/argument-comment-lint.exe",
|
|
"providers": [
|
|
{
|
|
"url": "https://github.com/openai/codex/releases/download/rust-v0.117.0-alpha.2/argument-comment-lint-x86_64-pc-windows-msvc.zip"
|
|
},
|
|
{
|
|
"type": "github-release",
|
|
"repo": "https://github.com/openai/codex",
|
|
"tag": "rust-v0.117.0-alpha.2",
|
|
"name": "argument-comment-lint-x86_64-pc-windows-msvc.zip"
|
|
}
|
|
]
|
|
}
|
|
}
|
|
}
|