daveaitel-openai ef36d39199 Fix agent jobs finalization race and reduce status polling churn (#14843) ...

## Summary
- make `report_agent_job_result` atomically transition an item from
running to completed while storing `result_json`
- remove brittle finalization grace-sleep logic and make finished-item
cleanup idempotent
- replace blind fixed-interval waiting with status-subscription-based
waiting for active worker threads
- add state runtime tests for atomic completion and late-report
rejection

## Why
This addresses the race and polling concerns in #13948 by removing
timing-based correctness assumptions and reducing unnecessary status
polling churn.

## Validation
- `cd codex-rs && just fmt`
- `cd codex-rs && cargo test -p codex-state`
- `cd codex-rs && cargo test -p codex-core --test all suite::agent_jobs`
- `cd codex-rs && cargo test`
- fails in an unrelated app-server tracing test:
`message_processor::tracing_tests::thread_start_jsonrpc_span_exports_server_span_and_parents_children`
timed out waiting for response

## Notes
- This PR supersedes #14129 with the same agent-jobs fix on a clean
branch from `main`.
- The earlier PR branch was stacked on unrelated history, which made the
review diff include unrelated commits.

Fixes #13948

2026-03-17 10:40:14 -04:00

..

agent

[codex] add Jason as a predefined subagent name (#14881)

2026-03-16 22:01:14 -07:00

apps

[apps] Add tool call meta. (#14647)

2026-03-14 22:24:13 -07:00

auth

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

bin

…

codex

feat(core): persist trace_id for turns in RolloutItem::TurnContext (#13602)

2026-03-05 13:26:48 -08:00

config

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

config_loader

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

context_manager

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

features

Rename reject approval policy to granular (#14516)

2026-03-12 16:38:04 -07:00

guardian

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

instructions

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

mcp

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

memories

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

models_manager

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

packages

feat: centralize package manager version (#14920)

2026-03-17 12:03:07 +00:00

plugins

fix: align marketplace display name with existing interface conventions (#14886)

2026-03-16 21:52:19 -07:00

rollout

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

sandboxing

fix: canonicalize symlinked Linux sandbox cwd (#14849)

2026-03-16 22:39:18 -07:00

skills

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

state

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

tasks

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

tools

Fix agent jobs finalization race and reduce status polling churn (#14843)

2026-03-17 10:40:14 -04:00

unified_exec

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

analytics_client_tests.rs

Add plugin usage telemetry (#14531)

2026-03-12 19:22:30 -07:00

analytics_client.rs

Add plugin usage telemetry (#14531)

2026-03-12 19:22:30 -07:00

api_bridge_tests.rs

Add auth 401 observability to client bug reports (#14611)

2026-03-14 15:38:51 -07:00

api_bridge.rs

Add auth 401 observability to client bug reports (#14611)

2026-03-14 15:38:51 -07:00

apply_patch_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

apply_patch.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

arc_monitor_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

arc_monitor.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

auth_tests.rs

Add auth 401 observability to client bug reports (#14611)

2026-03-14 15:38:51 -07:00

auth.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

client_common_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

client_common.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

client_tests.rs

Add auth 401 observability to client bug reports (#14611)

2026-03-14 15:38:51 -07:00

client.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

codex_delegate_tests.rs

Add Smart Approvals guardian review across core, app-server, and TUI (#13860)

2026-03-13 15:27:00 -07:00

codex_delegate.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

codex_tests_guardian.rs

Reuse guardian session across approvals (#14668)

2026-03-15 22:56:18 -07:00

codex_tests.rs

[stack 2/4] Align main realtime v2 wire and runtime flow (#14830)

2026-03-16 21:38:07 -07:00

codex_thread.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

codex.rs

[stack 2/4] Align main realtime v2 wire and runtime flow (#14830)

2026-03-16 21:38:07 -07:00

command_canonicalization_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

command_canonicalization.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

commit_attribution_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

commit_attribution.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

compact_remote.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

compact_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

compact.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

connectors_tests.rs

Override local apps settings with requirements.toml settings (#14304)

2026-03-13 12:40:24 -07:00

connectors.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

consequential_tool_message_templates.json

[elicitation] User-friendly tool call messages. (#14403)

2026-03-12 00:35:21 -07:00

contextual_user_message_tests.rs

memories: exclude AGENTS and skills from stage1 input (#14268)

2026-03-16 19:30:38 +00:00

contextual_user_message.rs

memories: exclude AGENTS and skills from stage1 input (#14268)

2026-03-16 19:30:38 +00:00

custom_prompts_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

custom_prompts.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

default_client_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

default_client.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

env.rs

…

environment_context_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

environment_context.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

error_tests.rs

Add auth 401 observability to client bug reports (#14611)

2026-03-14 15:38:51 -07:00

error.rs

Add auth 401 observability to client bug reports (#14611)

2026-03-14 15:38:51 -07:00

event_mapping_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

event_mapping.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

exec_env_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

exec_env.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

exec_policy_tests.rs

Rename reject approval policy to granular (#14516)

2026-03-12 16:38:04 -07:00

exec_policy.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

exec_tests.rs

Use a private desktop for Windows sandbox instead of Winsta0\Default (#14400)

2026-03-13 10:13:39 -07:00

exec.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

external_agent_config_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

external_agent_config.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

features_tests.rs

Reuse guardian session across approvals (#14668)

2026-03-15 22:56:18 -07:00

features.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

file_watcher_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

file_watcher.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

flags.rs

…

function_tool.rs

…

git_info_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

git_info.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

landlock_tests.rs

fix: canonicalize symlinked Linux sandbox cwd (#14849)

2026-03-16 22:39:18 -07:00

landlock.rs

fix: canonicalize symlinked Linux sandbox cwd (#14849)

2026-03-16 22:39:18 -07:00

lib.rs

feat: centralize package manager version (#14920)

2026-03-17 12:03:07 +00:00

mcp_connection_manager_tests.rs

Normalize MCP tool names to code-mode safe form (#14605)

2026-03-13 14:50:16 -07:00

mcp_connection_manager.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

mcp_tool_approval_templates.rs

fix(core): preserve tool_params for elicitations (#14769)

2026-03-15 23:15:52 -07:00

mcp_tool_call_tests.rs

fix(core): preserve tool_params for elicitations (#14769)

2026-03-15 23:15:52 -07:00

mcp_tool_call.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

memory_trace_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

memory_trace.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

mention_syntax.rs

chore: use @plugin instead of $plugin for plaintext mentions (#13921)

2026-03-08 01:36:39 +00:00

mentions_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

mentions.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

message_history_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

message_history.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

model_provider_info_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

model_provider_info.rs

Add openai_base_url config override for built-in provider (#12031)

2026-03-13 20:12:25 -06:00

network_policy_decision_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

network_policy_decision.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

network_proxy_loader_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

network_proxy_loader.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

original_image_detail_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

original_image_detail.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

otel_init.rs

fix(otel): make HTTP trace export survive app-server runtimes (#14300)

2026-03-11 12:33:10 -07:00

path_utils_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

path_utils.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

personality_migration_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

personality_migration.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

project_doc_tests.rs

move plugin/skill instructions into dev msg and reorder (#14609)

2026-03-13 20:51:01 -07:00

project_doc.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

realtime_context_tests.rs

[stack 3/4] Add current thread context to realtime startup (#14829)

2026-03-17 05:11:05 +00:00

realtime_context.rs

[stack 3/4] Add current thread context to realtime startup (#14829)

2026-03-17 05:11:05 +00:00

realtime_conversation_tests.rs

[stack 2/4] Align main realtime v2 wire and runtime flow (#14830)

2026-03-16 21:38:07 -07:00

realtime_conversation.rs

[stack 2/4] Align main realtime v2 wire and runtime flow (#14830)

2026-03-16 21:38:07 -07:00

response_debug_context.rs

Add auth 401 observability to client bug reports (#14611)

2026-03-14 15:38:51 -07:00

restricted_read_only_platform_defaults.sbpl

feat: Add additional macOS Sandbox Permissions for Launch Services, Contacts, Reminders (#14155)

2026-03-11 12:33:09 -07:00

review_format.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

review_prompts.rs

…

safety_tests.rs

Rename reject approval policy to granular (#14516)

2026-03-12 16:38:04 -07:00

safety.rs

Rename reject approval policy to granular (#14516)

2026-03-12 16:38:04 -07:00

sandbox_tags_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

sandbox_tags.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

seatbelt_base_policy.sbpl

[feat] add seatbelt permission files (#11639)

2026-02-12 23:30:22 +00:00

seatbelt_network_policy.sbpl

feat(sandbox): enforce proxy-aware network routing in sandbox (#11113)

2026-02-10 07:44:21 +00:00

seatbelt_permissions_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

seatbelt_permissions.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

seatbelt_tests.rs

fix: fix symlinked writable roots in sandbox policies (#14674)

2026-03-14 13:24:43 -07:00

seatbelt.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

session_prefix.rs

feat: add post-compaction sub-agent infos (#12774)

2026-02-26 18:55:34 +00:00

shell_detect.rs

chore: rename codex-command to codex-shell-command (#11378)

2026-02-10 17:03:46 -08:00

shell_snapshot_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

shell_snapshot.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

shell_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

shell.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

spawn.rs

sandboxing: plumb split sandbox policies through runtime (#13439)

2026-03-07 02:30:21 +00:00

state_db_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

state_db.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

stream_events_utils_tests.rs

sending back imagaegencall response back to responseapi (#14558)

2026-03-13 17:29:19 +00:00

stream_events_utils.rs

sending back imagaegencall response back to responseapi (#14558)

2026-03-13 17:29:19 +00:00

terminal_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

terminal.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

test_support.rs

Enable request_user_input in Default mode (#12735)

2026-02-25 15:20:46 -08:00

text_encoding_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

text_encoding.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

thread_manager_tests.rs

Add openai_base_url config override for built-in provider (#12031)

2026-03-13 20:12:25 -06:00

thread_manager.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

token_data_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

token_data.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

truncate_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

truncate.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

turn_diff_tracker_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

turn_diff_tracker.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

turn_metadata_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

turn_metadata.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

turn_timing_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

turn_timing.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

user_shell_command_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

user_shell_command.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

util_tests.rs

Add auth 401 observability to client bug reports (#14611)

2026-03-14 15:38:51 -07:00

util.rs

Add auth 401 observability to client bug reports (#14611)

2026-03-14 15:38:51 -07:00

web_search.rs

add missing fields to WebSearchAction and update app-server types (#10276)

2026-01-30 16:37:56 -08:00

windows_sandbox_read_grants_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

windows_sandbox_read_grants.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

windows_sandbox_tests.rs

Use a private desktop for Windows sandbox instead of Winsta0\Default (#14400)

2026-03-13 10:13:39 -07:00

windows_sandbox.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00